[ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki]

Was installing libraries into wrong directories.

Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
 rules/pre/Rules.make | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
index 99e459ce2..93645a42a 100644
--- a/rules/pre/Rules.make
+++ b/rules/pre/Rules.make
@@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
 
 CROSS_CMAKE_USR	 := \
 	-DCMAKE_INSTALL_PREFIX=/usr \
+	-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
 	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
 	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
 	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
-- 
2.31.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Michael Olbrich]

On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
> Was installing libraries into wrong directories.
> 
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> ---
>  rules/pre/Rules.make | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> index 99e459ce2..93645a42a 100644
> --- a/rules/pre/Rules.make
> +++ b/rules/pre/Rules.make
> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>  
>  CROSS_CMAKE_USR	 := \
>  	-DCMAKE_INSTALL_PREFIX=/usr \
> +	-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \

Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.

Otherwise the dir is taken as relative to the package build dir, at least
for libjpeg.

Michael

>  	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
>  	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>  	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
> -- 
> 2.31.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki]

On 5/21/21 12:40 PM, Michael Olbrich wrote:
> On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
>> Was installing libraries into wrong directories.
>>
>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>> ---
>>   rules/pre/Rules.make | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
>> index 99e459ce2..93645a42a 100644
>> --- a/rules/pre/Rules.make
>> +++ b/rules/pre/Rules.make
>> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>>   
>>   CROSS_CMAKE_USR	 := \
>>   	-DCMAKE_INSTALL_PREFIX=/usr \
>> +	-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> 
> Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
> 
> Otherwise the dir is taken as relative to the package build dir, at least
> for libjpeg.
> 
> Michael
> 

Hm. Jury's out on that one.
I looked it over before I added it and I think it should be relative?

https://bugzilla.redhat.com/show_bug.cgi?id=795542
https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a

Seems spec confusion has caused both variants to exist in the wild?
But it was changed a long time ago to relative...

Christian

>>   	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
>>   	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>>   	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
>> -- 
>> 2.31.1
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki]

On 5/21/21 12:52 PM, Christian Melki wrote:
> On 5/21/21 12:40 PM, Michael Olbrich wrote:
>> On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
>>> Was installing libraries into wrong directories.
>>>
>>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>>> ---
>>>   rules/pre/Rules.make | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
>>> index 99e459ce2..93645a42a 100644
>>> --- a/rules/pre/Rules.make
>>> +++ b/rules/pre/Rules.make
>>> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := 
>>> $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>>>   CROSS_CMAKE_USR     := \
>>>       -DCMAKE_INSTALL_PREFIX=/usr \
>>> +    -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>>
>> Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
>>
>> Otherwise the dir is taken as relative to the package build dir, at least
>> for libjpeg.
>>
>> Michael
>>
> 
> Hm. Jury's out on that one.
> I looked it over before I added it and I think it should be relative?
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=795542
> https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a 
> 
> 
> Seems spec confusion has caused both variants to exist in the wild?
> But it was changed a long time ago to relative...
> 
> Christian
> 

Looking closer...
Maybe the only way to get this right is to specify the absolute path.
I'm happy with that.

>>>       -DCMAKE_INSTALL_SYSCONFDIR=/etc \
>>>       -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>>>       -DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
>>> -- 
>>> 2.31.1
>>>
>>>
>>> _______________________________________________
>>> ptxdist mailing list
>>> ptxdist@pengutronix.de
>>> To unsubscribe, send a mail with subject "unsubscribe" to 
>>> ptxdist-request@pengutronix.de
>>>
>>
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to 
> ptxdist-request@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Michael Olbrich]

Thanks, applied as 62f3fc6e4bf95377317307aac6f76a34331f3a2e.

Michael

[sent from post-receive hook]

On Thu, 27 May 2021 08:45:50 +0200, Christian Melki <christian.melki@t2data.com> wrote:
> Was installing libraries into wrong directories.
> 
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> Message-Id: <20210518133401.22478-1-christian.melki@t2data.com>
> [mol: add /usr/]
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> index 99e459ce2182..e132cc33d291 100644
> --- a/rules/pre/Rules.make
> +++ b/rules/pre/Rules.make
> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>  
>  CROSS_CMAKE_USR	 := \
>  	-DCMAKE_INSTALL_PREFIX=/usr \
> +	-DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) \
>  	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
>  	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>  	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Denis Osterland-Heim]

Hi,

I have encountered an problem with this patch in cmake based users of sdbus-cpp package.
This are the difference of installed cmake file after the patch:
--- a/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake
+++ b/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake
@@ -41,23 +41,8 @@
 unset(_expectedTargets)


-# Compute the installation prefix relative to this file.
-get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
-# Use original install
prefix when loaded through a
-# cross-prefix symbolic link such as /lib -> /usr/lib.
-get_filename_component(_realCurr "${_IMPORT_PREFIX}" REALPATH)
-get_filename_component(_realOrig
"/usr/lib/cmake/sdbus-c++" REALPATH)
-if(_realCurr STREQUAL _realOrig)
-  set(_IMPORT_PREFIX "/usr/lib/cmake/sdbus-c++")
-endif()
-unset(_realOrig)
-unset(_realCurr)
-get_filename_component(_IMPORT_PREFIX
"${_IMPORT_PREFIX}" PATH)
-get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
-get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
-if(_IMPORT_PREFIX STREQUAL "/")
-  set(_IMPORT_
PREFIX "")
-endif()
+# The installation prefix configured by this project.
+set(_IMPORT_PREFIX "/usr")

 # Create imported target SDBusCpp::sdbus-c++
 add_library(SDBusCpp::sdbus-c++ SHARED IMPORTED)


This causes following error:
CMake Error at x/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake:83 (message):
  The imported target "SDBusCpp::sdbus-c++" references the file

     "/usr/lib/libsdbus-c++.so.0.8.2"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "x/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake"

  but not all the files it references.
It looks like an effect mentioned in https://cmake.org/pipermail/cmake/2012-February/049250.html
and works with the initial relative version.

Unfortunately it looks like none of both variants is unconditionally right.
I am not sure how to handle this this properly, but I know that this is ugly:
--- a/rules/sdbus-cpp.make
+++ b/rules/sdbus-cpp.make
@@ -29,7 +29,8 @@

 SDBUS_CPP_CONF_TOOL:= cmake
 SDBUS_CPP_CONF_OPT:= \
-$(CROSS_CMAKE_USR) \
+$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
+-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
 -DBUILD_TESTS=OFF \
 -DBUILD_CODE_GEN=OFF \
 -DBUILD_DOC=OFF

Regards, Denis

Am Freitag, den 21.05.2021, 13:03 +0200 schrieb Christian Melki:
> On 5/21/21 12:52 PM, Christian Melki wrote:
> > On 5/21/21 12:40 PM, Michael Olbrich wrote:
> > > On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
> > > > Was installing libraries into wrong directories.
> > > >
> > > > Signed-off-by: Christian Melki <christian.melki@t2data.com>
> > > > ---
> > > >   rules/pre/Rules.make | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> > > > index 99e459ce2..93645a42a 100644
> > > > --- a/rules/pre/Rules.make
> > > > +++ b/rules/pre/Rules.make
> > > > @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT :=
> > > > $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
> > > >   CROSS_CMAKE_USR     := \
> > > >       -DCMAKE_INSTALL_PREFIX=/usr \
> > > > +    -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> > >
> > > Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
> > >
> > > Otherwise the dir is taken as relative to the package build dir, at least
> > > for libjpeg.
> > >
> > > Michael
> > >
> >
> > Hm. Jury's out on that one.
> > I looked it over before I added it and I think it should be relative?
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=795542
> > https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a
> >
> >
> > Seems spec confusion has caused both variants to exist in the wild?
> > But it was changed a long time ago to relative...
> >
> > Christian
> >
>
> Looking closer...
> Maybe the only way to get this right is to specify the absolute path.
> I'm happy with that.
>
> > > >       -DCMAKE_INSTALL_SYSCONFDIR=/etc \
> > > >       -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
> > > >       -DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
> > > > --
> > > > 2.31.1
> > > >
> > > >
> > > > _______________________________________________
> > > > ptxdist mailing list
> > > > ptxdist@pengutronix.de
> > > > To unsubscribe, send a mail with subject "unsubscribe" to
> > > > ptxdist-request@pengutronix.de
> > > >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to
> > ptxdist-request@pengutronix.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki]

Sigh. Spec ambiguity mishmash.

AFAIU, spec says that LIBDIR is relative.
CMake then constructs FULL_* variants of the corresponding ones as
absolute paths if not already set.

I'd prefer a relative LIBDIR and then patch programs that have a broken
behavior. But that's probably no less of a pain...

Regards,
Christian

On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> Hi,
> 
> I have encountered an problem with this patch in cmake based users of sdbus-cpp package.
> This are the difference of installed cmake file after the patch:
> --- a/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake
> +++ b/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake
> @@ -41,23 +41,8 @@
>  unset(_expectedTargets)
> 
> 
> -# Compute the installation prefix relative to this file.
> -get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
> -# Use original install
> prefix when loaded through a
> -# cross-prefix symbolic link such as /lib -> /usr/lib.
> -get_filename_component(_realCurr "${_IMPORT_PREFIX}" REALPATH)
> -get_filename_component(_realOrig
> "/usr/lib/cmake/sdbus-c++" REALPATH)
> -if(_realCurr STREQUAL _realOrig)
> -  set(_IMPORT_PREFIX "/usr/lib/cmake/sdbus-c++")
> -endif()
> -unset(_realOrig)
> -unset(_realCurr)
> -get_filename_component(_IMPORT_PREFIX
> "${_IMPORT_PREFIX}" PATH)
> -get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> -get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> -if(_IMPORT_PREFIX STREQUAL "/")
> -  set(_IMPORT_
> PREFIX "")
> -endif()
> +# The installation prefix configured by this project.
> +set(_IMPORT_PREFIX "/usr")
> 
>  # Create imported target SDBusCpp::sdbus-c++
>  add_library(SDBusCpp::sdbus-c++ SHARED IMPORTED)
> 
> 
> This causes following error:
> CMake Error at x/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake:83 (message):
>   The imported target "SDBusCpp::sdbus-c++" references the file
> 
>      "/usr/lib/libsdbus-c++.so.0.8.2"
> 
>   but this file does not exist.  Possible reasons include:
> 
>   * The file was deleted, renamed, or moved to another location.
> 
>   * An install or uninstall procedure did not complete successfully.
> 
>   * The installation package was faulty and contained
> 
>      "x/sysroot-target/usr/lib/cmake/sdbus-c++/sdbus-c++-targets.cmake"
> 
>   but not all the files it references.
> It looks like an effect mentioned in https://cmake.org/pipermail/cmake/2012-February/049250.html
> and works with the initial relative version.
> 
> Unfortunately it looks like none of both variants is unconditionally right.
> I am not sure how to handle this this properly, but I know that this is ugly:
> --- a/rules/sdbus-cpp.make
> +++ b/rules/sdbus-cpp.make
> @@ -29,7 +29,8 @@
> 
>  SDBUS_CPP_CONF_TOOL:= cmake
>  SDBUS_CPP_CONF_OPT:= \
> -$(CROSS_CMAKE_USR) \
> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>  -DBUILD_TESTS=OFF \
>  -DBUILD_CODE_GEN=OFF \
>  -DBUILD_DOC=OFF
> 
> Regards, Denis
> 
> Am Freitag, den 21.05.2021, 13:03 +0200 schrieb Christian Melki:
>> On 5/21/21 12:52 PM, Christian Melki wrote:
>>> On 5/21/21 12:40 PM, Michael Olbrich wrote:
>>>> On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
>>>>> Was installing libraries into wrong directories.
>>>>>
>>>>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>>>>> ---
>>>>>   rules/pre/Rules.make | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
>>>>> index 99e459ce2..93645a42a 100644
>>>>> --- a/rules/pre/Rules.make
>>>>> +++ b/rules/pre/Rules.make
>>>>> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT :=
>>>>> $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>>>>>   CROSS_CMAKE_USR     := \
>>>>>       -DCMAKE_INSTALL_PREFIX=/usr \
>>>>> +    -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>>>>
>>>> Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
>>>>
>>>> Otherwise the dir is taken as relative to the package build dir, at least
>>>> for libjpeg.
>>>>
>>>> Michael
>>>>
>>>
>>> Hm. Jury's out on that one.
>>> I looked it over before I added it and I think it should be relative?
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=795542
>>> https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a
>>>
>>>
>>> Seems spec confusion has caused both variants to exist in the wild?
>>> But it was changed a long time ago to relative...
>>>
>>> Christian
>>>
>>
>> Looking closer...
>> Maybe the only way to get this right is to specify the absolute path.
>> I'm happy with that.
>>
>>>>>       -DCMAKE_INSTALL_SYSCONFDIR=/etc \
>>>>>       -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>>>>>       -DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
>>>>> --
>>>>> 2.31.1
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> ptxdist mailing list
>>>>> ptxdist@pengutronix.de
>>>>> To unsubscribe, send a mail with subject "unsubscribe" to
>>>>> ptxdist-request@pengutronix.de
>>>>>
>>>
>>> _______________________________________________
>>> ptxdist mailing list
>>> ptxdist@pengutronix.de
>>> To unsubscribe, send a mail with subject "unsubscribe" to
>>> ptxdist-request@pengutronix.de
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> 
> ________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> 
> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> 
> https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> 
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> 
> - For general information on data protection and your respective rights please visit:
> 
> https://www.diehl.com/group/en/transparency-and-information-obligations/
> 
> 


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[m.olbrich]

Hi,

On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> Sigh. Spec ambiguity mishmash.
> 
> AFAIU, spec says that LIBDIR is relative.
> CMake then constructs FULL_* variants of the corresponding ones as
> absolute paths if not already set.
> 
> I'd prefer a relative LIBDIR and then patch programs that have a broken
> behavior. But that's probably no less of a pain...

I don't mind either way. Maybe you could send patches to make it relative
again an to fix libjpeg.

> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> > --- a/rules/sdbus-cpp.make
> > +++ b/rules/sdbus-cpp.make
> > @@ -29,7 +29,8 @@
> > 
> >  SDBUS_CPP_CONF_TOOL:= cmake
> >  SDBUS_CPP_CONF_OPT:= \
> > -$(CROSS_CMAKE_USR) \
> > +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> > +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> >  -DBUILD_TESTS=OFF \
> >  -DBUILD_CODE_GEN=OFF \
> >  -DBUILD_DOC=OFF

Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
would expect that cmake simply used the last one specified if a variable is
added twice.

Christian, I would prefer something like that for libjpeg instead of adding
a patch.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Denis Osterland-Heim]

Hi Michael,

Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
> Hi,
>
> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> > Sigh. Spec ambiguity mishmash.
> >
> > AFAIU, spec says that LIBDIR is relative.
> > CMake then constructs FULL_* variants of the corresponding ones as
> > absolute paths if not already set.
> >
> > I'd prefer a relative LIBDIR and then patch programs that have a broken
> > behavior. But that's probably no less of a pain...
>
> I don't mind either way. Maybe you could send patches to make it relative
> again an to fix libjpeg.
>
> > On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> > > --- a/rules/sdbus-cpp.make
> > > +++ b/rules/sdbus-cpp.make
> > > @@ -29,7 +29,8 @@
> > >
> > >  SDBUS_CPP_CONF_TOOL:= cmake
> > >  SDBUS_CPP_CONF_OPT:= \
> > > -$(CROSS_CMAKE_USR) \
> > > +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> > > +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> > >  -DBUILD_TESTS=OFF \
> > >  -DBUILD_CODE_GEN=OFF \
> > >  -DBUILD_DOC=OFF
>
> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
> would expect that cmake simply used the last one specified if a variable is
> added twice.
Looks much easier.
I guess, I have thought to complex...

Thanks for the hint.

>
> Christian, I would prefer something like that for libjpeg instead of adding
> a patch.
Hi Christian,

Are you willing to do that?

Regards, Denis

>
> Michael
>
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki]

On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> Hi Michael,
> 
> Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
>> Hi,
>>
>> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
>>> Sigh. Spec ambiguity mishmash.
>>>
>>> AFAIU, spec says that LIBDIR is relative.
>>> CMake then constructs FULL_* variants of the corresponding ones as
>>> absolute paths if not already set.
>>>
>>> I'd prefer a relative LIBDIR and then patch programs that have a broken
>>> behavior. But that's probably no less of a pain...
>>
>> I don't mind either way. Maybe you could send patches to make it relative
>> again an to fix libjpeg.
>>
>>> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
>>>> --- a/rules/sdbus-cpp.make
>>>> +++ b/rules/sdbus-cpp.make
>>>> @@ -29,7 +29,8 @@
>>>>
>>>>  SDBUS_CPP_CONF_TOOL:= cmake
>>>>  SDBUS_CPP_CONF_OPT:= \
>>>> -$(CROSS_CMAKE_USR) \
>>>> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
>>>> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>>>>  -DBUILD_TESTS=OFF \
>>>>  -DBUILD_CODE_GEN=OFF \
>>>>  -DBUILD_DOC=OFF
>>
>> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
>> would expect that cmake simply used the last one specified if a variable is
>> added twice.
> Looks much easier.
> I guess, I have thought to complex...
> 
> Thanks for the hint.
> 
>>
>> Christian, I would prefer something like that for libjpeg instead of adding
>> a patch.
> Hi Christian,
> 
> Are you willing to do that?
> 
> Regards, Denis
> 

Yes. Will fix. But ETA can be in a few weeks.
Trying to get some quality non-screen time (vacation). :)
Is that timeline OK?

>>
>> Michael
>>
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> 
> ________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> 
> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> 
> https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> 
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> 
> - For general information on data protection and your respective rights please visit:
> 
> https://www.diehl.com/group/en/transparency-and-information-obligations/
> 
> 


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Denis Osterland-Heim]

Hi Christian,

Am Donnerstag, den 22.07.2021, 18:41 +0200 schrieb Christian Melki:
> On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> > Hi Michael,
> >
> > Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
> > > Hi,
> > >
> > > On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> > > > Sigh. Spec ambiguity mishmash.
> > > >
> > > > AFAIU, spec says that LIBDIR is relative.
> > > > CMake then constructs FULL_* variants of the corresponding ones as
> > > > absolute paths if not already set.
> > > >
> > > > I'd prefer a relative LIBDIR and then patch programs that have a broken
> > > > behavior. But that's probably no less of a pain...
> > >
> > > I don't mind either way. Maybe you could send patches to make it relative
> > > again an to fix libjpeg.
> > >
> > > > On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> > > > > --- a/rules/sdbus-cpp.make
> > > > > +++ b/rules/sdbus-cpp.make
> > > > > @@ -29,7 +29,8 @@
> > > > >
> > > > >  SDBUS_CPP_CONF_TOOL:= cmake
> > > > >  SDBUS_CPP_CONF_OPT:= \
> > > > > -$(CROSS_CMAKE_USR) \
> > > > > +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> > > > > +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> > > > >  -DBUILD_TESTS=OFF \
> > > > >  -DBUILD_CODE_GEN=OFF \
> > > > >  -DBUILD_DOC=OFF
> > >
> > > Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
> > > would expect that cmake simply used the last one specified if a variable is
> > > added twice.
> >
> > Looks much easier.
> > I guess, I have thought to complex...
> >
> > Thanks for the hint.
> >
> > >
> > > Christian, I would prefer something like that for libjpeg instead of adding
> > > a patch.
> >
> > Hi Christian,
> >
> > Are you willing to do that?
> >
> > Regards, Denis
> >
>
> Yes. Will fix. But ETA can be in a few weeks.
> Trying to get some quality non-screen time (vacation). :)
> Is that timeline OK?
Yes, of course. Thanks a lot in advance.

Regards, Denis

>
> > >
> > > Michael
> > >
> >
> > Diehl Connectivity Solutions GmbH
> > Geschäftsführung: Horst Leonberger
> > Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> > Nürnberg: HRB 32315
> >
> > ________________________________
> >
> > Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> > Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> > Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> >
> > - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> >
> > https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> >
> > The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> > mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> >
> > - For general information on data protection and your respective rights please visit:
> >
> > https://www.diehl.com/group/en/transparency-and-information-obligations/
> >
> >
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[m.olbrich]

On Thu, Jul 22, 2021 at 06:41:26PM +0200, Christian Melki wrote:
> On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> > Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
> >> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> >>> Sigh. Spec ambiguity mishmash.
> >>>
> >>> AFAIU, spec says that LIBDIR is relative.
> >>> CMake then constructs FULL_* variants of the corresponding ones as
> >>> absolute paths if not already set.
> >>>
> >>> I'd prefer a relative LIBDIR and then patch programs that have a broken
> >>> behavior. But that's probably no less of a pain...
> >>
> >> I don't mind either way. Maybe you could send patches to make it relative
> >> again an to fix libjpeg.
> >>
> >>> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> >>>> --- a/rules/sdbus-cpp.make
> >>>> +++ b/rules/sdbus-cpp.make
> >>>> @@ -29,7 +29,8 @@
> >>>>
> >>>>  SDBUS_CPP_CONF_TOOL:= cmake
> >>>>  SDBUS_CPP_CONF_OPT:= \
> >>>> -$(CROSS_CMAKE_USR) \
> >>>> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> >>>> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> >>>>  -DBUILD_TESTS=OFF \
> >>>>  -DBUILD_CODE_GEN=OFF \
> >>>>  -DBUILD_DOC=OFF
> >>
> >> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
> >> would expect that cmake simply used the last one specified if a variable is
> >> added twice.
> > Looks much easier.
> > I guess, I have thought to complex...
> > 
> > Thanks for the hint.
> > 
> >>
> >> Christian, I would prefer something like that for libjpeg instead of adding
> >> a patch.
> > Hi Christian,
> > 
> > Are you willing to do that?
> > 
> 
> Yes. Will fix. But ETA can be in a few weeks.
> Trying to get some quality non-screen time (vacation). :)
> Is that timeline OK?

No problem. It can be worked around in the BSP, so it doesn't need to be
fixed immediately.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de