From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 23 Jul 2021 11:24:45 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m6rQD-0001YT-Ti for lore@lore.pengutronix.de; Fri, 23 Jul 2021 11:24:45 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m6rQD-00086B-LH; Fri, 23 Jul 2021 11:24:45 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6rQ3-000861-RF; Fri, 23 Jul 2021 11:24:36 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m6rQ3-00044b-7w; Fri, 23 Jul 2021 11:24:35 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m6rQ3-007st5-4p; Fri, 23 Jul 2021 11:24:35 +0200 Date: Fri, 23 Jul 2021 11:24:35 +0200 From: "m.olbrich@pengutronix.de" To: Christian Melki Message-ID: <20210723092435.GC735550@pengutronix.de> Mail-Followup-To: Christian Melki , Denis Osterland-Heim , "ptxdist@pengutronix.de" References: <20210518133401.22478-1-christian.melki@t2data.com> <20210521104057.GC3634306@pengutronix.de> <6cd03636-eb26-c8b0-5a16-4a67c7f99654@t2data.com> <63b6606b-2bfe-46c1-e4b3-d0814705f40d@t2data.com> <20210722064644.GR15288@pengutronix.de> <2dc5f4d6-7e1f-125f-53ec-7941bdec420d@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2dc5f4d6-7e1f-125f-53ec-7941bdec420d@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Denis Osterland-Heim , "ptxdist@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Thu, Jul 22, 2021 at 06:41:26PM +0200, Christian Melki wrote: > On 7/22/21 10:07 AM, Denis Osterland-Heim wrote: > > Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de: > >> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote: > >>> Sigh. Spec ambiguity mishmash. > >>> > >>> AFAIU, spec says that LIBDIR is relative. > >>> CMake then constructs FULL_* variants of the corresponding ones as > >>> absolute paths if not already set. > >>> > >>> I'd prefer a relative LIBDIR and then patch programs that have a broken > >>> behavior. But that's probably no less of a pain... > >> > >> I don't mind either way. Maybe you could send patches to make it relative > >> again an to fix libjpeg. > >> > >>> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote: > >>>> --- a/rules/sdbus-cpp.make > >>>> +++ b/rules/sdbus-cpp.make > >>>> @@ -29,7 +29,8 @@ > >>>> > >>>> SDBUS_CPP_CONF_TOOL:= cmake > >>>> SDBUS_CPP_CONF_OPT:= \ > >>>> -$(CROSS_CMAKE_USR) \ > >>>> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \ > >>>> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \ > >>>> -DBUILD_TESTS=OFF \ > >>>> -DBUILD_CODE_GEN=OFF \ > >>>> -DBUILD_DOC=OFF > >> > >> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I > >> would expect that cmake simply used the last one specified if a variable is > >> added twice. > > Looks much easier. > > I guess, I have thought to complex... > > > > Thanks for the hint. > > > >> > >> Christian, I would prefer something like that for libjpeg instead of adding > >> a patch. > > Hi Christian, > > > > Are you willing to do that? > > > > Yes. Will fix. But ETA can be in a few weeks. > Trying to get some quality non-screen time (vacation). :) > Is that timeline OK? No problem. It can be worked around in the BSP, so it doesn't need to be fixed immediately. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de