Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Christian Melki <christian.melki@t2data.com>]

On 5/21/21 12:40 PM, Michael Olbrich wrote:
> On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
>> Was installing libraries into wrong directories.
>>
>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>> ---
>>   rules/pre/Rules.make | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
>> index 99e459ce2..93645a42a 100644
>> --- a/rules/pre/Rules.make
>> +++ b/rules/pre/Rules.make
>> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>>   
>>   CROSS_CMAKE_USR	 := \
>>   	-DCMAKE_INSTALL_PREFIX=/usr \
>> +	-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> 
> Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
> 
> Otherwise the dir is taken as relative to the package build dir, at least
> for libjpeg.
> 
> Michael
> 

Hm. Jury's out on that one.
I looked it over before I added it and I think it should be relative?

https://bugzilla.redhat.com/show_bug.cgi?id=795542
https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a

Seems spec confusion has caused both variants to exist in the wild?
But it was changed a long time ago to relative...

Christian

>>   	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
>>   	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>>   	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
>> -- 
>> 2.31.1
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de