From: Christian Melki <christian.melki@t2data.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.
Date: Fri, 21 May 2021 13:03:07 +0200 [thread overview]
Message-ID: <63b6606b-2bfe-46c1-e4b3-d0814705f40d@t2data.com> (raw)
In-Reply-To: <6cd03636-eb26-c8b0-5a16-4a67c7f99654@t2data.com>
On 5/21/21 12:52 PM, Christian Melki wrote:
> On 5/21/21 12:40 PM, Michael Olbrich wrote:
>> On Tue, May 18, 2021 at 03:34:01PM +0200, Christian Melki wrote:
>>> Was installing libraries into wrong directories.
>>>
>>> Signed-off-by: Christian Melki <christian.melki@t2data.com>
>>> ---
>>> rules/pre/Rules.make | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
>>> index 99e459ce2..93645a42a 100644
>>> --- a/rules/pre/Rules.make
>>> +++ b/rules/pre/Rules.make
>>> @@ -233,6 +233,7 @@ CROSS_AUTOCONF_ROOT :=
>>> $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>>> CROSS_CMAKE_USR := \
>>> -DCMAKE_INSTALL_PREFIX=/usr \
>>> + -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>>
>> Hmmm, I need -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) here.
>>
>> Otherwise the dir is taken as relative to the package build dir, at least
>> for libjpeg.
>>
>> Michael
>>
>
> Hm. Jury's out on that one.
> I looked it over before I added it and I think it should be relative?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=795542
> https://gitlab.kitware.com/cmake/cmake/-/commit/126c993d031f6f7be4970a67621da92f580d4e5a
>
>
> Seems spec confusion has caused both variants to exist in the wild?
> But it was changed a long time ago to relative...
>
> Christian
>
Looking closer...
Maybe the only way to get this right is to specify the absolute path.
I'm happy with that.
>>> -DCMAKE_INSTALL_SYSCONFDIR=/etc \
>>> -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>>> -DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'
>>> --
>>> 2.31.1
>>>
>>>
>>> _______________________________________________
>>> ptxdist mailing list
>>> ptxdist@pengutronix.de
>>> To unsubscribe, send a mail with subject "unsubscribe" to
>>> ptxdist-request@pengutronix.de
>>>
>>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to
> ptxdist-request@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-05-21 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 13:34 Christian Melki
2021-05-21 10:40 ` Michael Olbrich
2021-05-21 10:52 ` Christian Melki
2021-05-21 11:03 ` Christian Melki [this message]
2021-07-21 16:30 ` Denis Osterland-Heim
2021-07-21 17:54 ` Christian Melki
2021-07-22 6:46 ` m.olbrich
2021-07-22 8:07 ` Denis Osterland-Heim
2021-07-22 16:41 ` Christian Melki
2021-07-23 9:17 ` Denis Osterland-Heim
2021-07-23 9:24 ` m.olbrich
2021-05-27 6:45 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63b6606b-2bfe-46c1-e4b3-d0814705f40d@t2data.com \
--to=christian.melki@t2data.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox