Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

[Denis Osterland-Heim <denis.osterland@diehl.com>]

Hi Christian,

Am Donnerstag, den 22.07.2021, 18:41 +0200 schrieb Christian Melki:
> On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> > Hi Michael,
> >
> > Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
> > > Hi,
> > >
> > > On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> > > > Sigh. Spec ambiguity mishmash.
> > > >
> > > > AFAIU, spec says that LIBDIR is relative.
> > > > CMake then constructs FULL_* variants of the corresponding ones as
> > > > absolute paths if not already set.
> > > >
> > > > I'd prefer a relative LIBDIR and then patch programs that have a broken
> > > > behavior. But that's probably no less of a pain...
> > >
> > > I don't mind either way. Maybe you could send patches to make it relative
> > > again an to fix libjpeg.
> > >
> > > > On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> > > > > --- a/rules/sdbus-cpp.make
> > > > > +++ b/rules/sdbus-cpp.make
> > > > > @@ -29,7 +29,8 @@
> > > > >
> > > > >  SDBUS_CPP_CONF_TOOL:= cmake
> > > > >  SDBUS_CPP_CONF_OPT:= \
> > > > > -$(CROSS_CMAKE_USR) \
> > > > > +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> > > > > +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> > > > >  -DBUILD_TESTS=OFF \
> > > > >  -DBUILD_CODE_GEN=OFF \
> > > > >  -DBUILD_DOC=OFF
> > >
> > > Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
> > > would expect that cmake simply used the last one specified if a variable is
> > > added twice.
> >
> > Looks much easier.
> > I guess, I have thought to complex...
> >
> > Thanks for the hint.
> >
> > >
> > > Christian, I would prefer something like that for libjpeg instead of adding
> > > a patch.
> >
> > Hi Christian,
> >
> > Are you willing to do that?
> >
> > Regards, Denis
> >
>
> Yes. Will fix. But ETA can be in a few weeks.
> Trying to get some quality non-screen time (vacation). :)
> Is that timeline OK?
Yes, of course. Thanks a lot in advance.

Regards, Denis

>
> > >
> > > Michael
> > >
> >
> > Diehl Connectivity Solutions GmbH
> > Geschäftsführung: Horst Leonberger
> > Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> > Nürnberg: HRB 32315
> >
> > ________________________________
> >
> > Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> > Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> > Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> >
> > - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> >
> > https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> >
> > The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> > mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> >
> > - For general information on data protection and your respective rights please visit:
> >
> > https://www.diehl.com/group/en/transparency-and-information-obligations/
> >
> >
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de