Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.

["m.olbrich@pengutronix.de" <m.olbrich@pengutronix.de>]

On Thu, Jul 22, 2021 at 06:41:26PM +0200, Christian Melki wrote:
> On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> > Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
> >> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
> >>> Sigh. Spec ambiguity mishmash.
> >>>
> >>> AFAIU, spec says that LIBDIR is relative.
> >>> CMake then constructs FULL_* variants of the corresponding ones as
> >>> absolute paths if not already set.
> >>>
> >>> I'd prefer a relative LIBDIR and then patch programs that have a broken
> >>> behavior. But that's probably no less of a pain...
> >>
> >> I don't mind either way. Maybe you could send patches to make it relative
> >> again an to fix libjpeg.
> >>
> >>> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
> >>>> --- a/rules/sdbus-cpp.make
> >>>> +++ b/rules/sdbus-cpp.make
> >>>> @@ -29,7 +29,8 @@
> >>>>
> >>>>  SDBUS_CPP_CONF_TOOL:= cmake
> >>>>  SDBUS_CPP_CONF_OPT:= \
> >>>> -$(CROSS_CMAKE_USR) \
> >>>> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
> >>>> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
> >>>>  -DBUILD_TESTS=OFF \
> >>>>  -DBUILD_CODE_GEN=OFF \
> >>>>  -DBUILD_DOC=OFF
> >>
> >> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
> >> would expect that cmake simply used the last one specified if a variable is
> >> added twice.
> > Looks much easier.
> > I guess, I have thought to complex...
> > 
> > Thanks for the hint.
> > 
> >>
> >> Christian, I would prefer something like that for libjpeg instead of adding
> >> a patch.
> > Hi Christian,
> > 
> > Are you willing to do that?
> > 
> 
> Yes. Will fix. But ETA can be in a few weeks.
> Trying to get some quality non-screen time (vacation). :)
> Is that timeline OK?

No problem. It can be worked around in the BSP, so it doesn't need to be
fixed immediately.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de