mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Christian Melki <christian.melki@t2data.com>
To: Denis Osterland-Heim <denis.osterland@diehl.com>,
	"m.olbrich@pengutronix.de" <m.olbrich@pengutronix.de>
Cc: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] Add missing install CROSS_LIB_DIR for CMAKE environments.
Date: Thu, 22 Jul 2021 18:41:26 +0200
Message-ID: <2dc5f4d6-7e1f-125f-53ec-7941bdec420d@t2data.com> (raw)
In-Reply-To: <d639bc82db131f6ff0d9c8d99ce1a3f66023f955.camel@diehl.com>

On 7/22/21 10:07 AM, Denis Osterland-Heim wrote:
> Hi Michael,
> 
> Am Donnerstag, den 22.07.2021, 08:46 +0200 schrieb m.olbrich@pengutronix.de:
>> Hi,
>>
>> On Wed, Jul 21, 2021 at 07:54:05PM +0200, Christian Melki wrote:
>>> Sigh. Spec ambiguity mishmash.
>>>
>>> AFAIU, spec says that LIBDIR is relative.
>>> CMake then constructs FULL_* variants of the corresponding ones as
>>> absolute paths if not already set.
>>>
>>> I'd prefer a relative LIBDIR and then patch programs that have a broken
>>> behavior. But that's probably no less of a pain...
>>
>> I don't mind either way. Maybe you could send patches to make it relative
>> again an to fix libjpeg.
>>
>>> On 7/21/21 6:30 PM, Denis Osterland-Heim wrote:
>>>> --- a/rules/sdbus-cpp.make
>>>> +++ b/rules/sdbus-cpp.make
>>>> @@ -29,7 +29,8 @@
>>>>
>>>>  SDBUS_CPP_CONF_TOOL:= cmake
>>>>  SDBUS_CPP_CONF_OPT:= \
>>>> -$(CROSS_CMAKE_USR) \
>>>> +$(filter-out -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR), $(CROSS_CMAKE_USR)) \
>>>> +-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>>>>  -DBUILD_TESTS=OFF \
>>>>  -DBUILD_CODE_GEN=OFF \
>>>>  -DBUILD_DOC=OFF
>>
>> Did you try '$(CROSS_CMAKE_USR) -DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR)'? I
>> would expect that cmake simply used the last one specified if a variable is
>> added twice.
> Looks much easier.
> I guess, I have thought to complex...
> 
> Thanks for the hint.
> 
>>
>> Christian, I would prefer something like that for libjpeg instead of adding
>> a patch.
> Hi Christian,
> 
> Are you willing to do that?
> 
> Regards, Denis
> 

Yes. Will fix. But ETA can be in a few weeks.
Trying to get some quality non-screen time (vacation). :)
Is that timeline OK?

>>
>> Michael
>>
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> 
> ________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> 
> - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:
> 
> https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> 
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
> 
> - For general information on data protection and your respective rights please visit:
> 
> https://www.diehl.com/group/en/transparency-and-information-obligations/
> 
> 


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-07-22 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 13:34 Christian Melki
2021-05-21 10:40 ` Michael Olbrich
2021-05-21 10:52   ` Christian Melki
2021-05-21 11:03     ` Christian Melki
2021-07-21 16:30       ` Denis Osterland-Heim
2021-07-21 17:54         ` Christian Melki
2021-07-22  6:46           ` m.olbrich
2021-07-22  8:07             ` Denis Osterland-Heim
2021-07-22 16:41               ` Christian Melki [this message]
2021-07-23  9:17                 ` Denis Osterland-Heim
2021-07-23  9:24                 ` m.olbrich
2021-05-27  6:45 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dc5f4d6-7e1f-125f-53ec-7941bdec420d@t2data.com \
    --to=christian.melki@t2data.com \
    --cc=denis.osterland@diehl.com \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailarchive of the ptxdist mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.ptxdist.org/ptxdist/0 ptxdist/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ptxdist ptxdist/ https://lore.ptxdist.org/ptxdist \
		ptxdist@pengutronix.de
	public-inbox-index ptxdist

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git