From: Alexander Dahl <ada@thorsis.com>
To: Enrico Jorns <ejo@pengutronix.de>
Cc: ptxdist@pengutronix.de, jlu@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC
Date: Wed, 15 Jun 2022 17:48:35 +0200 [thread overview]
Message-ID: <Yqn/UzhRztbjAcfy@ada-deb-carambola.ifak-system.com> (raw)
In-Reply-To: <20220615142217.990960-4-ejo@pengutronix.de>
Hello Enrico,
this might be nitpicking, but still …
Am Wed, Jun 15, 2022 at 04:22:15PM +0200 schrieb Enrico Jorns:
> We do not need bundle creation capabilities on the target in most cases,
> thus make this optional (and disable by default).
>
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
> rules/host-rauc.make | 1 +
> rules/rauc.in | 10 ++++++++++
> rules/rauc.make | 1 +
> 3 files changed, 12 insertions(+)
>
> diff --git a/rules/host-rauc.make b/rules/host-rauc.make
> index c78a518f6..1851aee9a 100644
> --- a/rules/host-rauc.make
> +++ b/rules/host-rauc.make
> @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT := \
> $(HOST_AUTOCONF) \
> --disable-code-coverage \
> --disable-valgrind \
> + --enable-create \
>From the cover letter I understood this is a new post 1.5 option,
right?
> --disable-service \
> --disable-network \
> --disable-json
> diff --git a/rules/rauc.in b/rules/rauc.in
> index 832967b44..e43692846 100644
> --- a/rules/rauc.in
> +++ b/rules/rauc.in
> @@ -27,6 +27,16 @@ menuconfig RAUC
>
> if RAUC
>
> +config RAUC_CREATE
> + bool
> + prompt "Enable bundle creation support on target"
> + default n
> + help
> + Enables support for creating bundles on target.
> + Disabling this will remove functionality required for bundle
> + creation which is not required on the target in most cases and thus
> + allows to save space.
> +
> config RAUC_SERVICE
> bool
> prompt "Enable service (D-Bus) support"
> diff --git a/rules/rauc.make b/rules/rauc.make
> index 820583e59..e001956a5 100644
> --- a/rules/rauc.make
> +++ b/rules/rauc.make
> @@ -41,6 +41,7 @@ RAUC_CONF_OPT := \
> $(GLOBAL_LARGE_FILE_OPTION) \
> --disable-code-coverage \
> --disable-valgrind \
> + --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \
Same here. This should have set explicitly to a sensible default with
the package update. Making this optional would just change that line
then instead of adding it.
Greets
Alex
> --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \
> --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \
> --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-06-15 15:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:22 [ptxdist] [PATCH 0/5] RAUC: update to v1.7 and add some new options Enrico Jorns
2022-06-15 14:22 ` [ptxdist] [PATCH 1/5] RAUC: version bump 1.5.1 -> 1.7 Enrico Jorns
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support Enrico Jorns
2022-06-17 6:28 ` Michael Olbrich
2022-06-17 9:47 ` Enrico Jörns
2022-06-17 10:27 ` Michael Olbrich
2022-06-17 10:48 ` Michael Olbrich
2022-06-17 11:47 ` Enrico Jörns
2022-06-17 12:04 ` Michael Olbrich
2022-06-17 10:57 ` Alexander Dahl
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC Enrico Jorns
2022-06-15 15:48 ` Alexander Dahl [this message]
2022-06-15 21:03 ` Enrico Jörns
2022-06-16 6:16 ` Alexander Dahl
2022-06-16 13:53 ` Enrico Jörns
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 4/5] image-rauc: add support for crypt bundles Enrico Jorns
2022-06-20 6:20 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 5/5] image-rauc: default to 'verity' bundle format Enrico Jorns
2022-06-20 6:20 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqn/UzhRztbjAcfy@ada-deb-carambola.ifak-system.com \
--to=ada@thorsis.com \
--cc=ejo@pengutronix.de \
--cc=jlu@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox