From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 15 Jun 2022 17:49:18 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1VGf-0037Qz-Gv for lore@lore.pengutronix.de; Wed, 15 Jun 2022 17:49:18 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1VGg-0005U0-2g; Wed, 15 Jun 2022 17:49:18 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1VG6-0005Tf-Op; Wed, 15 Jun 2022 17:48:43 +0200 Date: Wed, 15 Jun 2022 17:48:35 +0200 From: Alexander Dahl To: Enrico Jorns Message-ID: Mail-Followup-To: Enrico Jorns , ptxdist@pengutronix.de, jlu@pengutronix.de References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-4-ejo@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220615142217.990960-4-ejo@pengutronix.de> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, jlu@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Enrico, this might be nitpicking, but still … Am Wed, Jun 15, 2022 at 04:22:15PM +0200 schrieb Enrico Jorns: > We do not need bundle creation capabilities on the target in most cases, > thus make this optional (and disable by default). > > Signed-off-by: Enrico Jorns > --- > rules/host-rauc.make | 1 + > rules/rauc.in | 10 ++++++++++ > rules/rauc.make | 1 + > 3 files changed, 12 insertions(+) > > diff --git a/rules/host-rauc.make b/rules/host-rauc.make > index c78a518f6..1851aee9a 100644 > --- a/rules/host-rauc.make > +++ b/rules/host-rauc.make > @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT := \ > $(HOST_AUTOCONF) \ > --disable-code-coverage \ > --disable-valgrind \ > + --enable-create \ >>From the cover letter I understood this is a new post 1.5 option, right? > --disable-service \ > --disable-network \ > --disable-json > diff --git a/rules/rauc.in b/rules/rauc.in > index 832967b44..e43692846 100644 > --- a/rules/rauc.in > +++ b/rules/rauc.in > @@ -27,6 +27,16 @@ menuconfig RAUC > > if RAUC > > +config RAUC_CREATE > + bool > + prompt "Enable bundle creation support on target" > + default n > + help > + Enables support for creating bundles on target. > + Disabling this will remove functionality required for bundle > + creation which is not required on the target in most cases and thus > + allows to save space. > + > config RAUC_SERVICE > bool > prompt "Enable service (D-Bus) support" > diff --git a/rules/rauc.make b/rules/rauc.make > index 820583e59..e001956a5 100644 > --- a/rules/rauc.make > +++ b/rules/rauc.make > @@ -41,6 +41,7 @@ RAUC_CONF_OPT := \ > $(GLOBAL_LARGE_FILE_OPTION) \ > --disable-code-coverage \ > --disable-valgrind \ > + --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \ Same here. This should have set explicitly to a sensible default with the package update. Making this optional would just change that line then instead of adding it. Greets Alex > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > -- > 2.30.2 > >