Re: [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote:
> Enable it by default so that default installation can benefit from this.
> Can be deactivated for saving space or for deactivating network
> functionality.
> Web server must support HTTP range requests for this and NBD support
> must be enabled in kernel.
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  rules/rauc.in   | 11 +++++++++++
>  rules/rauc.make |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/rules/rauc.in b/rules/rauc.in
> index aee162b83..832967b44 100644
> --- a/rules/rauc.in
> +++ b/rules/rauc.in
> @@ -13,6 +13,7 @@ menuconfig RAUC
>  	select BUSYBOX_FEATURE_SEAMLESS_GZ	if BUSYBOX_TAR
>  	select DBUS				if RAUC_SERVICE
>  	select LIBCURL				if RAUC_NETWORK
> +	select LIBNL3				if RAUC_STREAMING
>  	select JSON_GLIB			if RAUC_JSON
>  	select UTIL_LINUX_NG_LIBFDISK		if RAUC_GPT
>  	select SQUASHFS_TOOLS			if RUNTIME
> @@ -44,6 +45,16 @@ config RAUC_NETWORK
>  	  Note that network is primarily designed to be used for RAUC'S casync
>  	  capabilities, not for fetching full bundles.
>  
> +config RAUC_STREAMING
> +	bool
> +	prompt "Enable streaming support"
> +	default y

Why 'default y'? I think most users won't need this.

Michael

> +	select RAUC_NETWORK
> +	help
> +	  Enables built-in HTTP(S) streaming support that allows RAUC to
> +	  access remote bundles via http/https and write images without the
> +	  need for intermediate storage on the target.
> +
>  config RAUC_JSON
>  	bool
>  	prompt "JSON support"
> diff --git a/rules/rauc.make b/rules/rauc.make
> index 46d196bed..820583e59 100644
> --- a/rules/rauc.make
> +++ b/rules/rauc.make
> @@ -43,6 +43,7 @@ RAUC_CONF_OPT	:= \
>  	--disable-valgrind \
>  	--$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \
>  	--$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \
> +	--$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \
>  	--$(call ptx/endis,PTXCONF_RAUC_JSON)-json \
>  	--$(call ptx/endis,PTXCONF_RAUC_GPT)-gpt \
>  	--with-systemdunitdir=/usr/lib/systemd/system \
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |