Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC

["Enrico Jörns" <ejo@pengutronix.de>]

Hello Alex,

Am Donnerstag, dem 16.06.2022 um 08:16 +0200 schrieb Alexander Dahl:
> > > > 
> > > > diff --git a/rules/host-rauc.make b/rules/host-rauc.make
> > > > index c78a518f6..1851aee9a 100644
> > > > --- a/rules/host-rauc.make
> > > > +++ b/rules/host-rauc.make
> > > > @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT	:= \
> > > >  	$(HOST_AUTOCONF) \
> > > >  	--disable-code-coverage \
> > > >  	--disable-valgrind \
> > > > +	--enable-create \
> > > 
> > > From the cover letter I understood this is a new post 1.5 option,
> > > right?
> > 
> > almost, as the cover-letter explicitly notes this is a post 1.3 option. ;)
> > 
> > And this line is only for completeness. The added option in RAUC is semantically
> > --disable-create and --enable-create is the default.
> 
> make rules in ptxdist pin down _all_ configure options, so if that was
> missing for 1.5 package it was already forgotten to set when upgrading
> from 1.3 or 1.4.

yes, there have been no adaptions since the initial recipe submission.

Seems as if I've won an extra price for this round. \o/

> > > >  	--disable-service \
> > > >  	--disable-network \
> > > >  	--disable-json
> > > > diff --git a/rules/rauc.in b/rules/rauc.in
> > > > index 832967b44..e43692846 100644
> > > > --- a/rules/rauc.in
> > > > +++ b/rules/rauc.in
> > > > @@ -27,6 +27,16 @@ menuconfig RAUC
> > > >  
> > > >  if RAUC
> > > >  
> > > > +config RAUC_CREATE
> > > > +	bool
> > > > +	prompt "Enable bundle creation support on target"
> > > > +	default n
> > > > +	help
> > > > +	  Enables support for creating bundles on target.
> > > > +	  Disabling this will remove functionality required for bundle
> > > > +	  creation which is not required on the target in most cases and thus
> > > > +	  allows to save space.
> > > > +
> > > >  config RAUC_SERVICE
> > > >  	bool
> > > >  	prompt "Enable service (D-Bus) support"
> > > > diff --git a/rules/rauc.make b/rules/rauc.make
> > > > index 820583e59..e001956a5 100644
> > > > --- a/rules/rauc.make
> > > > +++ b/rules/rauc.make
> > > > @@ -41,6 +41,7 @@ RAUC_CONF_OPT	:= \
> > > >  	$(GLOBAL_LARGE_FILE_OPTION) \
> > > >  	--disable-code-coverage \
> > > >  	--disable-valgrind \
> > > > +	--$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \
> > > 
> > > Same here. This should have set explicitly to a sensible default with
> > > the package update. Making this optional would just change that line
> > > then instead of adding it.
> > 
> > See above. The ptxdist default for RAUC_CREATE ("n") leads to --disable-create
> > which changes the RAUC default (which is --enable-create).
> 
> I understand RAUC has some opinion what should be default. Some
> embedded build systems like buildroot stick with those defaults (for
> all options not explicitly set through menu). Others like ptxdist set
> all configure options. The script 'scripts/configure_helper.py' helps
> determining missing options not set. See example output for package
> host-rauc on a ptxdist 2021.06.0 based BSP:

Since I know some of them, I'd tend to say the group of 'Others' exclusively
consists of ptxdist to the best of my knowledge.
But yes, in theory I am aware of this design decision ;)

Thanks for the helper script, I'll give it a try.

> 	% ~/src/ptxdist/scripts/configure_helper.py -p host-rauc
> 	--- rules/host-rauc.make
> 	+++ rauc-1.5.1
> 	@@ -1,6 +1,17 @@
> 			--prefix=
> 	+       --enable-debug=yes/info/profile/no
> 	+       --disable-largefile
> 	+       --enable-compile-warnings=no/yes/error
> 	+       --disable-Werror
> 			--disable-code-coverage
> 			--disable-valgrind
> 			--disable-service
> 	+       --disable-create
> 			--disable-network
> 			--disable-json
> 	+       --enable-gpt
> 	+       --with-gcov=GCOV
> 	+       --with-systemdunitdir=DIR
> 	+       --with-dbuspolicydir=DIR
> 	+       --with-dbussystemservicedir=DIR
> 	+       --with-dbusinterfacesdir=DIR
> 
> You see --disable-create is not the only option not set in
> rules/host-rauc.make and I guess it might look similar for rauc.make?

It does, yes (with a little bit less diff lines).

> Pinning down the old options should go to a patch before bumping the
> version.

Give me a second..


Best regards

Enrico

> 
> Greets
> Alex
> 
> > 
> > Regards, Enrico
> > 
> > > Greets
> > > Alex
> > > 
> > > >  	--$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \
> > > >  	--$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \
> > > >  	--$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \
> > > > -- 
> > > > 2.30.2
> > > > 
> > > > 
> > > 
> > > 
> > 
> > -- 
> > Pengutronix e.K.                           | Enrico Jörns                |
> > Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
> > Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
> > 31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |
> 

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |