From: Michael Olbrich <m.olbrich@pengutronix.de>
To: "Enrico Jörns" <ejo@pengutronix.de>,
ptxdist@pengutronix.de, jlu@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support
Date: Fri, 17 Jun 2022 12:48:14 +0200 [thread overview]
Message-ID: <20220617104814.GR13709@pengutronix.de> (raw)
In-Reply-To: <20220617102750.GQ13709@pengutronix.de>
On Fri, Jun 17, 2022 at 12:27:50PM +0200, Michael Olbrich wrote:
> On Fri, Jun 17, 2022 at 11:47:19AM +0200, Enrico Jörns wrote:
> > Am Freitag, dem 17.06.2022 um 08:28 +0200 schrieb Michael Olbrich:
> > > On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote:
> > > > Enable it by default so that default installation can benefit from this.
> > > > Can be deactivated for saving space or for deactivating network
> > > > functionality.
> > > > Web server must support HTTP range requests for this and NBD support
> > > > must be enabled in kernel.
> > > >
> > > > Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> > > > ---
> > > > rules/rauc.in | 11 +++++++++++
> > > > rules/rauc.make | 1 +
> > > > 2 files changed, 12 insertions(+)
> > > >
> > > > diff --git a/rules/rauc.in b/rules/rauc.in
> > > > index aee162b83..832967b44 100644
> > > > --- a/rules/rauc.in
> > > > +++ b/rules/rauc.in
> > > > @@ -13,6 +13,7 @@ menuconfig RAUC
> > > > select BUSYBOX_FEATURE_SEAMLESS_GZ if BUSYBOX_TAR
> > > > select DBUS if RAUC_SERVICE
> > > > select LIBCURL if RAUC_NETWORK
> > > > + select LIBNL3 if RAUC_STREAMING
> > > > select JSON_GLIB if RAUC_JSON
> > > > select UTIL_LINUX_NG_LIBFDISK if RAUC_GPT
> > > > select SQUASHFS_TOOLS if RUNTIME
> > > > @@ -44,6 +45,16 @@ config RAUC_NETWORK
> > > > Note that network is primarily designed to be used for RAUC'S casync
> > > > capabilities, not for fetching full bundles.
> > > >
> > > > +config RAUC_STREAMING
> > > > + bool
> > > > + prompt "Enable streaming support"
> > > > + default y
> > >
> > > Why 'default y'? I think most users won't need this.
> >
> > I am not convinced that streaming is not required for most users. I guess that
> > being able to download bundles form HTTP directly is a use case that is more and
> > more common. With network and streaming enabled, one can download bundles only
> > externally or install from USB sticks etc.
> >
> > In Yocto we have this enabled by default, too. If it's ptxdist's philosophy to
> > ship as little features as possible by default (i.e. focus on small size), we
> > can also make this default n.
>
> The thing is, nobody changes the defaults unless they notice something is
> not working as expected. And enabling things in PTXdist is easy.
>
> How does this work anyways? If I call 'rauc install <some-url>', will this
> use streaming implicitly or does it require an explicit option?
>
> How about 'default RAUC_NETWORK'? This way those that use networking also
> get streaming by default.
Grr, kconfig does not allow that. So it'll be disabled by default.
Hmmm, or maybe just use the same option? What would the consequences be?
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-17 10:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:22 [ptxdist] [PATCH 0/5] RAUC: update to v1.7 and add some new options Enrico Jorns
2022-06-15 14:22 ` [ptxdist] [PATCH 1/5] RAUC: version bump 1.5.1 -> 1.7 Enrico Jorns
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support Enrico Jorns
2022-06-17 6:28 ` Michael Olbrich
2022-06-17 9:47 ` Enrico Jörns
2022-06-17 10:27 ` Michael Olbrich
2022-06-17 10:48 ` Michael Olbrich [this message]
2022-06-17 11:47 ` Enrico Jörns
2022-06-17 12:04 ` Michael Olbrich
2022-06-17 10:57 ` Alexander Dahl
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC Enrico Jorns
2022-06-15 15:48 ` Alexander Dahl
2022-06-15 21:03 ` Enrico Jörns
2022-06-16 6:16 ` Alexander Dahl
2022-06-16 13:53 ` Enrico Jörns
2022-06-20 6:19 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 4/5] image-rauc: add support for crypt bundles Enrico Jorns
2022-06-20 6:20 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-06-15 14:22 ` [ptxdist] [PATCH 5/5] image-rauc: default to 'verity' bundle format Enrico Jorns
2022-06-20 6:20 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617104814.GR13709@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ejo@pengutronix.de \
--cc=jlu@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox