Re: [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support

["Enrico Jörns" <ejo@pengutronix.de>]

Am Freitag, dem 17.06.2022 um 08:28 +0200 schrieb Michael Olbrich:
> On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote:
> > Enable it by default so that default installation can benefit from this.
> > Can be deactivated for saving space or for deactivating network
> > functionality.
> > Web server must support HTTP range requests for this and NBD support
> > must be enabled in kernel.
> > 
> > Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> > ---
> >  rules/rauc.in   | 11 +++++++++++
> >  rules/rauc.make |  1 +
> >  2 files changed, 12 insertions(+)
> > 
> > diff --git a/rules/rauc.in b/rules/rauc.in
> > index aee162b83..832967b44 100644
> > --- a/rules/rauc.in
> > +++ b/rules/rauc.in
> > @@ -13,6 +13,7 @@ menuconfig RAUC
> >  	select BUSYBOX_FEATURE_SEAMLESS_GZ	if BUSYBOX_TAR
> >  	select DBUS				if RAUC_SERVICE
> >  	select LIBCURL				if RAUC_NETWORK
> > +	select LIBNL3				if RAUC_STREAMING
> >  	select JSON_GLIB			if RAUC_JSON
> >  	select UTIL_LINUX_NG_LIBFDISK		if RAUC_GPT
> >  	select SQUASHFS_TOOLS			if RUNTIME
> > @@ -44,6 +45,16 @@ config RAUC_NETWORK
> >  	  Note that network is primarily designed to be used for RAUC'S casync
> >  	  capabilities, not for fetching full bundles.
> >  
> > +config RAUC_STREAMING
> > +	bool
> > +	prompt "Enable streaming support"
> > +	default y
> 
> Why 'default y'? I think most users won't need this.

I am not convinced that streaming is not required for most users. I guess that
being able to download bundles form HTTP directly is a use case that is more and
more common. With network and streaming enabled, one can download bundles only
externally or install from USB sticks etc.

In Yocto we have this enabled by default, too. If it's ptxdist's philosophy to
ship as little features as possible by default (i.e. focus on small size), we
can also make this default n.


Enrico

> Michael
> 
> > +	select RAUC_NETWORK
> > +	help
> > +	  Enables built-in HTTP(S) streaming support that allows RAUC to
> > +	  access remote bundles via http/https and write images without the
> > +	  need for intermediate storage on the target.
> > +
> >  config RAUC_JSON
> >  	bool
> >  	prompt "JSON support"
> > diff --git a/rules/rauc.make b/rules/rauc.make
> > index 46d196bed..820583e59 100644
> > --- a/rules/rauc.make
> > +++ b/rules/rauc.make
> > @@ -43,6 +43,7 @@ RAUC_CONF_OPT	:= \
> >  	--disable-valgrind \
> >  	--$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \
> >  	--$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \
> > +	--$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \
> >  	--$(call ptx/endis,PTXCONF_RAUC_JSON)-json \
> >  	--$(call ptx/endis,PTXCONF_RAUC_GPT)-gpt \
> >  	--with-systemdunitdir=/usr/lib/systemd/system \
> > -- 
> > 2.30.2
> > 
> > 
> > 
> 

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |