mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH 1/7] setup: remove dead code
@ 2020-06-13  1:32 Roland Hieber
  2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
                   ` (6 more replies)
  0 siblings, 7 replies; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

This lines were already commented out when they were first added…

Fixes: 6871dca3f4003d9ee2ac (2008-07-04, Marc Kleine-Budde: "	* Kconfig: 	added some developer options")
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 config/setup/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/config/setup/Kconfig b/config/setup/Kconfig
index b6ed724f5519..de288c95a2ce 100644
--- a/config/setup/Kconfig
+++ b/config/setup/Kconfig
@@ -231,12 +231,6 @@ endmenu
 
 menu "Developer Options "
 
-#config SETUP_CHECK_OMIT_CASE
-#	bool "don't check for case sensitive file system"
-
-#config SETUP_CHECK_OMIT_SPACES
-#	bool "don't check for spaces in important directories"
-
 config SETUP_DISABLE_LOCAL_CHECK
 	bool
 	prompt "disable local disk check"
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
  2020-06-13  1:32 ` [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent Roland Hieber
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

The http version redirects to https anyways, and this way we guard the
full URL against interested third parties even on the first request.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 config/setup/Kconfig           | 2 +-
 config/setup/ptxdistrc.default | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/setup/Kconfig b/config/setup/Kconfig
index de288c95a2ce..4b1a769daab5 100644
--- a/config/setup/Kconfig
+++ b/config/setup/Kconfig
@@ -110,7 +110,7 @@ endif
 
 config SETUP_PTXMIRROR
 	string
-	default "http://www.pengutronix.de/software/ptxdist/temporary-src"
+	default "https://www.pengutronix.de/software/ptxdist/temporary-src"
 	prompt "PTXdist Mirror"
 	help
 	  Enter the fallback mirror for all packages here.
diff --git a/config/setup/ptxdistrc.default b/config/setup/ptxdistrc.default
index 8f3a451b69f2..29b8bfe37525 100644
--- a/config/setup/ptxdistrc.default
+++ b/config/setup/ptxdistrc.default
@@ -31,7 +31,7 @@ PTXCONF_SETUP_SRCDIR="${PTXDIST_WORKSPACE}/src"
 #
 # PTXCONF_SETUP_NO_DOWNLOAD is not set
 # PTXCONF_SETUP_PTXMIRROR_ONLY is not set
-PTXCONF_SETUP_PTXMIRROR="http://www.pengutronix.de/software/ptxdist/temporary-src"
+PTXCONF_SETUP_PTXMIRROR="https://www.pengutronix.de/software/ptxdist/temporary-src"
 PTXCONF_SETUP_DEBMIRROR="http://ftp.uni-kl.de/debian http://archive.debian.org/debian"
 PTXCONF_SETUP_SFMIRROR="http://downloads.sourceforge.net/sourceforge"
 PTXCONF_SETUP_GNUMIRROR="https://ftp.gnu.org/gnu http://ftp.uni-kl.de/pub/gnu"
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
  2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19  5:34   ` Michael Olbrich
  2020-06-13  1:32 ` [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run Roland Hieber
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

There is no guarantee that URLs will still work the next time we want to
check them, so try to fetch the URL every time instead of caching the
result. This also makes iterations of editing the URL in the rule file
and testing if it works quicker.

Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
is unlikely that $(STATEDIR)/%.urlcheck is created by something other
than PTXdist, so removing the $(call touch) is a good approximation for
phony behaviour.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/post/ptxd_make_world_get.make | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
index a2026c994591..a79b4d170873 100644
--- a/rules/post/ptxd_make_world_get.make
+++ b/rules/post/ptxd_make_world_get.make
@@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck:
 	@$(call targetinfo)
 	@$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \
 		$(call world/urlcheck, $($(src)));)
-	@$(call touch)
 
 world/urlcheck = \
 	$(call world/env, $(1)) \
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
  2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
  2020-06-13  1:32 ` [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
  2020-06-13  1:32 ` [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file " Roland Hieber
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Some SourceForge URLs seem to fail randomly. Log the redirected URL to
facilitate debugging.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 scripts/lib/ptxd_make_get.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index 3ac0b71c2a83..d5003384619b 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -94,6 +94,7 @@ ptxd_make_get_http() {
 		--location \
 		--head \
 		--request GET \
+		--write-out '\n%{url_effective}\n' \
 		"${url}" &&
 		if grep -i "content-type:" "${temp_header}" | tail -n 1 | grep -q "text/html"; then
 		    ptxd_bailout "Got HTML file"
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file on dry run
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
                   ` (2 preceding siblings ...)
  2020-06-13  1:32 ` [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19  5:39   ` Michael Olbrich
  2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Still log this as a warning so it is (hopefully) seen.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 scripts/lib/ptxd_make_get.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index d5003384619b..f9aa3c7a0ec9 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -97,7 +97,9 @@ ptxd_make_get_http() {
 		--write-out '\n%{url_effective}\n' \
 		"${url}" &&
 		if grep -i "content-type:" "${temp_header}" | tail -n 1 | grep -q "text/html"; then
-		    ptxd_bailout "Got HTML file"
+		    ptxd_warning "Got HTML file"
+		    ptxd_make_serialize_put
+		    return 1
 		fi
 		ptxd_make_serialize_put
 		return
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 6/7] libjaylink: fix URL
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
                   ` (3 preceding siblings ...)
  2020-06-13  1:32 ` [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file " Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19  5:44   ` Michael Olbrich
  2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
  2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
  2020-06-19 22:03 ` [ptxdist] [APPLIED] setup: remove dead code Michael Olbrich
  6 siblings, 2 replies; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

The repository was apparently moved; the old URL shows a login screen.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/libjaylink.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/libjaylink.make b/rules/libjaylink.make
index 0ecba6e3ec50..5b125ca0de1e 100644
--- a/rules/libjaylink.make
+++ b/rules/libjaylink.make
@@ -12,7 +12,7 @@ LIBJAYLINK_VERSION	:= 0.1.0-15-g8645845
 LIBJAYLINK_MD5		:= 6e71d5c39ae4778bb8d0df79d2524c07
 LIBJAYLINK		:= libjaylink-$(LIBJAYLINK_VERSION)
 LIBJAYLINK_SUFFIX	:= tar.bz2
-LIBJAYLINK_URL		:= https://gitlab.zapb.de/zapb/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
+LIBJAYLINK_URL		:= https://gitlab.zapb.de/libjaylink/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
 LIBJAYLINK_SOURCE	:= $(SRCDIR)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
 LIBJAYLINK_DIR		:= $(BUILDDIR)/$(LIBJAYLINK)
 LIBJAYLINK_LICENSE	:= GPL-2.0+
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
                   ` (4 preceding siblings ...)
  2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
@ 2020-06-13  1:32 ` Roland Hieber
  2020-06-19  5:46   ` Michael Olbrich
  2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
  2020-06-19 22:03 ` [ptxdist] [APPLIED] setup: remove dead code Michael Olbrich
  6 siblings, 2 replies; 23+ messages in thread
From: Roland Hieber @ 2020-06-13  1:32 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

rpm5.org has been a parking domain for at least 2 years, it is unlikely
to come back. Add a few other mirrors.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/libpopt.make | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/rules/libpopt.make b/rules/libpopt.make
index 0bfecc7aebcf..7de94b406c82 100644
--- a/rules/libpopt.make
+++ b/rules/libpopt.make
@@ -19,8 +19,10 @@ LIBPOPT_VERSION	:= 1.16
 LIBPOPT_MD5	:= 3743beefa3dd6247a73f8f7a32c14c33
 LIBPOPT		:= popt-$(LIBPOPT_VERSION)
 LIBPOPT_SUFFIX	:= tar.gz
-LIBPOPT_URL	:= http://rpm5.org/files/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
-		   http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX)
+LIBPOPT_URL	:= \
+	http://deb.debian.org/debian/pool/main/p/popt/popt_$(LIBPOPT).orig.$(LIBPOPT_SUFFIX) \
+	http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
+	ftp://anduin.linuxfromscratch.org/BLFS/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX)
 LIBPOPT_SOURCE	:= $(SRCDIR)/$(LIBPOPT).$(LIBPOPT_SUFFIX)
 LIBPOPT_DIR	:= $(BUILDDIR)/$(LIBPOPT)
 LIBPOPT_LICENSE	:= MIT
-- 
2.27.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
  2020-06-13  1:32 ` [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent Roland Hieber
@ 2020-06-19  5:34   ` Michael Olbrich
  2020-06-19  8:22     ` Roland Hieber
  0 siblings, 1 reply; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19  5:34 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote:
> There is no guarantee that URLs will still work the next time we want to
> check them, so try to fetch the URL every time instead of caching the
> result. This also makes iterations of editing the URL in the rule file
> and testing if it works quicker.
> 
> Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
> is unlikely that $(STATEDIR)/%.urlcheck is created by something other
> than PTXdist, so removing the $(call touch) is a good approximation for
> phony behaviour.

No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix
errors and then continue with the rest.

How about an extra ptxdist options. When it is given, then all make target
that are explicitly specified on the command-line are added to the PHONY
list, so that they are always executed. Then you could do:

ptxdist --something urlcheck foobar

And you can do this multiple times. I don't have a good name for the
option. But I think this could be useful for other things as well.

Michael


> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/post/ptxd_make_world_get.make | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
> index a2026c994591..a79b4d170873 100644
> --- a/rules/post/ptxd_make_world_get.make
> +++ b/rules/post/ptxd_make_world_get.make
> @@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck:
>  	@$(call targetinfo)
>  	@$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \
>  		$(call world/urlcheck, $($(src)));)
> -	@$(call touch)
>  
>  world/urlcheck = \
>  	$(call world/env, $(1)) \
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file on dry run
  2020-06-13  1:32 ` [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file " Roland Hieber
@ 2020-06-19  5:39   ` Michael Olbrich
  0 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19  5:39 UTC (permalink / raw)
  To: ptxdist

On Sat, Jun 13, 2020 at 03:32:47AM +0200, Roland Hieber wrote:
> Still log this as a warning so it is (hopefully) seen.

Actually, I'd like to keep this. We have two reasons for multiple URLs:
1. The primary URL is flaky
2. Upstream moves older versions to a different directory.

In those cases we get a 404 or connection failures. A HTML file usually
means, that the website changed and that is something I want to fix.

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  scripts/lib/ptxd_make_get.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index d5003384619b..f9aa3c7a0ec9 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -97,7 +97,9 @@ ptxd_make_get_http() {
>  		--write-out '\n%{url_effective}\n' \
>  		"${url}" &&
>  		if grep -i "content-type:" "${temp_header}" | tail -n 1 | grep -q "text/html"; then
> -		    ptxd_bailout "Got HTML file"
> +		    ptxd_warning "Got HTML file"
> +		    ptxd_make_serialize_put
> +		    return 1
>  		fi
>  		ptxd_make_serialize_put
>  		return
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 6/7] libjaylink: fix URL
  2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
@ 2020-06-19  5:44   ` Michael Olbrich
  2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
  1 sibling, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19  5:44 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

On Sat, Jun 13, 2020 at 03:32:48AM +0200, Roland Hieber wrote:
> The repository was apparently moved; the old URL shows a login screen.

I had that already queue, but your commit message is nicer, so I'll take
it :-)

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/libjaylink.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/libjaylink.make b/rules/libjaylink.make
> index 0ecba6e3ec50..5b125ca0de1e 100644
> --- a/rules/libjaylink.make
> +++ b/rules/libjaylink.make
> @@ -12,7 +12,7 @@ LIBJAYLINK_VERSION	:= 0.1.0-15-g8645845
>  LIBJAYLINK_MD5		:= 6e71d5c39ae4778bb8d0df79d2524c07
>  LIBJAYLINK		:= libjaylink-$(LIBJAYLINK_VERSION)
>  LIBJAYLINK_SUFFIX	:= tar.bz2
> -LIBJAYLINK_URL		:= https://gitlab.zapb.de/zapb/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
> +LIBJAYLINK_URL		:= https://gitlab.zapb.de/libjaylink/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
>  LIBJAYLINK_SOURCE	:= $(SRCDIR)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
>  LIBJAYLINK_DIR		:= $(BUILDDIR)/$(LIBJAYLINK)
>  LIBJAYLINK_LICENSE	:= GPL-2.0+
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
@ 2020-06-19  5:46   ` Michael Olbrich
  2020-06-19  8:24     ` Roland Hieber
  2020-06-28 22:07     ` Roland Hieber
  2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
  1 sibling, 2 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19  5:46 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

On Sat, Jun 13, 2020 at 03:32:49AM +0200, Roland Hieber wrote:
> rpm5.org has been a parking domain for at least 2 years, it is unlikely
> to come back. Add a few other mirrors.

The file can be found on http://ftp.rpm.org so I changed the URL to that
one.
Note: please don't use Debian pool URLs. Those files are gone, when the
corresponding version is removed from any active Debian release.

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/libpopt.make | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/libpopt.make b/rules/libpopt.make
> index 0bfecc7aebcf..7de94b406c82 100644
> --- a/rules/libpopt.make
> +++ b/rules/libpopt.make
> @@ -19,8 +19,10 @@ LIBPOPT_VERSION	:= 1.16
>  LIBPOPT_MD5	:= 3743beefa3dd6247a73f8f7a32c14c33
>  LIBPOPT		:= popt-$(LIBPOPT_VERSION)
>  LIBPOPT_SUFFIX	:= tar.gz
> -LIBPOPT_URL	:= http://rpm5.org/files/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> -		   http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> +LIBPOPT_URL	:= \
> +	http://deb.debian.org/debian/pool/main/p/popt/popt_$(LIBPOPT).orig.$(LIBPOPT_SUFFIX) \
> +	http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> +	ftp://anduin.linuxfromscratch.org/BLFS/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX)
>  LIBPOPT_SOURCE	:= $(SRCDIR)/$(LIBPOPT).$(LIBPOPT_SUFFIX)
>  LIBPOPT_DIR	:= $(BUILDDIR)/$(LIBPOPT)
>  LIBPOPT_LICENSE	:= MIT
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
  2020-06-19  5:34   ` Michael Olbrich
@ 2020-06-19  8:22     ` Roland Hieber
  2020-06-19 11:07       ` Michael Olbrich
  0 siblings, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-19  8:22 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 07:34:01AM +0200, Michael Olbrich wrote:
> On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote:
> > There is no guarantee that URLs will still work the next time we want to
> > check them, so try to fetch the URL every time instead of caching the
> > result. This also makes iterations of editing the URL in the rule file
> > and testing if it works quicker.
> > 
> > Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
> > is unlikely that $(STATEDIR)/%.urlcheck is created by something other
> > than PTXdist, so removing the $(call touch) is a good approximation for
> > phony behaviour.
> 
> No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix
> errors and then continue with the rest.

Can you not use -k to do this?

Caching an error state is at least unusual, and it is not done anywhere
else in PTXdist, so this breaks the principle of least surprise.

 - Roland

> How about an extra ptxdist options. When it is given, then all make target
> that are explicitly specified on the command-line are added to the PHONY
> list, so that they are always executed. Then you could do:
> 
> ptxdist --something urlcheck foobar
> 
> And you can do this multiple times. I don't have a good name for the
> option. But I think this could be useful for other things as well.
> 
> Michael
> 
> 
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> >  rules/post/ptxd_make_world_get.make | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
> > index a2026c994591..a79b4d170873 100644
> > --- a/rules/post/ptxd_make_world_get.make
> > +++ b/rules/post/ptxd_make_world_get.make
> > @@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck:
> >  	@$(call targetinfo)
> >  	@$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \
> >  		$(call world/urlcheck, $($(src)));)
> > -	@$(call touch)
> >  
> >  world/urlcheck = \
> >  	$(call world/env, $(1)) \
> > -- 
> > 2.27.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-19  5:46   ` Michael Olbrich
@ 2020-06-19  8:24     ` Roland Hieber
  2020-06-19 11:07       ` Michael Olbrich
  2020-06-28 22:07     ` Roland Hieber
  1 sibling, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-19  8:24 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 07:46:52AM +0200, Michael Olbrich wrote:
> On Sat, Jun 13, 2020 at 03:32:49AM +0200, Roland Hieber wrote:
> > rpm5.org has been a parking domain for at least 2 years, it is unlikely
> > to come back. Add a few other mirrors.
> 
> The file can be found on http://ftp.rpm.org so I changed the URL to that
> one.
> Note: please don't use Debian pool URLs. Those files are gone, when the
> corresponding version is removed from any active Debian release.

Oh, you're right, I should have used snapshots.debian.org instead!
Still interested in a v2 incorporating your URL?

 - Roland

> 
> Michael
> 
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> >  rules/libpopt.make | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/rules/libpopt.make b/rules/libpopt.make
> > index 0bfecc7aebcf..7de94b406c82 100644
> > --- a/rules/libpopt.make
> > +++ b/rules/libpopt.make
> > @@ -19,8 +19,10 @@ LIBPOPT_VERSION	:= 1.16
> >  LIBPOPT_MD5	:= 3743beefa3dd6247a73f8f7a32c14c33
> >  LIBPOPT		:= popt-$(LIBPOPT_VERSION)
> >  LIBPOPT_SUFFIX	:= tar.gz
> > -LIBPOPT_URL	:= http://rpm5.org/files/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> > -		   http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> > +LIBPOPT_URL	:= \
> > +	http://deb.debian.org/debian/pool/main/p/popt/popt_$(LIBPOPT).orig.$(LIBPOPT_SUFFIX) \
> > +	http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> > +	ftp://anduin.linuxfromscratch.org/BLFS/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> >  LIBPOPT_SOURCE	:= $(SRCDIR)/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> >  LIBPOPT_DIR	:= $(BUILDDIR)/$(LIBPOPT)
> >  LIBPOPT_LICENSE	:= MIT
> > -- 
> > 2.27.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
  2020-06-19  8:22     ` Roland Hieber
@ 2020-06-19 11:07       ` Michael Olbrich
  2020-06-22 10:19         ` Roland Hieber
  0 siblings, 1 reply; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 11:07 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 10:22:55AM +0200, Roland Hieber wrote:
> On Fri, Jun 19, 2020 at 07:34:01AM +0200, Michael Olbrich wrote:
> > On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote:
> > > There is no guarantee that URLs will still work the next time we want to
> > > check them, so try to fetch the URL every time instead of caching the
> > > result. This also makes iterations of editing the URL in the rule file
> > > and testing if it works quicker.
> > > 
> > > Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
> > > is unlikely that $(STATEDIR)/%.urlcheck is created by something other
> > > than PTXdist, so removing the $(call touch) is a good approximation for
> > > phony behaviour.
> > 
> > No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix
> > errors and then continue with the rest.
> 
> Can you not use -k to do this?

I do that. But without the successful cache, I need to track all failures
manually because I cannot call 'urlcheck' again. To check the rest.

> Caching an error state is at least unusual, and it is not done anywhere
> else in PTXdist, so this breaks the principle of least surprise.

On the contrary. In general, if something was successful, then we don't do
it again unless there is a clear indication that the input has changed.
In all other cases an explicit 'drop' or 'clean' is needed.

For example, we don't skip the 'touch' for local_src/ links either. Even
though the code can change any time.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-19  8:24     ` Roland Hieber
@ 2020-06-19 11:07       ` Michael Olbrich
  0 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 11:07 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 10:24:33AM +0200, Roland Hieber wrote:
> On Fri, Jun 19, 2020 at 07:46:52AM +0200, Michael Olbrich wrote:
> > On Sat, Jun 13, 2020 at 03:32:49AM +0200, Roland Hieber wrote:
> > > rpm5.org has been a parking domain for at least 2 years, it is unlikely
> > > to come back. Add a few other mirrors.
> > 
> > The file can be found on http://ftp.rpm.org so I changed the URL to that
> > one.
> > Note: please don't use Debian pool URLs. Those files are gone, when the
> > corresponding version is removed from any active Debian release.
> 
> Oh, you're right, I should have used snapshots.debian.org instead!
> Still interested in a v2 incorporating your URL?

I'll do a fixup myself.

Michael

>  - Roland
> 
> > 
> > Michael
> > 
> > > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > > ---
> > >  rules/libpopt.make | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/rules/libpopt.make b/rules/libpopt.make
> > > index 0bfecc7aebcf..7de94b406c82 100644
> > > --- a/rules/libpopt.make
> > > +++ b/rules/libpopt.make
> > > @@ -19,8 +19,10 @@ LIBPOPT_VERSION	:= 1.16
> > >  LIBPOPT_MD5	:= 3743beefa3dd6247a73f8f7a32c14c33
> > >  LIBPOPT		:= popt-$(LIBPOPT_VERSION)
> > >  LIBPOPT_SUFFIX	:= tar.gz
> > > -LIBPOPT_URL	:= http://rpm5.org/files/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> > > -		   http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> > > +LIBPOPT_URL	:= \
> > > +	http://deb.debian.org/debian/pool/main/p/popt/popt_$(LIBPOPT).orig.$(LIBPOPT_SUFFIX) \
> > > +	http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> > > +	ftp://anduin.linuxfromscratch.org/BLFS/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> > >  LIBPOPT_SOURCE	:= $(SRCDIR)/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> > >  LIBPOPT_DIR	:= $(BUILDDIR)/$(LIBPOPT)
> > >  LIBPOPT_LICENSE	:= MIT
> > > -- 
> > > 2.27.0
> > > 
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > > 
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> > 
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [APPLIED] setup: remove dead code
  2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
                   ` (5 preceding siblings ...)
  2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
@ 2020-06-19 22:03 ` Michael Olbrich
  6 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 22:03 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as bcb51e7920f89d8ccb520e8560ce3bb62af29158.

Michael

[sent from post-receive hook]

On Sat, 20 Jun 2020 00:03:58 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> This lines were already commented out when they were first added…
> 
> Fixes: 6871dca3f4003d9ee2ac (2008-07-04, Marc Kleine-Budde: "	* Kconfig: 	added some developer options")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200613013249.4288-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/config/setup/Kconfig b/config/setup/Kconfig
> index b6ed724f5519..de288c95a2ce 100644
> --- a/config/setup/Kconfig
> +++ b/config/setup/Kconfig
> @@ -231,12 +231,6 @@ endmenu
>  
>  menu "Developer Options "
>  
> -#config SETUP_CHECK_OMIT_CASE
> -#	bool "don't check for case sensitive file system"
> -
> -#config SETUP_CHECK_OMIT_SPACES
> -#	bool "don't check for spaces in important directories"
> -
>  config SETUP_DISABLE_LOCAL_CHECK
>  	bool
>  	prompt "disable local disk check"

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [APPLIED] ptxd_make_get: print out final redirected URL on dry run
  2020-06-13  1:32 ` [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run Roland Hieber
@ 2020-06-19 22:03   ` Michael Olbrich
  0 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 22:03 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as b1a3f9f5adb2fdb2089298a7221354b4af7af3db.

Michael

[sent from post-receive hook]

On Sat, 20 Jun 2020 00:03:59 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Some SourceForge URLs seem to fail randomly. Log the redirected URL to
> facilitate debugging.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200613013249.4288-4-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 3ac0b71c2a83..d5003384619b 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -94,6 +94,7 @@ ptxd_make_get_http() {
>  		--location \
>  		--head \
>  		--request GET \
> +		--write-out '\n%{url_effective}\n' \
>  		"${url}" &&
>  		if grep -i "content-type:" "${temp_header}" | tail -n 1 | grep -q "text/html"; then
>  		    ptxd_bailout "Got HTML file"

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [APPLIED] setup: use https by default for PTXCONF_SETUP_PTXMIRROR
  2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
@ 2020-06-19 22:03   ` Michael Olbrich
  0 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 22:03 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 8ef1cb23df72e92ce5c1e2b13bb287ca6beba82b.

Michael

[sent from post-receive hook]

On Sat, 20 Jun 2020 00:03:59 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The http version redirects to https anyways, and this way we guard the
> full URL against interested third parties even on the first request.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200613013249.4288-2-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/config/setup/Kconfig b/config/setup/Kconfig
> index de288c95a2ce..4b1a769daab5 100644
> --- a/config/setup/Kconfig
> +++ b/config/setup/Kconfig
> @@ -110,7 +110,7 @@ endif
>  
>  config SETUP_PTXMIRROR
>  	string
> -	default "http://www.pengutronix.de/software/ptxdist/temporary-src"
> +	default "https://www.pengutronix.de/software/ptxdist/temporary-src"
>  	prompt "PTXdist Mirror"
>  	help
>  	  Enter the fallback mirror for all packages here.
> diff --git a/config/setup/ptxdistrc.default b/config/setup/ptxdistrc.default
> index 8f3a451b69f2..29b8bfe37525 100644
> --- a/config/setup/ptxdistrc.default
> +++ b/config/setup/ptxdistrc.default
> @@ -31,7 +31,7 @@ PTXCONF_SETUP_SRCDIR="${PTXDIST_WORKSPACE}/src"
>  #
>  # PTXCONF_SETUP_NO_DOWNLOAD is not set
>  # PTXCONF_SETUP_PTXMIRROR_ONLY is not set
> -PTXCONF_SETUP_PTXMIRROR="http://www.pengutronix.de/software/ptxdist/temporary-src"
> +PTXCONF_SETUP_PTXMIRROR="https://www.pengutronix.de/software/ptxdist/temporary-src"
>  PTXCONF_SETUP_DEBMIRROR="http://ftp.uni-kl.de/debian http://archive.debian.org/debian"
>  PTXCONF_SETUP_SFMIRROR="http://downloads.sourceforge.net/sourceforge"
>  PTXCONF_SETUP_GNUMIRROR="https://ftp.gnu.org/gnu http://ftp.uni-kl.de/pub/gnu"

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [APPLIED] libpopt: replace dead URL with more mirrors
  2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
  2020-06-19  5:46   ` Michael Olbrich
@ 2020-06-19 22:04   ` Michael Olbrich
  1 sibling, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 22:04 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 7f2d71d72e234ecfce39ce38931c02b25319410d.

Michael

[sent from post-receive hook]

On Sat, 20 Jun 2020 00:04:00 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> rpm5.org has been a parking domain for at least 2 years, it is unlikely
> to come back. Add a few other mirrors.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200613013249.4288-7-rhi@pengutronix.de>
> [mol: use ftp.rpm.org as primary URL]
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libpopt.make b/rules/libpopt.make
> index 0bfecc7aebcf..2721cc53129c 100644
> --- a/rules/libpopt.make
> +++ b/rules/libpopt.make
> @@ -19,8 +19,10 @@ LIBPOPT_VERSION	:= 1.16
>  LIBPOPT_MD5	:= 3743beefa3dd6247a73f8f7a32c14c33
>  LIBPOPT		:= popt-$(LIBPOPT_VERSION)
>  LIBPOPT_SUFFIX	:= tar.gz
> -LIBPOPT_URL	:= http://rpm5.org/files/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> -		   http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX)
> +LIBPOPT_URL	:= \
> +	http://ftp.rpm.org/mirror/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> +	http://distfiles.gentoo.org/distfiles/$(LIBPOPT).$(LIBPOPT_SUFFIX) \
> +	ftp://anduin.linuxfromscratch.org/BLFS/popt/$(LIBPOPT).$(LIBPOPT_SUFFIX)
>  LIBPOPT_SOURCE	:= $(SRCDIR)/$(LIBPOPT).$(LIBPOPT_SUFFIX)
>  LIBPOPT_DIR	:= $(BUILDDIR)/$(LIBPOPT)
>  LIBPOPT_LICENSE	:= MIT

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [APPLIED] libjaylink: fix URL
  2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
  2020-06-19  5:44   ` Michael Olbrich
@ 2020-06-19 22:04   ` Michael Olbrich
  1 sibling, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-19 22:04 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 84aa6a720f959da9541e2fa314e132c2baf04e9f.

Michael

[sent from post-receive hook]

On Sat, 20 Jun 2020 00:04:00 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> The repository was apparently moved; the old URL shows a login screen.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20200613013249.4288-6-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libjaylink.make b/rules/libjaylink.make
> index 0ecba6e3ec50..5b125ca0de1e 100644
> --- a/rules/libjaylink.make
> +++ b/rules/libjaylink.make
> @@ -12,7 +12,7 @@ LIBJAYLINK_VERSION	:= 0.1.0-15-g8645845
>  LIBJAYLINK_MD5		:= 6e71d5c39ae4778bb8d0df79d2524c07
>  LIBJAYLINK		:= libjaylink-$(LIBJAYLINK_VERSION)
>  LIBJAYLINK_SUFFIX	:= tar.bz2
> -LIBJAYLINK_URL		:= https://gitlab.zapb.de/zapb/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
> +LIBJAYLINK_URL		:= https://gitlab.zapb.de/libjaylink/libjaylink/-/archive/$(LIBJAYLINK_VERSION)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
>  LIBJAYLINK_SOURCE	:= $(SRCDIR)/$(LIBJAYLINK).$(LIBJAYLINK_SUFFIX)
>  LIBJAYLINK_DIR		:= $(BUILDDIR)/$(LIBJAYLINK)
>  LIBJAYLINK_LICENSE	:= GPL-2.0+

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent
  2020-06-19 11:07       ` Michael Olbrich
@ 2020-06-22 10:19         ` Roland Hieber
  0 siblings, 0 replies; 23+ messages in thread
From: Roland Hieber @ 2020-06-22 10:19 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 01:07:22PM +0200, Michael Olbrich wrote:
> On Fri, Jun 19, 2020 at 10:22:55AM +0200, Roland Hieber wrote:
> > On Fri, Jun 19, 2020 at 07:34:01AM +0200, Michael Olbrich wrote:
> > > On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote:
> > > > There is no guarantee that URLs will still work the next time we want to
> > > > check them, so try to fetch the URL every time instead of caching the
> > > > result. This also makes iterations of editing the URL in the rule file
> > > > and testing if it works quicker.
> > > > 
> > > > Unfortunately, GNU make skips implicit rules for .PHONY targets, but it
> > > > is unlikely that $(STATEDIR)/%.urlcheck is created by something other
> > > > than PTXdist, so removing the $(call touch) is a good approximation for
> > > > phony behaviour.
> > > 
> > > No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix
> > > errors and then continue with the rest.
> > 
> > Can you not use -k to do this?
> 
> I do that. But without the successful cache, I need to track all failures
> manually because I cannot call 'urlcheck' again. To check the rest.

Ah, I now understand what you mean. Of course, successfully checked URLs
should be cached, but my change breaks that. My intention with this
patch was that the failed urlchecks are not cached if they are
unsuccessful. But somehow I can no longer reproduce that problem, an
unsuccessful urlcheck now fails without creating the state file... so
I guess everything should be fine without this patch.

> > Caching an error state is at least unusual, and it is not done anywhere
> > else in PTXdist, so this breaks the principle of least surprise.
> 
> On the contrary. In general, if something was successful, then we don't do
> it again unless there is a clear indication that the input has changed.
> In all other cases an explicit 'drop' or 'clean' is needed.
> 
> For example, we don't skip the 'touch' for local_src/ links either. Even
> though the code can change any time.

I meant, if a package fails to compile or install, we don't cache that
state, so the next ptxdist go will try to build it again. Of course, not
all error states result in a compilation failure, but we can do the best
and fail for those that do.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-19  5:46   ` Michael Olbrich
  2020-06-19  8:24     ` Roland Hieber
@ 2020-06-28 22:07     ` Roland Hieber
  2020-06-29  6:20       ` Michael Olbrich
  1 sibling, 1 reply; 23+ messages in thread
From: Roland Hieber @ 2020-06-28 22:07 UTC (permalink / raw)
  To: ptxdist

On Fri, Jun 19, 2020 at 07:46:52AM +0200, Michael Olbrich wrote:
> On Sat, Jun 13, 2020 at 03:32:49AM +0200, Roland Hieber wrote:
> > rpm5.org has been a parking domain for at least 2 years, it is unlikely
> > to come back. Add a few other mirrors.
> 
> The file can be found on http://ftp.rpm.org so I changed the URL to that
> one.
> Note: please don't use Debian pool URLs. Those files are gone, when the
> corresponding version is removed from any active Debian release.

This would also apply to every URL using the DEB mirror, wouldn't it? 
We have several rules in PTXdist that use this:

  ETHERWAKE_TARBALL       := etherwake_$(ETHERWAKE_VERSION).orig.$(ETHERWAKE_SUFFIX)
  ETHERWAKE_URL           := $(call ptx/mirror, DEB, pool/main/e/etherwake/$(ETHERWAKE_TARBALL))

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors
  2020-06-28 22:07     ` Roland Hieber
@ 2020-06-29  6:20       ` Michael Olbrich
  0 siblings, 0 replies; 23+ messages in thread
From: Michael Olbrich @ 2020-06-29  6:20 UTC (permalink / raw)
  To: ptxdist

On Mon, Jun 29, 2020 at 12:07:43AM +0200, Roland Hieber wrote:
> On Fri, Jun 19, 2020 at 07:46:52AM +0200, Michael Olbrich wrote:
> > On Sat, Jun 13, 2020 at 03:32:49AM +0200, Roland Hieber wrote:
> > > rpm5.org has been a parking domain for at least 2 years, it is unlikely
> > > to come back. Add a few other mirrors.
> > 
> > The file can be found on http://ftp.rpm.org so I changed the URL to that
> > one.
> > Note: please don't use Debian pool URLs. Those files are gone, when the
> > corresponding version is removed from any active Debian release.
> 
> This would also apply to every URL using the DEB mirror, wouldn't it? 
> We have several rules in PTXdist that use this:
> 
>   ETHERWAKE_TARBALL       := etherwake_$(ETHERWAKE_VERSION).orig.$(ETHERWAKE_SUFFIX)
>   ETHERWAKE_URL           := $(call ptx/mirror, DEB, pool/main/e/etherwake/$(ETHERWAKE_TARBALL))

True. For etherwake, it's not that critical. The version is unchanged since
(at least) jessie, so this archive will remain in to pool for some more
years.
But we should probably change this to avoid the bad example.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2020-06-29  6:20 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-13  1:32 [ptxdist] [PATCH 1/7] setup: remove dead code Roland Hieber
2020-06-13  1:32 ` [ptxdist] [PATCH 2/7] setup: use https by default for PTXCONF_SETUP_PTXMIRROR Roland Hieber
2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent Roland Hieber
2020-06-19  5:34   ` Michael Olbrich
2020-06-19  8:22     ` Roland Hieber
2020-06-19 11:07       ` Michael Olbrich
2020-06-22 10:19         ` Roland Hieber
2020-06-13  1:32 ` [ptxdist] [PATCH 4/7] ptxd_make_get: print out final redirected URL on dry run Roland Hieber
2020-06-19 22:03   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file " Roland Hieber
2020-06-19  5:39   ` Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 6/7] libjaylink: fix URL Roland Hieber
2020-06-19  5:44   ` Michael Olbrich
2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-13  1:32 ` [ptxdist] [PATCH 7/7] libpopt: replace dead URL with more mirrors Roland Hieber
2020-06-19  5:46   ` Michael Olbrich
2020-06-19  8:24     ` Roland Hieber
2020-06-19 11:07       ` Michael Olbrich
2020-06-28 22:07     ` Roland Hieber
2020-06-29  6:20       ` Michael Olbrich
2020-06-19 22:04   ` [ptxdist] [APPLIED] " Michael Olbrich
2020-06-19 22:03 ` [ptxdist] [APPLIED] setup: remove dead code Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox