From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: Roland Hieber Date: Sat, 13 Jun 2020 03:32:45 +0200 Message-Id: <20200613013249.4288-3-rhi@pengutronix.de> In-Reply-To: <20200613013249.4288-1-rhi@pengutronix.de> References: <20200613013249.4288-1-rhi@pengutronix.de> MIME-Version: 1.0 Subject: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Roland Hieber There is no guarantee that URLs will still work the next time we want to check them, so try to fetch the URL every time instead of caching the result. This also makes iterations of editing the URL in the rule file and testing if it works quicker. Unfortunately, GNU make skips implicit rules for .PHONY targets, but it is unlikely that $(STATEDIR)/%.urlcheck is created by something other than PTXdist, so removing the $(call touch) is a good approximation for phony behaviour. Signed-off-by: Roland Hieber --- rules/post/ptxd_make_world_get.make | 1 - 1 file changed, 1 deletion(-) diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make index a2026c994591..a79b4d170873 100644 --- a/rules/post/ptxd_make_world_get.make +++ b/rules/post/ptxd_make_world_get.make @@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck: @$(call targetinfo) @$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \ $(call world/urlcheck, $($(src)));) - @$(call touch) world/urlcheck = \ $(call world/env, $(1)) \ -- 2.27.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de