From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jm9kG-0005vO-9C for ptxdist@pengutronix.de; Fri, 19 Jun 2020 07:39:20 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jm9kF-0005NC-VJ for ptxdist@pengutronix.de; Fri, 19 Jun 2020 07:39:19 +0200 Date: Fri, 19 Jun 2020 07:39:19 +0200 From: Michael Olbrich Message-ID: <20200619053919.GB9312@pengutronix.de> References: <20200613013249.4288-1-rhi@pengutronix.de> <20200613013249.4288-5-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200613013249.4288-5-rhi@pengutronix.de> Subject: Re: [ptxdist] [PATCH 5/7] ptxd_make_get: continue with next URL when getting HTML file on dry run List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Sat, Jun 13, 2020 at 03:32:47AM +0200, Roland Hieber wrote: > Still log this as a warning so it is (hopefully) seen. Actually, I'd like to keep this. We have two reasons for multiple URLs: 1. The primary URL is flaky 2. Upstream moves older versions to a different directory. In those cases we get a 404 or connection failures. A HTML file usually means, that the website changed and that is something I want to fix. Michael > Signed-off-by: Roland Hieber > --- > scripts/lib/ptxd_make_get.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh > index d5003384619b..f9aa3c7a0ec9 100644 > --- a/scripts/lib/ptxd_make_get.sh > +++ b/scripts/lib/ptxd_make_get.sh > @@ -97,7 +97,9 @@ ptxd_make_get_http() { > --write-out '\n%{url_effective}\n' \ > "${url}" && > if grep -i "content-type:" "${temp_header}" | tail -n 1 | grep -q "text/html"; then > - ptxd_bailout "Got HTML file" > + ptxd_warning "Got HTML file" > + ptxd_make_serialize_put > + return 1 > fi > ptxd_make_serialize_put > return > -- > 2.27.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de