From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmErj-0001eW-5S for ptxdist@pengutronix.de; Fri, 19 Jun 2020 13:07:23 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jmEri-0002Gj-SZ for ptxdist@pengutronix.de; Fri, 19 Jun 2020 13:07:22 +0200 Date: Fri, 19 Jun 2020 13:07:22 +0200 From: Michael Olbrich Message-ID: <20200619110722.GM9312@pengutronix.de> References: <20200613013249.4288-1-rhi@pengutronix.de> <20200613013249.4288-3-rhi@pengutronix.de> <20200619053401.GA9312@pengutronix.de> <20200619082255.jnafcoextmvx6oel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200619082255.jnafcoextmvx6oel@pengutronix.de> Subject: Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jun 19, 2020 at 10:22:55AM +0200, Roland Hieber wrote: > On Fri, Jun 19, 2020 at 07:34:01AM +0200, Michael Olbrich wrote: > > On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote: > > > There is no guarantee that URLs will still work the next time we want to > > > check them, so try to fetch the URL every time instead of caching the > > > result. This also makes iterations of editing the URL in the rule file > > > and testing if it works quicker. > > > > > > Unfortunately, GNU make skips implicit rules for .PHONY targets, but it > > > is unlikely that $(STATEDIR)/%.urlcheck is created by something other > > > than PTXdist, so removing the $(call touch) is a good approximation for > > > phony behaviour. > > > > No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix > > errors and then continue with the rest. > > Can you not use -k to do this? I do that. But without the successful cache, I need to track all failures manually because I cannot call 'urlcheck' again. To check the rest. > Caching an error state is at least unusual, and it is not done anywhere > else in PTXdist, so this breaks the principle of least surprise. On the contrary. In general, if something was successful, then we don't do it again unless there is a clear indication that the input has changed. In all other cases an explicit 'drop' or 'clean' is needed. For example, we don't skip the 'touch' for local_src/ links either. Even though the code can change any time. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de