From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmCIa-0003NY-AS for ptxdist@pengutronix.de; Fri, 19 Jun 2020 10:22:56 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jmCIZ-0001jY-Vy for ptxdist@pengutronix.de; Fri, 19 Jun 2020 10:22:55 +0200 Date: Fri, 19 Jun 2020 10:22:55 +0200 From: Roland Hieber Message-ID: <20200619082255.jnafcoextmvx6oel@pengutronix.de> References: <20200613013249.4288-1-rhi@pengutronix.de> <20200613013249.4288-3-rhi@pengutronix.de> <20200619053401.GA9312@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200619053401.GA9312@pengutronix.de> Subject: Re: [ptxdist] [PATCH 3/7] ptxd_make_world_get: make 'ptxdist urlcheck' idempotent List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Jun 19, 2020 at 07:34:01AM +0200, Michael Olbrich wrote: > On Sat, Jun 13, 2020 at 03:32:45AM +0200, Roland Hieber wrote: > > There is no guarantee that URLs will still work the next time we want to > > check them, so try to fetch the URL every time instead of caching the > > result. This also makes iterations of editing the URL in the rule file > > and testing if it works quicker. > > > > Unfortunately, GNU make skips implicit rules for .PHONY targets, but it > > is unlikely that $(STATEDIR)/%.urlcheck is created by something other > > than PTXdist, so removing the $(call touch) is a good approximation for > > phony behaviour. > > No. This is deliberately like this. I want to run 'ptxdist urlcheck', fix > errors and then continue with the rest. Can you not use -k to do this? Caching an error state is at least unusual, and it is not done anywhere else in PTXdist, so this breaks the principle of least surprise. - Roland > How about an extra ptxdist options. When it is given, then all make target > that are explicitly specified on the command-line are added to the PHONY > list, so that they are always executed. Then you could do: > > ptxdist --something urlcheck foobar > > And you can do this multiple times. I don't have a good name for the > option. But I think this could be useful for other things as well. > > Michael > > > > Signed-off-by: Roland Hieber > > --- > > rules/post/ptxd_make_world_get.make | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make > > index a2026c994591..a79b4d170873 100644 > > --- a/rules/post/ptxd_make_world_get.make > > +++ b/rules/post/ptxd_make_world_get.make > > @@ -58,7 +58,6 @@ $(STATEDIR)/%.urlcheck: > > @$(call targetinfo) > > @$(foreach src,$($(PTX_MAP_TO_PACKAGE_$(*))_SOURCES), \ > > $(call world/urlcheck, $($(src)));) > > - @$(call touch) > > > > world/urlcheck = \ > > $(call world/env, $(1)) \ > > -- > > 2.27.0 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de