From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 Jun 2022 15:53:24 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1pw3-003xy5-0F for lore@lore.pengutronix.de; Thu, 16 Jun 2022 15:53:24 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1pw3-0007tQ-BM; Thu, 16 Jun 2022 15:53:23 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1pvl-0007sT-CD; Thu, 16 Jun 2022 15:53:05 +0200 Message-ID: <0268a579efc130bbf5040ca145b2911c61ef6e39.camel@pengutronix.de> From: Enrico =?ISO-8859-1?Q?J=F6rns?= To: Alexander Dahl Date: Thu, 16 Jun 2022 15:53:04 +0200 In-Reply-To: <20220616061632.GC2412@falbala.internal.home.lespocky.de> References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-4-ejo@pengutronix.de> <20220616061632.GC2412@falbala.internal.home.lespocky.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2-1 MIME-Version: 1.0 Subject: Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , ejo , ptxdist@pengutronix.de, jlu@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Alex, Am Donnerstag, dem 16.06.2022 um 08:16 +0200 schrieb Alexander Dahl: > > > >=20 > > > > diff --git a/rules/host-rauc.make b/rules/host-rauc.make > > > > index c78a518f6..1851aee9a 100644 > > > > --- a/rules/host-rauc.make > > > > +++ b/rules/host-rauc.make > > > > @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT :=3D \ > > > > $(HOST_AUTOCONF) \ > > > > --disable-code-coverage \ > > > > --disable-valgrind \ > > > > + --enable-create \ > > >=20 > > > From the cover letter I understood this is a new post 1.5 option, > > > right? > >=20 > > almost, as the cover-letter explicitly notes this is a post 1.3 option.= ;) > >=20 > > And this line is only for completeness. The added option in RAUC is sem= antically > > --disable-create and --enable-create is the default. >=20 > make rules in ptxdist pin down _all_ configure options, so if that was > missing for 1.5 package it was already forgotten to set when upgrading > from 1.3 or 1.4. yes, there have been no adaptions since the initial recipe submission. Seems as if I've won an extra price for this round. \o/ > > > > --disable-service \ > > > > --disable-network \ > > > > --disable-json > > > > diff --git a/rules/rauc.in b/rules/rauc.in > > > > index 832967b44..e43692846 100644 > > > > --- a/rules/rauc.in > > > > +++ b/rules/rauc.in > > > > @@ -27,6 +27,16 @@ menuconfig RAUC > > > > =20 > > > > if RAUC > > > > =20 > > > > +config RAUC_CREATE > > > > + bool > > > > + prompt "Enable bundle creation support on target" > > > > + default n > > > > + help > > > > + Enables support for creating bundles on target. > > > > + Disabling this will remove functionality required for bundle > > > > + creation which is not required on the target in most cases and = thus > > > > + allows to save space. > > > > + > > > > config RAUC_SERVICE > > > > bool > > > > prompt "Enable service (D-Bus) support" > > > > diff --git a/rules/rauc.make b/rules/rauc.make > > > > index 820583e59..e001956a5 100644 > > > > --- a/rules/rauc.make > > > > +++ b/rules/rauc.make > > > > @@ -41,6 +41,7 @@ RAUC_CONF_OPT :=3D \ > > > > $(GLOBAL_LARGE_FILE_OPTION) \ > > > > --disable-code-coverage \ > > > > --disable-valgrind \ > > > > + --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \ > > >=20 > > > Same here. This should have set explicitly to a sensible default with > > > the package update. Making this optional would just change that line > > > then instead of adding it. > >=20 > > See above. The ptxdist default for RAUC_CREATE ("n") leads to --disable= -create > > which changes the RAUC default (which is --enable-create). >=20 > I understand RAUC has some opinion what should be default. Some > embedded build systems like buildroot stick with those defaults (for > all options not explicitly set through menu). Others like ptxdist set > all configure options. The script 'scripts/configure_helper.py' helps > determining missing options not set. See example output for package > host-rauc on a ptxdist 2021.06.0 based BSP: Since I know some of them, I'd tend to say the group of 'Others' exclusivel= y consists of ptxdist to the best of my knowledge. But yes, in theory I am aware of this design decision ;) Thanks for the helper script, I'll give it a try. > % ~/src/ptxdist/scripts/configure_helper.py -p host-rauc > --- rules/host-rauc.make > +++ rauc-1.5.1 > @@ -1,6 +1,17 @@ > --prefix=3D > + --enable-debug=3Dyes/info/profile/no > + --disable-largefile > + --enable-compile-warnings=3Dno/yes/error > + --disable-Werror > --disable-code-coverage > --disable-valgrind > --disable-service > + --disable-create > --disable-network > --disable-json > + --enable-gpt > + --with-gcov=3DGCOV > + --with-systemdunitdir=3DDIR > + --with-dbuspolicydir=3DDIR > + --with-dbussystemservicedir=3DDIR > + --with-dbusinterfacesdir=3DDIR >=20 > You see --disable-create is not the only option not set in > rules/host-rauc.make and I guess it might look similar for rauc.make? It does, yes (with a little bit less diff lines). > Pinning down the old options should go to a patch before bumping the > version. Give me a second.. Best regards Enrico >=20 > Greets > Alex >=20 > >=20 > > Regards, Enrico > >=20 > > > Greets > > > Alex > > >=20 > > > > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > > > > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > > > > --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > > > > --=20 > > > > 2.30.2 > > > >=20 > > > >=20 > > >=20 > > >=20 > >=20 > > --=20 > > Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= | > > Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| https://www.pengutronix.de/ | > > Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| > > 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0= =C2=A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0| >=20 --=20 Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| https://www.pengutronix.de/ | Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0|