mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH v2] vulkan-loader: enable assembly on aarch64 and x86_64
@ 2023-06-06  7:02 Philipp Zabel
  2023-06-21  8:51 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2023-06-06  7:02 UTC (permalink / raw)
  To: ptxdist; +Cc: Philipp Zabel

Fixes the following CMake warning during prepare:

  Assembly sources have been disabled

  The build will fall back on building with C code

  Note that this may be unsafe, as the C code requires tail-call
  optimizations to remove the stack frame for certain calls.  If the compiler
  does not do this, then unknown device extensions will suffer from a
  corrupted stack.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
v2: move VULKAN_LOADER_USE_GAS above VULKAN_LOADER_CONF_OPT
---
 rules/vulkan-loader.make | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
index d09a78778ffe..7e4e4df2ad5d 100644
--- a/rules/vulkan-loader.make
+++ b/rules/vulkan-loader.make
@@ -29,6 +29,15 @@ VULKAN_LOADER_LICENSE_FILES := file://LICENSE.txt;md5=7dbefed23242760aa3475ee428
 # ----------------------------------------------------------------------------
 
 VULKAN_LOADER_CONF_TOOL	:= cmake
+
+VULKAN_LOADER_USE_GAS := OFF
+ifdef PTXCONF_ARCH_ARM64
+VULKAN_LOADER_USE_GAS := ON
+endif
+ifdef PTXCONF_ARCH_X86_64
+VULKAN_LOADER_USE_GAS := ON
+endif
+
 VULKAN_LOADER_CONF_OPT	:= \
 	$(CROSS_CMAKE_USR) \
 	-DCMAKE_BUILD_TYPE=Release \
@@ -45,7 +54,7 @@ VULKAN_LOADER_CONF_OPT	:= \
 	-DLOADER_ENABLE_THREAD_SANITIZER=OFF \
 	-DSYSCONFDIR= \
 	-DUPDATE_DEPS=OFF \
-	-DUSE_GAS=OFF
+	-DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
 
 # ----------------------------------------------------------------------------
 # Target-Install
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-21  8:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06  7:02 [ptxdist] [PATCH v2] vulkan-loader: enable assembly on aarch64 and x86_64 Philipp Zabel
2023-06-21  8:51 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox