From: Philipp Zabel <p.zabel@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Subject: [ptxdist] [PATCH v2] vulkan-loader: enable assembly on aarch64 and x86_64
Date: Tue, 6 Jun 2023 09:02:01 +0200 [thread overview]
Message-ID: <20230606070201.619752-1-p.zabel@pengutronix.de> (raw)
Fixes the following CMake warning during prepare:
Assembly sources have been disabled
The build will fall back on building with C code
Note that this may be unsafe, as the C code requires tail-call
optimizations to remove the stack frame for certain calls. If the compiler
does not do this, then unknown device extensions will suffer from a
corrupted stack.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
v2: move VULKAN_LOADER_USE_GAS above VULKAN_LOADER_CONF_OPT
---
rules/vulkan-loader.make | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
index d09a78778ffe..7e4e4df2ad5d 100644
--- a/rules/vulkan-loader.make
+++ b/rules/vulkan-loader.make
@@ -29,6 +29,15 @@ VULKAN_LOADER_LICENSE_FILES := file://LICENSE.txt;md5=7dbefed23242760aa3475ee428
# ----------------------------------------------------------------------------
VULKAN_LOADER_CONF_TOOL := cmake
+
+VULKAN_LOADER_USE_GAS := OFF
+ifdef PTXCONF_ARCH_ARM64
+VULKAN_LOADER_USE_GAS := ON
+endif
+ifdef PTXCONF_ARCH_X86_64
+VULKAN_LOADER_USE_GAS := ON
+endif
+
VULKAN_LOADER_CONF_OPT := \
$(CROSS_CMAKE_USR) \
-DCMAKE_BUILD_TYPE=Release \
@@ -45,7 +54,7 @@ VULKAN_LOADER_CONF_OPT := \
-DLOADER_ENABLE_THREAD_SANITIZER=OFF \
-DSYSCONFDIR= \
-DUPDATE_DEPS=OFF \
- -DUSE_GAS=OFF
+ -DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
# ----------------------------------------------------------------------------
# Target-Install
--
2.39.2
next reply other threads:[~2023-06-06 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:02 Philipp Zabel [this message]
2023-06-21 8:51 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606070201.619752-1-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox