From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] vulkan-loader: enable assembly on aarch64 and x86_64
Date: Wed, 21 Jun 2023 10:51:05 +0200 [thread overview]
Message-ID: <20230621085105.2553496-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20230606070201.619752-1-p.zabel@pengutronix.de>
Thanks, applied as 7ab096984be7cf0c977fbc899b2021d3af8aa9d2.
Michael
[sent from post-receive hook]
On Wed, 21 Jun 2023 10:51:05 +0200, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Fixes the following CMake warning during prepare:
>
> Assembly sources have been disabled
>
> The build will fall back on building with C code
>
> Note that this may be unsafe, as the C code requires tail-call
> optimizations to remove the stack frame for certain calls. If the compiler
> does not do this, then unknown device extensions will suffer from a
> corrupted stack.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20230606070201.619752-1-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
> index d09a78778ffe..7e4e4df2ad5d 100644
> --- a/rules/vulkan-loader.make
> +++ b/rules/vulkan-loader.make
> @@ -29,6 +29,15 @@ VULKAN_LOADER_LICENSE_FILES := file://LICENSE.txt;md5=7dbefed23242760aa3475ee428
> # ----------------------------------------------------------------------------
>
> VULKAN_LOADER_CONF_TOOL := cmake
> +
> +VULKAN_LOADER_USE_GAS := OFF
> +ifdef PTXCONF_ARCH_ARM64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +ifdef PTXCONF_ARCH_X86_64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +
> VULKAN_LOADER_CONF_OPT := \
> $(CROSS_CMAKE_USR) \
> -DCMAKE_BUILD_TYPE=Release \
> @@ -45,7 +54,7 @@ VULKAN_LOADER_CONF_OPT := \
> -DLOADER_ENABLE_THREAD_SANITIZER=OFF \
> -DSYSCONFDIR= \
> -DUPDATE_DEPS=OFF \
> - -DUSE_GAS=OFF
> + -DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
>
> # ----------------------------------------------------------------------------
> # Target-Install
prev parent reply other threads:[~2023-06-21 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:02 [ptxdist] [PATCH v2] " Philipp Zabel
2023-06-21 8:51 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621085105.2553496-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox