From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Wed, 21 Jun 2023 10:51:38 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1qBtYx-00FRx2-T4
	for lore@lore.pengutronix.de; Wed, 21 Jun 2023 10:51:38 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1qBtYv-00069D-L9; Wed, 21 Jun 2023 10:51:37 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1qBtYR-00068a-1J; Wed, 21 Jun 2023 10:51:07 +0200
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1qBtYQ-008zYx-Cg; Wed, 21 Jun 2023 10:51:06 +0200
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1qBtYP-00AiHb-2a;
 Wed, 21 Jun 2023 10:51:05 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Wed, 21 Jun 2023 10:51:05 +0200
Message-Id: <20230621085105.2553496-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230606070201.619752-1-p.zabel@pengutronix.de>
References: <20230606070201.619752-1-p.zabel@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] vulkan-loader: enable assembly on aarch64
 and x86_64
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 7ab096984be7cf0c977fbc899b2021d3af8aa9d2.

Michael

[sent from post-receive hook]

On Wed, 21 Jun 2023 10:51:05 +0200, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Fixes the following CMake warning during prepare:
> 
>   Assembly sources have been disabled
> 
>   The build will fall back on building with C code
> 
>   Note that this may be unsafe, as the C code requires tail-call
>   optimizations to remove the stack frame for certain calls.  If the compiler
>   does not do this, then unknown device extensions will suffer from a
>   corrupted stack.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20230606070201.619752-1-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
> index d09a78778ffe..7e4e4df2ad5d 100644
> --- a/rules/vulkan-loader.make
> +++ b/rules/vulkan-loader.make
> @@ -29,6 +29,15 @@ VULKAN_LOADER_LICENSE_FILES := file://LICENSE.txt;md5=7dbefed23242760aa3475ee428
>  # ----------------------------------------------------------------------------
>  
>  VULKAN_LOADER_CONF_TOOL	:= cmake
> +
> +VULKAN_LOADER_USE_GAS := OFF
> +ifdef PTXCONF_ARCH_ARM64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +ifdef PTXCONF_ARCH_X86_64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +
>  VULKAN_LOADER_CONF_OPT	:= \
>  	$(CROSS_CMAKE_USR) \
>  	-DCMAKE_BUILD_TYPE=Release \
> @@ -45,7 +54,7 @@ VULKAN_LOADER_CONF_OPT	:= \
>  	-DLOADER_ENABLE_THREAD_SANITIZER=OFF \
>  	-DSYSCONFDIR= \
>  	-DUPDATE_DEPS=OFF \
> -	-DUSE_GAS=OFF
> +	-DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
>  
>  # ----------------------------------------------------------------------------
>  # Target-Install