* [ptxdist] [PATCH] libpng: version bump 1.6.37 -> 1.6.38
@ 2022-10-04 14:48 Bastian Krause
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Bastian Krause @ 2022-10-04 14:48 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
rules/libpng.make | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rules/libpng.make b/rules/libpng.make
index 0a1fbdee9..e9b0bf67a 100644
--- a/rules/libpng.make
+++ b/rules/libpng.make
@@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBPNG) += libpng
#
# Paths and names
#
-LIBPNG_VERSION := 1.6.37
-LIBPNG_MD5 := 015e8e15db1eecde5f2eb9eb5b6e59e9
+LIBPNG_VERSION := 1.6.38
+LIBPNG_MD5 := 122e6b7837811698563083b352bc8ca2
LIBPNG := libpng-$(LIBPNG_VERSION)
LIBPNG_SUFFIX := tar.xz
LIBPNG_URL := $(call ptx/mirror, SF, libpng/$(LIBPNG).$(LIBPNG_SUFFIX))
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [APPLIED] libpng: version bump 1.6.37 -> 1.6.38
2022-10-04 14:48 [ptxdist] [PATCH] libpng: version bump 1.6.37 -> 1.6.38 Bastian Krause
@ 2022-10-19 5:41 ` Michael Olbrich
0 siblings, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2022-10-19 5:41 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Thanks, applied as 06e17fc0c9d9efe1ed7009e8231c829fe845b060.
Michael
[sent from post-receive hook]
On Wed, 19 Oct 2022 07:41:14 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20221004144855.2277737-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/libpng.make b/rules/libpng.make
> index 0a1fbdee9a7c..e9b0bf67a942 100644
> --- a/rules/libpng.make
> +++ b/rules/libpng.make
> @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBPNG) += libpng
> #
> # Paths and names
> #
> -LIBPNG_VERSION := 1.6.37
> -LIBPNG_MD5 := 015e8e15db1eecde5f2eb9eb5b6e59e9
> +LIBPNG_VERSION := 1.6.38
> +LIBPNG_MD5 := 122e6b7837811698563083b352bc8ca2
> LIBPNG := libpng-$(LIBPNG_VERSION)
> LIBPNG_SUFFIX := tar.xz
> LIBPNG_URL := $(call ptx/mirror, SF, libpng/$(LIBPNG).$(LIBPNG_SUFFIX))
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ptxdist] [PATCH v2] libpng: version bump 1.6.37 -> 1.6.38
@ 2022-10-05 10:27 Bastian Krause
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Bastian Krause @ 2022-10-05 10:27 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Effectively reverts parts of
249544ffd ("libpng: version bump 1.6.29 -> 1.6.34").
"--enable-arm-neon=check" leads to problems on ARM64, such as:
arm/arm_init.c:39:6: error: #error "PNG_ARM_NEON_CHECK_SUPPORTED must not be defined on this platform"
The check mechanism is not recommended anyway [1]:
WARNING: it is strongly recommended that you do not build libpng with
run-time checks for CPU features if at all possible. In the case of the ARM
NEON instructions there is no processor-specific way of detecting the
presence of the required support, therefore run-time detection is extremely
OS specific.
So stick to yes/no for the ARM NEON option by switching to the ptx/yesno
macro.
[1] https://sourceforge.net/p/libpng/code/ci/v1.6.38/tree/arm/arm_init.c#l21
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
Changes since (implicit) v1:
- adjust --enable-arm-neon option
---
rules/libpng.make | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/rules/libpng.make b/rules/libpng.make
index 0a1fbdee9..aff687df6 100644
--- a/rules/libpng.make
+++ b/rules/libpng.make
@@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBPNG) += libpng
#
# Paths and names
#
-LIBPNG_VERSION := 1.6.37
-LIBPNG_MD5 := 015e8e15db1eecde5f2eb9eb5b6e59e9
+LIBPNG_VERSION := 1.6.38
+LIBPNG_MD5 := 122e6b7837811698563083b352bc8ca2
LIBPNG := libpng-$(LIBPNG_VERSION)
LIBPNG_SUFFIX := tar.xz
LIBPNG_URL := $(call ptx/mirror, SF, libpng/$(LIBPNG).$(LIBPNG_SUFFIX))
@@ -37,7 +37,7 @@ LIBPNG_CONF_OPT := \
--enable-unversioned-links \
--enable-unversioned-libpng-pc \
--enable-unversioned-libpng-config \
- --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON, check, no) \
+ --enable-arm-neon=$(call ptx/yesno, PTXCONF_ARCH_ARM_NEON) \
--disable-mips-msa \
--$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \
--disable-powerpc-vsx \
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [APPLIED] libpng: version bump 1.6.37 -> 1.6.38
2022-10-05 10:27 [ptxdist] [PATCH v2] " Bastian Krause
@ 2022-10-19 5:41 ` Michael Olbrich
0 siblings, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2022-10-19 5:41 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Thanks, applied as dcd1bd2f752aa4213087020eb0f2816d49f45d8d.
Michael
[sent from post-receive hook]
On Wed, 19 Oct 2022 07:41:20 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Effectively reverts parts of
> 249544ffd ("libpng: version bump 1.6.29 -> 1.6.34").
>
> "--enable-arm-neon=check" leads to problems on ARM64, such as:
>
> arm/arm_init.c:39:6: error: #error "PNG_ARM_NEON_CHECK_SUPPORTED must not be defined on this platform"
>
> The check mechanism is not recommended anyway [1]:
>
> WARNING: it is strongly recommended that you do not build libpng with
> run-time checks for CPU features if at all possible. In the case of the ARM
> NEON instructions there is no processor-specific way of detecting the
> presence of the required support, therefore run-time detection is extremely
> OS specific.
>
> So stick to yes/no for the ARM NEON option by switching to the ptx/yesno
> macro.
>
> [1] https://sourceforge.net/p/libpng/code/ci/v1.6.38/tree/arm/arm_init.c#l21
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20221005102705.2346939-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/libpng.make b/rules/libpng.make
> index e9b0bf67a942..aff687df640f 100644
> --- a/rules/libpng.make
> +++ b/rules/libpng.make
> @@ -37,7 +37,7 @@ LIBPNG_CONF_OPT := \
> --enable-unversioned-links \
> --enable-unversioned-libpng-pc \
> --enable-unversioned-libpng-config \
> - --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON, check, no) \
> + --enable-arm-neon=$(call ptx/yesno, PTXCONF_ARCH_ARM_NEON) \
> --disable-mips-msa \
> --$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \
> --disable-powerpc-vsx \
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-19 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 14:48 [ptxdist] [PATCH] libpng: version bump 1.6.37 -> 1.6.38 Bastian Krause
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-10-05 10:27 [ptxdist] [PATCH v2] " Bastian Krause
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox