From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Krause <bst@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] libpng: version bump 1.6.37 -> 1.6.38
Date: Wed, 19 Oct 2022 07:41:21 +0200 [thread overview]
Message-ID: <20221019054121.402872-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20221005102705.2346939-1-bst@pengutronix.de>
Thanks, applied as dcd1bd2f752aa4213087020eb0f2816d49f45d8d.
Michael
[sent from post-receive hook]
On Wed, 19 Oct 2022 07:41:20 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Effectively reverts parts of
> 249544ffd ("libpng: version bump 1.6.29 -> 1.6.34").
>
> "--enable-arm-neon=check" leads to problems on ARM64, such as:
>
> arm/arm_init.c:39:6: error: #error "PNG_ARM_NEON_CHECK_SUPPORTED must not be defined on this platform"
>
> The check mechanism is not recommended anyway [1]:
>
> WARNING: it is strongly recommended that you do not build libpng with
> run-time checks for CPU features if at all possible. In the case of the ARM
> NEON instructions there is no processor-specific way of detecting the
> presence of the required support, therefore run-time detection is extremely
> OS specific.
>
> So stick to yes/no for the ARM NEON option by switching to the ptx/yesno
> macro.
>
> [1] https://sourceforge.net/p/libpng/code/ci/v1.6.38/tree/arm/arm_init.c#l21
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20221005102705.2346939-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/libpng.make b/rules/libpng.make
> index e9b0bf67a942..aff687df640f 100644
> --- a/rules/libpng.make
> +++ b/rules/libpng.make
> @@ -37,7 +37,7 @@ LIBPNG_CONF_OPT := \
> --enable-unversioned-links \
> --enable-unversioned-libpng-pc \
> --enable-unversioned-libpng-config \
> - --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON, check, no) \
> + --enable-arm-neon=$(call ptx/yesno, PTXCONF_ARCH_ARM_NEON) \
> --disable-mips-msa \
> --$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \
> --disable-powerpc-vsx \
next prev parent reply other threads:[~2022-10-19 5:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 10:27 [ptxdist] [PATCH v2] " Bastian Krause
2022-10-19 5:41 ` Michael Olbrich [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-04 14:48 [ptxdist] [PATCH] " Bastian Krause
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019054121.402872-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bst@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox