From: Bastian Krause <bst@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Krause <bst@pengutronix.de>
Subject: [ptxdist] [PATCH v2] libpng: version bump 1.6.37 -> 1.6.38
Date: Wed, 5 Oct 2022 12:27:05 +0200 [thread overview]
Message-ID: <20221005102705.2346939-1-bst@pengutronix.de> (raw)
Effectively reverts parts of
249544ffd ("libpng: version bump 1.6.29 -> 1.6.34").
"--enable-arm-neon=check" leads to problems on ARM64, such as:
arm/arm_init.c:39:6: error: #error "PNG_ARM_NEON_CHECK_SUPPORTED must not be defined on this platform"
The check mechanism is not recommended anyway [1]:
WARNING: it is strongly recommended that you do not build libpng with
run-time checks for CPU features if at all possible. In the case of the ARM
NEON instructions there is no processor-specific way of detecting the
presence of the required support, therefore run-time detection is extremely
OS specific.
So stick to yes/no for the ARM NEON option by switching to the ptx/yesno
macro.
[1] https://sourceforge.net/p/libpng/code/ci/v1.6.38/tree/arm/arm_init.c#l21
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
Changes since (implicit) v1:
- adjust --enable-arm-neon option
---
rules/libpng.make | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/rules/libpng.make b/rules/libpng.make
index 0a1fbdee9..aff687df6 100644
--- a/rules/libpng.make
+++ b/rules/libpng.make
@@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBPNG) += libpng
#
# Paths and names
#
-LIBPNG_VERSION := 1.6.37
-LIBPNG_MD5 := 015e8e15db1eecde5f2eb9eb5b6e59e9
+LIBPNG_VERSION := 1.6.38
+LIBPNG_MD5 := 122e6b7837811698563083b352bc8ca2
LIBPNG := libpng-$(LIBPNG_VERSION)
LIBPNG_SUFFIX := tar.xz
LIBPNG_URL := $(call ptx/mirror, SF, libpng/$(LIBPNG).$(LIBPNG_SUFFIX))
@@ -37,7 +37,7 @@ LIBPNG_CONF_OPT := \
--enable-unversioned-links \
--enable-unversioned-libpng-pc \
--enable-unversioned-libpng-config \
- --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON, check, no) \
+ --enable-arm-neon=$(call ptx/yesno, PTXCONF_ARCH_ARM_NEON) \
--disable-mips-msa \
--$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \
--disable-powerpc-vsx \
--
2.30.2
next reply other threads:[~2022-10-05 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 10:27 Bastian Krause [this message]
2022-10-19 5:41 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005102705.2346939-1-bst@pengutronix.de \
--to=bst@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox