From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 19 Oct 2022 07:42:05 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ol1qB-000Ga6-08 for lore@lore.pengutronix.de; Wed, 19 Oct 2022 07:42:05 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ol1q8-00052z-SZ; Wed, 19 Oct 2022 07:42:04 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol1pT-0002FV-9H; Wed, 19 Oct 2022 07:41:23 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ol1pS-0002wq-6n; Wed, 19 Oct 2022 07:41:22 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ol1pR-001goh-5p; Wed, 19 Oct 2022 07:41:21 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Wed, 19 Oct 2022 07:41:21 +0200 Message-Id: <20221019054121.402872-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221005102705.2346939-1-bst@pengutronix.de> References: <20221005102705.2346939-1-bst@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] libpng: version bump 1.6.37 -> 1.6.38 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Bastian Krause Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as dcd1bd2f752aa4213087020eb0f2816d49f45d8d. Michael [sent from post-receive hook] On Wed, 19 Oct 2022 07:41:20 +0200, Bastian Krause wrote: > Effectively reverts parts of > 249544ffd ("libpng: version bump 1.6.29 -> 1.6.34"). > > "--enable-arm-neon=check" leads to problems on ARM64, such as: > > arm/arm_init.c:39:6: error: #error "PNG_ARM_NEON_CHECK_SUPPORTED must not be defined on this platform" > > The check mechanism is not recommended anyway [1]: > > WARNING: it is strongly recommended that you do not build libpng with > run-time checks for CPU features if at all possible. In the case of the ARM > NEON instructions there is no processor-specific way of detecting the > presence of the required support, therefore run-time detection is extremely > OS specific. > > So stick to yes/no for the ARM NEON option by switching to the ptx/yesno > macro. > > [1] https://sourceforge.net/p/libpng/code/ci/v1.6.38/tree/arm/arm_init.c#l21 > > Signed-off-by: Bastian Krause > Message-Id: <20221005102705.2346939-1-bst@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/rules/libpng.make b/rules/libpng.make > index e9b0bf67a942..aff687df640f 100644 > --- a/rules/libpng.make > +++ b/rules/libpng.make > @@ -37,7 +37,7 @@ LIBPNG_CONF_OPT := \ > --enable-unversioned-links \ > --enable-unversioned-libpng-pc \ > --enable-unversioned-libpng-config \ > - --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON, check, no) \ > + --enable-arm-neon=$(call ptx/yesno, PTXCONF_ARCH_ARM_NEON) \ > --disable-mips-msa \ > --$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \ > --disable-powerpc-vsx \