[ptxdist] [PATCH v2 1/3] pps-tools: new package

[ptxdist] [PATCH v2 1/3] pps-tools: new package

[Roland Hieber]

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
v1 -> v2:
 - Michael Olbrich: use $(call compile …) and $(call world/compile …)

v1 was at https://lore.ptxdist.org/ptxdist/20210604092303.GE12506@pengutronix.de
---
 ...le-fix-installation-to-empty-DESTDIR.patch | 40 ++++++++++
 patches/pps-tools-1.0.2/series                |  4 +
 rules/pps-tools.in                            | 10 +++
 rules/pps-tools.make                          | 76 +++++++++++++++++++
 4 files changed, 130 insertions(+)
 create mode 100644 patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch
 create mode 100644 patches/pps-tools-1.0.2/series
 create mode 100644 rules/pps-tools.in
 create mode 100644 rules/pps-tools.make

diff --git a/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch b/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch
new file mode 100644
index 000000000000..97498dc22e1b
--- /dev/null
+++ b/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch
@@ -0,0 +1,40 @@
+From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Date: Mon, 3 Dec 2018 13:55:02 +0100
+Subject: [PATCH] Makefile: fix installation to empty DESTDIR
+
+When DESTDIR is empty, or at least does not contain usr/bin or
+usr/include, the installation fails, because install does not create
+those intermediate directories:
+
+$ make DESTDIR=/tmp/koin install
+install -m 755 -t /tmp/koin/usr/bin ppsfind ppstest ppsctl ppswatch ppsldisc
+install: failed to access '/tmp/koin/usr/bin': No such file or directory
+
+Using the -D option of install fixes this:
+
+$ make DESTDIR=/tmp/koin install
+install -D -m 755 -t /tmp/koin/usr/bin ppsfind ppstest ppsctl ppswatch ppsldisc
+install -D -m 644 -t /tmp/koin/usr/include/sys timepps.h
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Origin: upstream; https://github.com/redlab-i/pps-tools/commit/b3eae485a8c759d1ce1727076b2c287deb5f24e1
+Signed-off-by: Roland Hieber <rhi@pengutronix.de>
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index 939466885e9f..30672f79585c 100644
+--- a/Makefile
++++ b/Makefile
+@@ -19,8 +19,8 @@ include .depend
+ endif
+ 
+ install : all
+-	install -m 755 -t $(DESTDIR)/usr/bin ppsfind $(TARGETS)
+-	install -m 644 -t $(DESTDIR)/usr/include/sys timepps.h
++	install -D -m 755 -t $(DESTDIR)/usr/bin ppsfind $(TARGETS)
++	install -D -m 644 -t $(DESTDIR)/usr/include/sys timepps.h
+ 
+ uninstall :
+ 	for f in $(TARGETS); do rm $(DESTDIR)/usr/bin/$$f; done
diff --git a/patches/pps-tools-1.0.2/series b/patches/pps-tools-1.0.2/series
new file mode 100644
index 000000000000..7b3c7762325f
--- /dev/null
+++ b/patches/pps-tools-1.0.2/series
@@ -0,0 +1,4 @@
+# generated by git-ptx-patches
+#tag:base --start-number 1
+0001-Makefile-fix-installation-to-empty-DESTDIR.patch
+# eb24c32ce10c0f011f2d37488c8de58c  - git-ptx-patches magic
diff --git a/rules/pps-tools.in b/rules/pps-tools.in
new file mode 100644
index 000000000000..2cce9464ae93
--- /dev/null
+++ b/rules/pps-tools.in
@@ -0,0 +1,10 @@
+## SECTION=shell_and_console
+
+config PPS_TOOLS
+	tristate
+	prompt "pps-tools"
+	select LIBC_M
+	help
+	  The pps-tools provide applications to configure and test pulse per
+	  second devices. They also provide the official PPS API header
+	  timepps.h.
diff --git a/rules/pps-tools.make b/rules/pps-tools.make
new file mode 100644
index 000000000000..65a06c7d128b
--- /dev/null
+++ b/rules/pps-tools.make
@@ -0,0 +1,76 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2020 by Daniel Glöckner <dg@emlix.com>
+# Copyright (C) 2021 Roland Hieber, Pengutronix <rhi@pengutronix.de>
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_PPS_TOOLS) += pps-tools
+
+#
+# Paths and names
+#
+PPS_TOOLS_VERSION	:= 1.0.2
+PPS_TOOLS_MD5		:= 6eddfeb151cffe8751f4766e428b8eb7
+PPS_TOOLS		:= pps-tools-$(PPS_TOOLS_VERSION)
+PPS_TOOLS_SUFFIX	:= tar.gz
+PPS_TOOLS_URL		:= https://github.com/redlab-i/pps-tools/archive/v$(PPS_TOOLS_VERSION).$(PPS_TOOLS_SUFFIX)
+PPS_TOOLS_SOURCE	:= $(SRCDIR)/$(PPS_TOOLS).$(PPS_TOOLS_SUFFIX)
+PPS_TOOLS_DIR		:= $(BUILDDIR)/$(PPS_TOOLS)
+PPS_TOOLS_LICENSE	:= GPL-2.0-or-later
+PPS_TOOLS_LICENSE_FILES	:= \
+	file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
+	file://ppsctl.c;startline=6;endline=14;md5=681a7c053fa782c41658ac9fc7dd1579
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+PPS_TOOLS_CONF_TOOL	:= NO
+
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
+PPS_TOOLS_MAKE_ENV	:= $(CROSS_ENV)
+
+$(STATEDIR)/pps-tools.compile:
+	@$(call targetinfo)
+
+	@# Everything depends on .depends, which is made by but also included
+	@# in the Makefile, so make sure that "make install" does not rebuild
+	@# everything
+	@$(call compile, PPS_TOOLS, .depend)
+	@$(call world/compile, PPS_TOOLS)
+
+	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/pps-tools.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, pps-tools)
+	@$(call install_fixup, pps-tools,PRIORITY,optional)
+	@$(call install_fixup, pps-tools,SECTION,base)
+	@$(call install_fixup, pps-tools,AUTHOR,"Daniel Glöckner <dg@emlix.com>")
+	@$(call install_fixup, pps-tools,DESCRIPTION,missing)
+
+	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsfind)
+	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppstest)
+	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsctl)
+	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppswatch)
+	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsldisc)
+
+	@$(call install_finish, pps-tools)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

[ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices

[Roland Hieber]

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
v1 -> v2:
 - fix --disable-pps option

v1 was at https://lore.ptxdist.org/ptxdist/20210604092505.GF12506@pengutronix.de
---
 rules/chrony.in   | 8 ++++++++
 rules/chrony.make | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/rules/chrony.in b/rules/chrony.in
index f50b864429b0..67a87277fc84 100644
--- a/rules/chrony.in
+++ b/rules/chrony.in
@@ -8,6 +8,7 @@ menuconfig CHRONY
 	select LIBCAP
 	select LIBSECCOMP	if CHRONY_SECCOMP
 	select NETTLE		if CHRONY_USE_NETTLE
+	select PPS_TOOLS	if CHRONY_PPS_REFCLK
 	help
 	  This will install the Chrony NTPD Daemon (chronyd)
 	  Chrony is a pair of programs which are used to maintain
@@ -44,6 +45,13 @@ config CHRONY_ADVANCED_COMMAND
 	  This allows getting advanced NTP time synchronization
 	  status monitoring from the service.
 
+config CHRONY_PPS_REFCLK
+	bool
+	prompt "Enable support for PPS devices"
+	help
+	  Pulse per second devices signal the start of every second
+	  with high precision.
+
 comment "install options   ---"
 
 config CHRONY_INSTALL_CHRONY_COMMAND
diff --git a/rules/chrony.make b/rules/chrony.make
index 7cf59f30560c..15f475d889a6 100644
--- a/rules/chrony.make
+++ b/rules/chrony.make
@@ -52,7 +52,7 @@ CHRONY_CONF_OPT		:= \
 	$(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
 	--disable-refclock \
 	--disable-phc \
-	--disable-pps \
+	$(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \
 	$(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
 	--with-user=chrony \
 	$(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

[ptxdist] [PATCH v2 3/3] chrony: fix typo

[Roland Hieber]

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
v1 -> v2: no changes
v1 was at https://lore.ptxdist.org/ptxdist/20210531115708.4173-3-rhi@pengutronix.de
---
 rules/chrony.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/chrony.make b/rules/chrony.make
index 15f475d889a6..4435b8e97796 100644
--- a/rules/chrony.make
+++ b/rules/chrony.make
@@ -32,7 +32,7 @@ CHRONY_LICENSE_FILES	:= \
 # ----------------------------------------------------------------------------
 
 #
-# Chony is using a handcrafted configure script so normal ptx/endis
+# Chrony is using a handcrafted configure script so normal ptx/endis
 # and ptx/wwo are broken and causes "Unrecognized option".
 # CROSS_AUTOCONF_USR is not used as that adds 3 unrecognized options:
 # --libdir=, --build=, --host=
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] pps-tools: new package

[Michael Olbrich]

Thanks, applied as 4c421f627894f8894c1817183d5744eafe8ee6da.

Michael

[sent from post-receive hook]

On Wed, 16 Jun 2021 12:35:21 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210604180715.4674-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch b/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch
> new file mode 100644
> index 000000000000..97498dc22e1b
> --- /dev/null
> +++ b/patches/pps-tools-1.0.2/0001-Makefile-fix-installation-to-empty-DESTDIR.patch
> @@ -0,0 +1,40 @@
> +From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> +Date: Mon, 3 Dec 2018 13:55:02 +0100
> +Subject: [PATCH] Makefile: fix installation to empty DESTDIR
> +
> +When DESTDIR is empty, or at least does not contain usr/bin or
> +usr/include, the installation fails, because install does not create
> +those intermediate directories:
> +
> +$ make DESTDIR=/tmp/koin install
> +install -m 755 -t /tmp/koin/usr/bin ppsfind ppstest ppsctl ppswatch ppsldisc
> +install: failed to access '/tmp/koin/usr/bin': No such file or directory
> +
> +Using the -D option of install fixes this:
> +
> +$ make DESTDIR=/tmp/koin install
> +install -D -m 755 -t /tmp/koin/usr/bin ppsfind ppstest ppsctl ppswatch ppsldisc
> +install -D -m 644 -t /tmp/koin/usr/include/sys timepps.h
> +
> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> +Origin: upstream; https://github.com/redlab-i/pps-tools/commit/b3eae485a8c759d1ce1727076b2c287deb5f24e1
> +Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> +---
> + Makefile | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/Makefile b/Makefile
> +index 939466885e9f..30672f79585c 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -19,8 +19,8 @@ include .depend
> + endif
> + 
> + install : all
> +-	install -m 755 -t $(DESTDIR)/usr/bin ppsfind $(TARGETS)
> +-	install -m 644 -t $(DESTDIR)/usr/include/sys timepps.h
> ++	install -D -m 755 -t $(DESTDIR)/usr/bin ppsfind $(TARGETS)
> ++	install -D -m 644 -t $(DESTDIR)/usr/include/sys timepps.h
> + 
> + uninstall :
> + 	for f in $(TARGETS); do rm $(DESTDIR)/usr/bin/$$f; done
> diff --git a/patches/pps-tools-1.0.2/series b/patches/pps-tools-1.0.2/series
> new file mode 100644
> index 000000000000..7b3c7762325f
> --- /dev/null
> +++ b/patches/pps-tools-1.0.2/series
> @@ -0,0 +1,4 @@
> +# generated by git-ptx-patches
> +#tag:base --start-number 1
> +0001-Makefile-fix-installation-to-empty-DESTDIR.patch
> +# eb24c32ce10c0f011f2d37488c8de58c  - git-ptx-patches magic
> diff --git a/rules/pps-tools.in b/rules/pps-tools.in
> new file mode 100644
> index 000000000000..2cce9464ae93
> --- /dev/null
> +++ b/rules/pps-tools.in
> @@ -0,0 +1,10 @@
> +## SECTION=shell_and_console
> +
> +config PPS_TOOLS
> +	tristate
> +	prompt "pps-tools"
> +	select LIBC_M
> +	help
> +	  The pps-tools provide applications to configure and test pulse per
> +	  second devices. They also provide the official PPS API header
> +	  timepps.h.
> diff --git a/rules/pps-tools.make b/rules/pps-tools.make
> new file mode 100644
> index 000000000000..65a06c7d128b
> --- /dev/null
> +++ b/rules/pps-tools.make
> @@ -0,0 +1,76 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2020 by Daniel Glöckner <dg@emlix.com>
> +# Copyright (C) 2021 Roland Hieber, Pengutronix <rhi@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_PPS_TOOLS) += pps-tools
> +
> +#
> +# Paths and names
> +#
> +PPS_TOOLS_VERSION	:= 1.0.2
> +PPS_TOOLS_MD5		:= 6eddfeb151cffe8751f4766e428b8eb7
> +PPS_TOOLS		:= pps-tools-$(PPS_TOOLS_VERSION)
> +PPS_TOOLS_SUFFIX	:= tar.gz
> +PPS_TOOLS_URL		:= https://github.com/redlab-i/pps-tools/archive/v$(PPS_TOOLS_VERSION).$(PPS_TOOLS_SUFFIX)
> +PPS_TOOLS_SOURCE	:= $(SRCDIR)/$(PPS_TOOLS).$(PPS_TOOLS_SUFFIX)
> +PPS_TOOLS_DIR		:= $(BUILDDIR)/$(PPS_TOOLS)
> +PPS_TOOLS_LICENSE	:= GPL-2.0-or-later
> +PPS_TOOLS_LICENSE_FILES	:= \
> +	file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> +	file://ppsctl.c;startline=6;endline=14;md5=681a7c053fa782c41658ac9fc7dd1579
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +PPS_TOOLS_CONF_TOOL	:= NO
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +PPS_TOOLS_MAKE_ENV	:= $(CROSS_ENV)
> +
> +$(STATEDIR)/pps-tools.compile:
> +	@$(call targetinfo)
> +
> +	@# Everything depends on .depends, which is made by but also included
> +	@# in the Makefile, so make sure that "make install" does not rebuild
> +	@# everything
> +	@$(call compile, PPS_TOOLS, .depend)
> +	@$(call world/compile, PPS_TOOLS)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/pps-tools.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, pps-tools)
> +	@$(call install_fixup, pps-tools,PRIORITY,optional)
> +	@$(call install_fixup, pps-tools,SECTION,base)
> +	@$(call install_fixup, pps-tools,AUTHOR,"Daniel Glöckner <dg@emlix.com>")
> +	@$(call install_fixup, pps-tools,DESCRIPTION,missing)
> +
> +	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsfind)
> +	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppstest)
> +	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsctl)
> +	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppswatch)
> +	@$(call install_copy, pps-tools, 0, 0, 0755, -, /usr/bin/ppsldisc)
> +
> +	@$(call install_finish, pps-tools)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] chrony: enable support for PPS devices

[Michael Olbrich]

Thanks, applied as 2531a1942ed664e297bd2c17bcd25551d63fbd4e.

Michael

[sent from post-receive hook]

On Wed, 16 Jun 2021 12:35:23 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210604180715.4674-2-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/chrony.in b/rules/chrony.in
> index f50b864429b0..67a87277fc84 100644
> --- a/rules/chrony.in
> +++ b/rules/chrony.in
> @@ -8,6 +8,7 @@ menuconfig CHRONY
>  	select LIBCAP
>  	select LIBSECCOMP	if CHRONY_SECCOMP
>  	select NETTLE		if CHRONY_USE_NETTLE
> +	select PPS_TOOLS	if CHRONY_PPS_REFCLK
>  	help
>  	  This will install the Chrony NTPD Daemon (chronyd)
>  	  Chrony is a pair of programs which are used to maintain
> @@ -44,6 +45,13 @@ config CHRONY_ADVANCED_COMMAND
>  	  This allows getting advanced NTP time synchronization
>  	  status monitoring from the service.
>  
> +config CHRONY_PPS_REFCLK
> +	bool
> +	prompt "Enable support for PPS devices"
> +	help
> +	  Pulse per second devices signal the start of every second
> +	  with high precision.
> +
>  comment "install options   ---"
>  
>  config CHRONY_INSTALL_CHRONY_COMMAND
> diff --git a/rules/chrony.make b/rules/chrony.make
> index 7cf59f30560c..15f475d889a6 100644
> --- a/rules/chrony.make
> +++ b/rules/chrony.make
> @@ -52,7 +52,7 @@ CHRONY_CONF_OPT		:= \
>  	$(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
>  	--disable-refclock \
>  	--disable-phc \
> -	--disable-pps \
> +	$(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \
>  	$(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
>  	--with-user=chrony \
>  	$(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] chrony: fix typo

[Michael Olbrich]

Thanks, applied as fc52d78eee08a4d3659c9913f8b73ee0dd1a281f.

Michael

[sent from post-receive hook]

On Wed, 16 Jun 2021 12:35:24 +0200, Roland Hieber <rhi@pengutronix.de> wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20210604180715.4674-3-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/chrony.make b/rules/chrony.make
> index 15f475d889a6..4435b8e97796 100644
> --- a/rules/chrony.make
> +++ b/rules/chrony.make
> @@ -32,7 +32,7 @@ CHRONY_LICENSE_FILES	:= \
>  # ----------------------------------------------------------------------------
>  
>  #
> -# Chony is using a handcrafted configure script so normal ptx/endis
> +# Chrony is using a handcrafted configure script so normal ptx/endis
>  # and ptx/wwo are broken and causes "Unrecognized option".
>  # CROSS_AUTOCONF_USR is not used as that adds 3 unrecognized options:
>  # --libdir=, --build=, --host=

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices

[Ahmad Fatoum]

Hello Roland,

On 04.06.21 20:07, Roland Hieber wrote:
> diff --git a/rules/chrony.make b/rules/chrony.make
> index 7cf59f30560c..15f475d889a6 100644
> --- a/rules/chrony.make
> +++ b/rules/chrony.make
> @@ -52,7 +52,7 @@ CHRONY_CONF_OPT		:= \
>  	$(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
>  	--disable-refclock \
>  	--disable-phc \
> -	--disable-pps \
> +	$(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \

I don't see how this could have worked. As long as --disable-refclock is specified,
--disable-pps couldn't have had any effect:

https://gitlab.com/chrony/chrony/-/blob/master/configure?ref_type=heads#L773

Cheers,
Ahmad

>  	$(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
>  	--with-user=chrony \
>  	$(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices

[Roland Hieber]

On Wed, Jul 17, 2024 at 03:32:22PM +0200, Ahmad Fatoum wrote:
> Hello Roland,
> 
> On 04.06.21 20:07, Roland Hieber wrote:
> > diff --git a/rules/chrony.make b/rules/chrony.make
> > index 7cf59f30560c..15f475d889a6 100644
> > --- a/rules/chrony.make
> > +++ b/rules/chrony.make
> > @@ -52,7 +52,7 @@ CHRONY_CONF_OPT		:= \
> >  	$(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
> >  	--disable-refclock \
> >  	--disable-phc \
> > -	--disable-pps \
> > +	$(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \
> 
> I don't see how this could have worked. As long as --disable-refclock is specified,
> --disable-pps couldn't have had any effect:
> 
> https://gitlab.com/chrony/chrony/-/blob/master/configure?ref_type=heads#L773

Sorry, I don't remember my context for this patch anymore. Can you send
a patch?

 - Roland

> Cheers,
> Ahmad
> 
> >  	$(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
> >  	--with-user=chrony \
> >  	$(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |