From: Roland Hieber <rhi@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices
Date: Fri, 2 Aug 2024 14:04:56 +0200 [thread overview]
Message-ID: <20240802120456.yw7azws7kbtxyal6@pengutronix.de> (raw)
In-Reply-To: <7a05d1a2-30c0-4ef3-91d2-657842c8982d@pengutronix.de>
On Wed, Jul 17, 2024 at 03:32:22PM +0200, Ahmad Fatoum wrote:
> Hello Roland,
>
> On 04.06.21 20:07, Roland Hieber wrote:
> > diff --git a/rules/chrony.make b/rules/chrony.make
> > index 7cf59f30560c..15f475d889a6 100644
> > --- a/rules/chrony.make
> > +++ b/rules/chrony.make
> > @@ -52,7 +52,7 @@ CHRONY_CONF_OPT := \
> > $(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
> > --disable-refclock \
> > --disable-phc \
> > - --disable-pps \
> > + $(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \
>
> I don't see how this could have worked. As long as --disable-refclock is specified,
> --disable-pps couldn't have had any effect:
>
> https://gitlab.com/chrony/chrony/-/blob/master/configure?ref_type=heads#L773
Sorry, I don't remember my context for this patch anymore. Can you send
a patch?
- Roland
> Cheers,
> Ahmad
>
> > $(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \
> > --with-user=chrony \
> > $(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
>
>
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-08-02 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 18:07 [ptxdist] [PATCH v2 1/3] pps-tools: new package Roland Hieber
2021-06-04 18:07 ` [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices Roland Hieber
2021-06-16 10:35 ` [ptxdist] [APPLIED] " Michael Olbrich
2024-07-17 13:32 ` [ptxdist] [PATCH v2 2/3] " Ahmad Fatoum
2024-08-02 12:04 ` Roland Hieber [this message]
2021-06-04 18:07 ` [ptxdist] [PATCH v2 3/3] chrony: fix typo Roland Hieber
2021-06-16 10:35 ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-16 10:35 ` [ptxdist] [APPLIED] pps-tools: new package Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802120456.yw7azws7kbtxyal6@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox