From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Aug 2024 14:05:25 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZr2D-005SW1-09 for lore@lore.pengutronix.de; Fri, 02 Aug 2024 14:05:25 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZr2C-0002oU-NQ; Fri, 02 Aug 2024 14:05:24 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZr1k-0002oA-Tp; Fri, 02 Aug 2024 14:04:56 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZr1k-00402g-Gp; Fri, 02 Aug 2024 14:04:56 +0200 Received: from rhi by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sZr1k-00EuZh-1H; Fri, 02 Aug 2024 14:04:56 +0200 Date: Fri, 2 Aug 2024 14:04:56 +0200 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20240802120456.yw7azws7kbtxyal6@pengutronix.de> References: <20210604180715.4674-1-rhi@pengutronix.de> <20210604180715.4674-2-rhi@pengutronix.de> <7a05d1a2-30c0-4ef3-91d2-657842c8982d@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7a05d1a2-30c0-4ef3-91d2-657842c8982d@pengutronix.de> Subject: Re: [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Jul 17, 2024 at 03:32:22PM +0200, Ahmad Fatoum wrote: > Hello Roland, > > On 04.06.21 20:07, Roland Hieber wrote: > > diff --git a/rules/chrony.make b/rules/chrony.make > > index 7cf59f30560c..15f475d889a6 100644 > > --- a/rules/chrony.make > > +++ b/rules/chrony.make > > @@ -52,7 +52,7 @@ CHRONY_CONF_OPT := \ > > $(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \ > > --disable-refclock \ > > --disable-phc \ > > - --disable-pps \ > > + $(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \ > > I don't see how this could have worked. As long as --disable-refclock is specified, > --disable-pps couldn't have had any effect: > > https://gitlab.com/chrony/chrony/-/blob/master/configure?ref_type=heads#L773 Sorry, I don't remember my context for this patch anymore. Can you send a patch? - Roland > Cheers, > Ahmad > > > $(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \ > > --with-user=chrony \ > > $(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \ > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |