From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 17 Jul 2024 15:32:44 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sU4lw-000BaJ-0U for lore@lore.pengutronix.de; Wed, 17 Jul 2024 15:32:44 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sU4lv-0002zD-BF; Wed, 17 Jul 2024 15:32:43 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sU4la-0002yz-H7; Wed, 17 Jul 2024 15:32:22 +0200 Message-ID: <7a05d1a2-30c0-4ef3-91d2-657842c8982d@pengutronix.de> Date: Wed, 17 Jul 2024 15:32:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ptxdist@pengutronix.de, Roland Hieber References: <20210604180715.4674-1-rhi@pengutronix.de> <20210604180715.4674-2-rhi@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20210604180715.4674-2-rhi@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [ptxdist] [PATCH v2 2/3] chrony: enable support for PPS devices X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Roland, On 04.06.21 20:07, Roland Hieber wrote: > diff --git a/rules/chrony.make b/rules/chrony.make > index 7cf59f30560c..15f475d889a6 100644 > --- a/rules/chrony.make > +++ b/rules/chrony.make > @@ -52,7 +52,7 @@ CHRONY_CONF_OPT := \ > $(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \ > --disable-refclock \ > --disable-phc \ > - --disable-pps \ > + $(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,,--disable-pps) \ I don't see how this could have worked. As long as --disable-refclock is specified, --disable-pps couldn't have had any effect: https://gitlab.com/chrony/chrony/-/blob/master/configure?ref_type=heads#L773 Cheers, Ahmad > $(call ptx/ifdef, PTXCONF_GLOBAL_IPV6,,--disable-ipv6) \ > --with-user=chrony \ > $(call ptx/ifdef, PTXCONF_CHRONY_SECCOMP,--enable-scfilter,) \ -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |