* [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD
@ 2022-08-03 4:56 Bruno Thomsen
2022-08-04 15:23 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Bruno Thomsen @ 2022-08-03 4:56 UTC (permalink / raw)
To: ptxdist; +Cc: Bruno Thomsen
dbus-glib is a deprecated D-Bus binding for GLib.
https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README
Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated
component in systemd based image.
Doing a total clean and prepare/compile of this package in a systemd
based image provides all needed dependencies. And tpm2-abrmd.service
is running just fine.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
rules/tpm2-abrmd.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
index 1ab0a6a7fe0e..fda6e746432b 100644
--- a/rules/tpm2-abrmd.in
+++ b/rules/tpm2-abrmd.in
@@ -6,7 +6,7 @@ config TPM2_ABRMD
select DBUS
select GLIB
select TPM2_TSS
- select HOST_DBUS_GLIB
+ select HOST_DBUS_GLIB if INITMETHOD_BBINIT
prompt "tpm2-abrmd"
help
TPM2 Access Broker & Resource Management Daemon implementing
base-commit: faf247a8448d4d9caae487beb54d285ac3a6a1b8
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD
2022-08-03 4:56 [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD Bruno Thomsen
@ 2022-08-04 15:23 ` Michael Olbrich
2022-08-05 19:53 ` Bruno Thomsen
0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2022-08-04 15:23 UTC (permalink / raw)
To: Bruno Thomsen; +Cc: ptxdist
On Wed, Aug 03, 2022 at 06:56:55AM +0200, Bruno Thomsen wrote:
> dbus-glib is a deprecated D-Bus binding for GLib.
> https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README
>
> Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated
> component in systemd based image.
> Doing a total clean and prepare/compile of this package in a systemd
> based image provides all needed dependencies. And tpm2-abrmd.service
> is running just fine.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> rules/tpm2-abrmd.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
> index 1ab0a6a7fe0e..fda6e746432b 100644
> --- a/rules/tpm2-abrmd.in
> +++ b/rules/tpm2-abrmd.in
> @@ -6,7 +6,7 @@ config TPM2_ABRMD
> select DBUS
> select GLIB
> select TPM2_TSS
> - select HOST_DBUS_GLIB
> + select HOST_DBUS_GLIB if INITMETHOD_BBINIT
Hmm, did you see anything where this is needed for INITMETHOD_BBINIT? From
what I can tell, nothing refers to dbus-glib any more in the current
version.
Michael
> prompt "tpm2-abrmd"
> help
> TPM2 Access Broker & Resource Management Daemon implementing
>
> base-commit: faf247a8448d4d9caae487beb54d285ac3a6a1b8
> --
> 2.37.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD
2022-08-04 15:23 ` Michael Olbrich
@ 2022-08-05 19:53 ` Bruno Thomsen
2022-08-09 7:11 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Bruno Thomsen @ 2022-08-05 19:53 UTC (permalink / raw)
To: Bruno Thomsen, ptxdist
Den tor. 4. aug. 2022 kl. 17.23 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Wed, Aug 03, 2022 at 06:56:55AM +0200, Bruno Thomsen wrote:
> > dbus-glib is a deprecated D-Bus binding for GLib.
> > https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README
> >
> > Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated
> > component in systemd based image.
> > Doing a total clean and prepare/compile of this package in a systemd
> > based image provides all needed dependencies. And tpm2-abrmd.service
> > is running just fine.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> > rules/tpm2-abrmd.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
> > index 1ab0a6a7fe0e..fda6e746432b 100644
> > --- a/rules/tpm2-abrmd.in
> > +++ b/rules/tpm2-abrmd.in
> > @@ -6,7 +6,7 @@ config TPM2_ABRMD
> > select DBUS
> > select GLIB
> > select TPM2_TSS
> > - select HOST_DBUS_GLIB
> > + select HOST_DBUS_GLIB if INITMETHOD_BBINIT
>
> Hmm, did you see anything where this is needed for INITMETHOD_BBINIT? From
> what I can tell, nothing refers to dbus-glib any more in the current
> version.
No, I was just unable to compile/runtime test it on a BBINIT based
system as the one
I have was failing due to some other issue with DBUS (ptxdist
2017.10.0 with lots of
rules backporting). So I just wanted to make sure I did not break this
package for
other BBINIT users, but I can send a v2 where we just unconditionally drop this
compile dependency.
/Bruno
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD
2022-08-05 19:53 ` Bruno Thomsen
@ 2022-08-09 7:11 ` Michael Olbrich
0 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2022-08-09 7:11 UTC (permalink / raw)
To: Bruno Thomsen; +Cc: ptxdist
On Fri, Aug 05, 2022 at 09:53:46PM +0200, Bruno Thomsen wrote:
> Den tor. 4. aug. 2022 kl. 17.23 skrev Michael Olbrich
> <m.olbrich@pengutronix.de>:
> >
> > On Wed, Aug 03, 2022 at 06:56:55AM +0200, Bruno Thomsen wrote:
> > > dbus-glib is a deprecated D-Bus binding for GLib.
> > > https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README
> > >
> > > Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated
> > > component in systemd based image.
> > > Doing a total clean and prepare/compile of this package in a systemd
> > > based image provides all needed dependencies. And tpm2-abrmd.service
> > > is running just fine.
> > >
> > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > > ---
> > > rules/tpm2-abrmd.in | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
> > > index 1ab0a6a7fe0e..fda6e746432b 100644
> > > --- a/rules/tpm2-abrmd.in
> > > +++ b/rules/tpm2-abrmd.in
> > > @@ -6,7 +6,7 @@ config TPM2_ABRMD
> > > select DBUS
> > > select GLIB
> > > select TPM2_TSS
> > > - select HOST_DBUS_GLIB
> > > + select HOST_DBUS_GLIB if INITMETHOD_BBINIT
> >
> > Hmm, did you see anything where this is needed for INITMETHOD_BBINIT? From
> > what I can tell, nothing refers to dbus-glib any more in the current
> > version.
>
> No, I was just unable to compile/runtime test it on a BBINIT based
> system as the one
> I have was failing due to some other issue with DBUS (ptxdist
> 2017.10.0 with lots of
> rules backporting). So I just wanted to make sure I did not break this
> package for
> other BBINIT users, but I can send a v2 where we just unconditionally drop this
> compile dependency.
Yes, please send a v2 like that.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-09 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 4:56 [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD Bruno Thomsen
2022-08-04 15:23 ` Michael Olbrich
2022-08-05 19:53 ` Bruno Thomsen
2022-08-09 7:11 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox