From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 09 Aug 2022 09:11:41 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oLJOt-00H2qp-OJ for lore@lore.pengutronix.de; Tue, 09 Aug 2022 09:11:41 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oLJOv-00040B-5S; Tue, 09 Aug 2022 09:11:41 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLJOH-0003za-Cb; Tue, 09 Aug 2022 09:11:01 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oLJOH-0005Ke-3x; Tue, 09 Aug 2022 09:11:01 +0200 Date: Tue, 9 Aug 2022 09:11:01 +0200 From: Michael Olbrich To: Bruno Thomsen Message-ID: <20220809071101.GA28333@pengutronix.de> Mail-Followup-To: Bruno Thomsen , ptxdist@pengutronix.de References: <20220803045655.4095-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Aug 05, 2022 at 09:53:46PM +0200, Bruno Thomsen wrote: > Den tor. 4. aug. 2022 kl. 17.23 skrev Michael Olbrich > : > > > > On Wed, Aug 03, 2022 at 06:56:55AM +0200, Bruno Thomsen wrote: > > > dbus-glib is a deprecated D-Bus binding for GLib. > > > https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README > > > > > > Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated > > > component in systemd based image. > > > Doing a total clean and prepare/compile of this package in a systemd > > > based image provides all needed dependencies. And tpm2-abrmd.service > > > is running just fine. > > > > > > Signed-off-by: Bruno Thomsen > > > --- > > > rules/tpm2-abrmd.in | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in > > > index 1ab0a6a7fe0e..fda6e746432b 100644 > > > --- a/rules/tpm2-abrmd.in > > > +++ b/rules/tpm2-abrmd.in > > > @@ -6,7 +6,7 @@ config TPM2_ABRMD > > > select DBUS > > > select GLIB > > > select TPM2_TSS > > > - select HOST_DBUS_GLIB > > > + select HOST_DBUS_GLIB if INITMETHOD_BBINIT > > > > Hmm, did you see anything where this is needed for INITMETHOD_BBINIT? From > > what I can tell, nothing refers to dbus-glib any more in the current > > version. > > No, I was just unable to compile/runtime test it on a BBINIT based > system as the one > I have was failing due to some other issue with DBUS (ptxdist > 2017.10.0 with lots of > rules backporting). So I just wanted to make sure I did not break this > package for > other BBINIT users, but I can send a v2 where we just unconditionally drop this > compile dependency. Yes, please send a v2 like that. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |