Re: [ptxdist] [PATCH] tpm2-abrmd: change host dependencies based on INITMETHOD

[Bruno Thomsen <bruno.thomsen@gmail.com>]

Den tor. 4. aug. 2022 kl. 17.23 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Wed, Aug 03, 2022 at 06:56:55AM +0200, Bruno Thomsen wrote:
> > dbus-glib is a deprecated D-Bus binding for GLib.
> > https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/master/README
> >
> > Only use HOST_DBUS_GLIB with BBINIT to avoid pulling in a deprecated
> > component in systemd based image.
> > Doing a total clean and prepare/compile of this package in a systemd
> > based image provides all needed dependencies. And tpm2-abrmd.service
> > is running just fine.
> >
> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> >  rules/tpm2-abrmd.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/tpm2-abrmd.in b/rules/tpm2-abrmd.in
> > index 1ab0a6a7fe0e..fda6e746432b 100644
> > --- a/rules/tpm2-abrmd.in
> > +++ b/rules/tpm2-abrmd.in
> > @@ -6,7 +6,7 @@ config TPM2_ABRMD
> >       select DBUS
> >       select GLIB
> >       select TPM2_TSS
> > -     select HOST_DBUS_GLIB
> > +     select HOST_DBUS_GLIB           if INITMETHOD_BBINIT
>
> Hmm, did you see anything where this is needed for INITMETHOD_BBINIT? From
> what I can tell, nothing refers to dbus-glib any more in the current
> version.

No, I was just unable to compile/runtime test it on a BBINIT based
system as the one
I have was failing due to some other issue with DBUS (ptxdist
2017.10.0 with lots of
rules backporting). So I just wanted to make sure I did not break this
package for
other BBINIT users, but I can send a v2 where we just unconditionally drop this
compile dependency.

/Bruno