[ptxdist] [PATCH 0/3] libcamera: version bump 0.0.5 -> 0.2.0

[ptxdist] [PATCH 0/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Riesch]

Habidere,

This series features a long overdue libcamera version bump to v0.2.0
along a pipewire version bump that is required due to a API breakage.

Looking forward to your comments!

---
Michael Riesch (3):
      libcamera: switch to canonical tarball repository
      libcamera: version bump 0.0.5 -> 0.2.0
      pipewire: version bump 1.0.1 -> 1.0.3

 rules/libcamera.make | 6 +++---
 rules/pipewire.make  | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)
---
base-commit: 6bf08f784b8d41b63ba1d322e79145ad670b09e2
change-id: 20240305-feature-libcamera-0-2-0-5cc0ab00b499

Best regards,
-- 
Michael Riesch <michael.riesch@wolfvision.net>

[ptxdist] [PATCH 1/3] libcamera: switch to canonical tarball repository

[Michael Riesch]

As discussed with Kieran Bingham, one of the maintainers of libcamera,
the gitlab.freedesktop.org repository should serve as canonical tarball
repository.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 rules/libcamera.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/libcamera.make b/rules/libcamera.make
index 2419e2d86..928a95654 100644
--- a/rules/libcamera.make
+++ b/rules/libcamera.make
@@ -18,7 +18,7 @@ LIBCAMERA_VERSION	:= 0.0.5
 LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
 LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
 LIBCAMERA_SUFFIX	:= tar.gz
-LIBCAMERA_URL		:= https://git.libcamera.org/libcamera/libcamera.git;tag=v$(LIBCAMERA_VERSION)
+LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
 LIBCAMERA_SOURCE	:= $(SRCDIR)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
 LIBCAMERA_DIR		:= $(BUILDDIR)/$(LIBCAMERA)
 LIBCAMERA_LICENSE	:= Apache-2.0 AND \

-- 
2.34.1

Re: [ptxdist] [PATCH 1/3] libcamera: switch to canonical tarball repository

[Kieran Bingham]

Quoting Michael Riesch (2024-03-05 10:51:34)
> As discussed with Kieran Bingham, one of the maintainers of libcamera,
> the gitlab.freedesktop.org repository should serve as canonical tarball
> repository.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>

Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  rules/libcamera.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/libcamera.make b/rules/libcamera.make
> index 2419e2d86..928a95654 100644
> --- a/rules/libcamera.make
> +++ b/rules/libcamera.make
> @@ -18,7 +18,7 @@ LIBCAMERA_VERSION     := 0.0.5
>  LIBCAMERA_MD5          := cc2f5c0c051319a7e853dc6916807ce5
>  LIBCAMERA              := libcamera-$(LIBCAMERA_VERSION)
>  LIBCAMERA_SUFFIX       := tar.gz
> -LIBCAMERA_URL          := https://git.libcamera.org/libcamera/libcamera.git;tag=v$(LIBCAMERA_VERSION)
> +LIBCAMERA_URL          := https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>  LIBCAMERA_SOURCE       := $(SRCDIR)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>  LIBCAMERA_DIR          := $(BUILDDIR)/$(LIBCAMERA)
>  LIBCAMERA_LICENSE      := Apache-2.0 AND \
> 
> -- 
> 2.34.1
>

Re: [ptxdist] [APPLIED] libcamera: switch to canonical tarball repository

[Michael Olbrich]

Thanks, applied as 62bb1cfb2413d621b4eee4cc90e9e861e15e225e.

Michael

[sent from post-receive hook]

On Fri, 15 Mar 2024 05:06:27 +0100, Michael Riesch <michael.riesch@wolfvision.net> wrote:
> As discussed with Kieran Bingham, one of the maintainers of libcamera,
> the gitlab.freedesktop.org repository should serve as canonical tarball
> repository.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Message-Id: <20240305-feature-libcamera-0-2-0-v1-1-0625f2fd9dc6@wolfvision.net>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libcamera.make b/rules/libcamera.make
> index 2419e2d86072..928a95654d56 100644
> --- a/rules/libcamera.make
> +++ b/rules/libcamera.make
> @@ -18,7 +18,7 @@ LIBCAMERA_VERSION	:= 0.0.5
>  LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
>  LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
>  LIBCAMERA_SUFFIX	:= tar.gz
> -LIBCAMERA_URL		:= https://git.libcamera.org/libcamera/libcamera.git;tag=v$(LIBCAMERA_VERSION)
> +LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>  LIBCAMERA_SOURCE	:= $(SRCDIR)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>  LIBCAMERA_DIR		:= $(BUILDDIR)/$(LIBCAMERA)
>  LIBCAMERA_LICENSE	:= Apache-2.0 AND \

[ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Riesch]

Due to an API breakage in libcamera it may be necessary to update the
consumers of the library. One example is pipewire, which needs to be
updated to at least 1.0.2.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 rules/libcamera.make | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/libcamera.make b/rules/libcamera.make
index 928a95654..c9c4e2055 100644
--- a/rules/libcamera.make
+++ b/rules/libcamera.make
@@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
 #
 # Paths and names
 #
-LIBCAMERA_VERSION	:= 0.0.5
-LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
+LIBCAMERA_VERSION	:= 0.2.0
+LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5
 LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
 LIBCAMERA_SUFFIX	:= tar.gz
 LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)

-- 
2.34.1

Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Tretter]

On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote:
> Due to an API breakage in libcamera it may be necessary to update the
> consumers of the library. One example is pipewire, which needs to be
> updated to at least 1.0.2.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
>  rules/libcamera.make | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/libcamera.make b/rules/libcamera.make
> index 928a95654..c9c4e2055 100644
> --- a/rules/libcamera.make
> +++ b/rules/libcamera.make
> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
>  #
>  # Paths and names
>  #
> -LIBCAMERA_VERSION	:= 0.0.5
> -LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
> +LIBCAMERA_VERSION	:= 0.2.0
> +LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5

There is a new feature flag for udev support, which should be set
explicitly.

Michael

>  LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
>  LIBCAMERA_SUFFIX	:= tar.gz
>  LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
> 
> -- 
> 2.34.1
> 
> 
> 

Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Riesch]

Hi Michael,

Sorry for the long silence...

On 3/5/24 19:35, Michael Tretter wrote:
> On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote:
>> Due to an API breakage in libcamera it may be necessary to update the
>> consumers of the library. One example is pipewire, which needs to be
>> updated to at least 1.0.2.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  rules/libcamera.make | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/rules/libcamera.make b/rules/libcamera.make
>> index 928a95654..c9c4e2055 100644
>> --- a/rules/libcamera.make
>> +++ b/rules/libcamera.make
>> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
>>  #
>>  # Paths and names
>>  #
>> -LIBCAMERA_VERSION	:= 0.0.5
>> -LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
>> +LIBCAMERA_VERSION	:= 0.2.0
>> +LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5
> 
> There is a new feature flag for udev support, which should be set
> explicitly.

Hm. Why? Do you want to disable udev support explicitly?

libcamera commit d314d3b9 ("libcamera: Add option to configure udev
support") introduces the meson option but sets its default to "auto". If
libudev is found (and it should be found, as LIBCAMERA selects
UDEV_LIBUDEV) the new feature "Hotplug support" is enabled. As stated in
the commit message of d314d3b9, the behavior is not changed by this commit.

If one would like to disable udev support explicitly, we would need to
introduce a ptxdist option, pass it to meson, and make the dependency on
 UDEV_LIBUDEV conditional. But personally I don't see any value in that.

Best regards,
Michael

> 
> Michael
> 
>>  LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
>>  LIBCAMERA_SUFFIX	:= tar.gz
>>  LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>>
>> -- 
>> 2.34.1
>>
>>
>>

Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Olbrich]

On Tue, May 14, 2024 at 04:34:25PM +0200, Michael Riesch wrote:
> Hi Michael,
> 
> Sorry for the long silence...
> 
> On 3/5/24 19:35, Michael Tretter wrote:
> > On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote:
> >> Due to an API breakage in libcamera it may be necessary to update the
> >> consumers of the library. One example is pipewire, which needs to be
> >> updated to at least 1.0.2.
> >>
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >>  rules/libcamera.make | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/rules/libcamera.make b/rules/libcamera.make
> >> index 928a95654..c9c4e2055 100644
> >> --- a/rules/libcamera.make
> >> +++ b/rules/libcamera.make
> >> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
> >>  #
> >>  # Paths and names
> >>  #
> >> -LIBCAMERA_VERSION	:= 0.0.5
> >> -LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
> >> +LIBCAMERA_VERSION	:= 0.2.0
> >> +LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5
> > 
> > There is a new feature flag for udev support, which should be set
> > explicitly.
> 
> Hm. Why? Do you want to disable udev support explicitly?
> 
> libcamera commit d314d3b9 ("libcamera: Add option to configure udev
> support") introduces the meson option but sets its default to "auto". If
> libudev is found (and it should be found, as LIBCAMERA selects
> UDEV_LIBUDEV) the new feature "Hotplug support" is enabled. As stated in
> the commit message of d314d3b9, the behavior is not changed by this commit.
> 
> If one would like to disable udev support explicitly, we would need to
> introduce a ptxdist option, pass it to meson, and make the dependency on
>  UDEV_LIBUDEV conditional. But personally I don't see any value in that.

'set explicitly' as in 'enable it explicitly'. This way, the build will
fail if udev is not detected correctly for some reason.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Riesch]

Hi mol,

On 5/14/24 18:15, Michael Olbrich wrote:
> On Tue, May 14, 2024 at 04:34:25PM +0200, Michael Riesch wrote:
>> Hi Michael,
>>
>> Sorry for the long silence...
>>
>> On 3/5/24 19:35, Michael Tretter wrote:
>>> On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote:
>>>> Due to an API breakage in libcamera it may be necessary to update the
>>>> consumers of the library. One example is pipewire, which needs to be
>>>> updated to at least 1.0.2.
>>>>
>>>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>>>> ---
>>>>  rules/libcamera.make | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/rules/libcamera.make b/rules/libcamera.make
>>>> index 928a95654..c9c4e2055 100644
>>>> --- a/rules/libcamera.make
>>>> +++ b/rules/libcamera.make
>>>> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
>>>>  #
>>>>  # Paths and names
>>>>  #
>>>> -LIBCAMERA_VERSION	:= 0.0.5
>>>> -LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
>>>> +LIBCAMERA_VERSION	:= 0.2.0
>>>> +LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5
>>>
>>> There is a new feature flag for udev support, which should be set
>>> explicitly.
>>
>> Hm. Why? Do you want to disable udev support explicitly?
>>
>> libcamera commit d314d3b9 ("libcamera: Add option to configure udev
>> support") introduces the meson option but sets its default to "auto". If
>> libudev is found (and it should be found, as LIBCAMERA selects
>> UDEV_LIBUDEV) the new feature "Hotplug support" is enabled. As stated in
>> the commit message of d314d3b9, the behavior is not changed by this commit.
>>
>> If one would like to disable udev support explicitly, we would need to
>> introduce a ptxdist option, pass it to meson, and make the dependency on
>>  UDEV_LIBUDEV conditional. But personally I don't see any value in that.
> 
> 'set explicitly' as in 'enable it explicitly'. This way, the build will
> fail if udev is not detected correctly for some reason.

Ah, got it. Thanks for the clarification.

v2 should have hit your mailbox by now. It still contains the update to
pipewire 1.0.3, although 1.0.6 has been released recently. However,
let's do this step by step, please -> this update is simply to handle
libcamera's API breakage.

Regards, Michael

> 
> Michael
> 

[ptxdist] [PATCH 3/3] pipewire: version bump 1.0.1 -> 1.0.3

[Michael Riesch]

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 rules/pipewire.make | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/pipewire.make b/rules/pipewire.make
index 8747ebe6c..322ae70a1 100644
--- a/rules/pipewire.make
+++ b/rules/pipewire.make
@@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_PIPEWIRE) += pipewire
 #
 # Paths and names
 #
-PIPEWIRE_VERSION	:= 1.0.1
-PIPEWIRE_MD5		:= d70bde8000d62df6c03c6dd928ab8948
+PIPEWIRE_VERSION	:= 1.0.3
+PIPEWIRE_MD5		:= 92eb16fb925aa9dc9191d8ef7b04687d
 PIPEWIRE		:= pipewire-$(PIPEWIRE_VERSION)
 PIPEWIRE_SUFFIX		:= tar.bz2
 PIPEWIRE_URL		:= https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/$(PIPEWIRE_VERSION)/$(PIPEWIRE).$(PIPEWIRE_SUFFIX)

-- 
2.34.1