From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 14 May 2024 18:15:39 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s6uoV-00ETV4-2A for lore@lore.pengutronix.de; Tue, 14 May 2024 18:15:39 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s6uoU-0002Fq-VW; Tue, 14 May 2024 18:15:38 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6uoC-0002FZ-Kv; Tue, 14 May 2024 18:15:20 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6uoB-001O0y-Ve; Tue, 14 May 2024 18:15:19 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1s6uoB-00BJdt-2t; Tue, 14 May 2024 18:15:19 +0200 Date: Tue, 14 May 2024 18:15:19 +0200 From: Michael Olbrich To: Michael Riesch Message-ID: Mail-Followup-To: Michael Riesch , Michael Tretter , ptxdist@pengutronix.de, Kieran Bingham References: <20240305-feature-libcamera-0-2-0-v1-0-0625f2fd9dc6@wolfvision.net> <20240305-feature-libcamera-0-2-0-v1-2-0625f2fd9dc6@wolfvision.net> <1fd16532-aa1c-45f2-adf1-ff2d24003efd@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fd16532-aa1c-45f2-adf1-ff2d24003efd@wolfvision.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, Michael Tretter , Kieran Bingham Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, May 14, 2024 at 04:34:25PM +0200, Michael Riesch wrote: > Hi Michael, > > Sorry for the long silence... > > On 3/5/24 19:35, Michael Tretter wrote: > > On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote: > >> Due to an API breakage in libcamera it may be necessary to update the > >> consumers of the library. One example is pipewire, which needs to be > >> updated to at least 1.0.2. > >> > >> Signed-off-by: Michael Riesch > >> --- > >> rules/libcamera.make | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/rules/libcamera.make b/rules/libcamera.make > >> index 928a95654..c9c4e2055 100644 > >> --- a/rules/libcamera.make > >> +++ b/rules/libcamera.make > >> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera > >> # > >> # Paths and names > >> # > >> -LIBCAMERA_VERSION := 0.0.5 > >> -LIBCAMERA_MD5 := cc2f5c0c051319a7e853dc6916807ce5 > >> +LIBCAMERA_VERSION := 0.2.0 > >> +LIBCAMERA_MD5 := 08f0681221c654838e54e6b3a32f89b5 > > > > There is a new feature flag for udev support, which should be set > > explicitly. > > Hm. Why? Do you want to disable udev support explicitly? > > libcamera commit d314d3b9 ("libcamera: Add option to configure udev > support") introduces the meson option but sets its default to "auto". If > libudev is found (and it should be found, as LIBCAMERA selects > UDEV_LIBUDEV) the new feature "Hotplug support" is enabled. As stated in > the commit message of d314d3b9, the behavior is not changed by this commit. > > If one would like to disable udev support explicitly, we would need to > introduce a ptxdist option, pass it to meson, and make the dependency on > UDEV_LIBUDEV conditional. But personally I don't see any value in that. 'set explicitly' as in 'enable it explicitly'. This way, the build will fail if udev is not detected correctly for some reason. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |