Re: [ptxdist] [PATCH 2/3] libcamera: version bump 0.0.5 -> 0.2.0

[Michael Riesch <michael.riesch@wolfvision.net>]

Hi Michael,

Sorry for the long silence...

On 3/5/24 19:35, Michael Tretter wrote:
> On Tue, 05 Mar 2024 11:51:35 +0100, Michael Riesch wrote:
>> Due to an API breakage in libcamera it may be necessary to update the
>> consumers of the library. One example is pipewire, which needs to be
>> updated to at least 1.0.2.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  rules/libcamera.make | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/rules/libcamera.make b/rules/libcamera.make
>> index 928a95654..c9c4e2055 100644
>> --- a/rules/libcamera.make
>> +++ b/rules/libcamera.make
>> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_LIBCAMERA) += libcamera
>>  #
>>  # Paths and names
>>  #
>> -LIBCAMERA_VERSION	:= 0.0.5
>> -LIBCAMERA_MD5		:= cc2f5c0c051319a7e853dc6916807ce5
>> +LIBCAMERA_VERSION	:= 0.2.0
>> +LIBCAMERA_MD5		:= 08f0681221c654838e54e6b3a32f89b5
> 
> There is a new feature flag for udev support, which should be set
> explicitly.

Hm. Why? Do you want to disable udev support explicitly?

libcamera commit d314d3b9 ("libcamera: Add option to configure udev
support") introduces the meson option but sets its default to "auto". If
libudev is found (and it should be found, as LIBCAMERA selects
UDEV_LIBUDEV) the new feature "Hotplug support" is enabled. As stated in
the commit message of d314d3b9, the behavior is not changed by this commit.

If one would like to disable udev support explicitly, we would need to
introduce a ptxdist option, pass it to meson, and make the dependency on
 UDEV_LIBUDEV conditional. But personally I don't see any value in that.

Best regards,
Michael

> 
> Michael
> 
>>  LIBCAMERA		:= libcamera-$(LIBCAMERA_VERSION)
>>  LIBCAMERA_SUFFIX	:= tar.gz
>>  LIBCAMERA_URL		:= https://gitlab.freedesktop.org/camera/libcamera/-/archive/v$(LIBCAMERA_VERSION)/$(LIBCAMERA).$(LIBCAMERA_SUFFIX)
>>
>> -- 
>> 2.34.1
>>
>>
>>