* [ptxdist] [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols.
@ 2022-01-28 12:26 Christian Melki
2022-02-04 18:08 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Christian Melki @ 2022-01-28 12:26 UTC (permalink / raw)
To: ptxdist
The Linux kconfig has removed a warning regarding unassigned symbols.
Commit f072181e6403b0fe2e2aa800a005497b748fd284,
kconfig: drop the ""trying to assign nonexistent symbol" warning.
This warning actually helps detecting symbol renames which are lost in
translation which in turn is helpful when doing oldconfigs etc.
Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
scripts/kconfig/confdata.c | 5 ++-
...add-warning-about-unassigned-symbols.patch | 43 +++++++++++++++++++
scripts/ptx-modifications/series | 1 +
3 files changed, 48 insertions(+), 1 deletion(-)
create mode 100644 scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index c5f4b552b..09777fdfe 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -426,6 +426,7 @@ load:
if (def == S_DEF_USER) {
sym = sym_find(line + 2 + strlen(CONFIG_));
if (!sym) {
+ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
sym_add_change_count(1);
continue;
}
@@ -468,8 +469,10 @@ load:
* include/config/foo.h must be touched.
*/
conf_touch_dep(line + strlen(CONFIG_));
- else
+ else {
+ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
sym_add_change_count(1);
+ }
continue;
}
diff --git a/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
new file mode 100644
index 000000000..ec2e44c33
--- /dev/null
+++ b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
@@ -0,0 +1,43 @@
+From: Christian Melki <christian.melki@t2data.com>
+Date: Fri, 28 Jan 2022 13:15:42 +0100
+Subject: [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols.
+
+The Linux kconfig has removed a warning regarding unassigned symbols.
+Commit f072181e6403b0fe2e2aa800a005497b748fd284,
+kconfig: drop the ""trying to assign nonexistent symbol" warning.
+
+This warning actually helps detecting symbol renames which are lost in
+translation which in turn is helpful when doing oldconfigs etc.
+
+Signed-off-by: Christian Melki <christian.melki@t2data.com>
+---
+ scripts/kconfig/confdata.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
+index c5f4b552b..09777fdfe 100644
+--- a/scripts/kconfig/confdata.c
++++ b/scripts/kconfig/confdata.c
+@@ -426,6 +426,7 @@ load:
+ if (def == S_DEF_USER) {
+ sym = sym_find(line + 2 + strlen(CONFIG_));
+ if (!sym) {
++ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
+ sym_add_change_count(1);
+ continue;
+ }
+@@ -468,8 +469,10 @@ load:
+ * include/config/foo.h must be touched.
+ */
+ conf_touch_dep(line + strlen(CONFIG_));
+- else
++ else {
++ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
+ sym_add_change_count(1);
++ }
+ continue;
+ }
+
+--
+2.30.2
+
diff --git a/scripts/ptx-modifications/series b/scripts/ptx-modifications/series
index 73257cc7b..c142d998f 100644
--- a/scripts/ptx-modifications/series
+++ b/scripts/ptx-modifications/series
@@ -9,3 +9,4 @@
0005-nconf-remove-special-P_COMMENT-output.patch
0006-mconf-fix-comment-on-exit.patch
0007-warnings-are-errors-unless-PTXDIST_FORCE-is-set.patch
+0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
--
2.30.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [ptxdist] [APPLIED] confdata.c: (Re-)add warning about unassigned symbols.
2022-01-28 12:26 [ptxdist] [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols Christian Melki
@ 2022-02-04 18:08 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2022-02-04 18:08 UTC (permalink / raw)
To: ptxdist; +Cc: Christian Melki
Thanks, applied as 156566e18c7f781361e896f95512d43f3ebdfa27.
Michael
[sent from post-receive hook]
On Fri, 04 Feb 2022 19:08:41 +0100, Christian Melki <christian.melki@t2data.com> wrote:
> The Linux kconfig has removed a warning regarding unassigned symbols.
> Commit f072181e6403b0fe2e2aa800a005497b748fd284,
> kconfig: drop the ""trying to assign nonexistent symbol" warning.
>
> This warning actually helps detecting symbol renames which are lost in
> translation which in turn is helpful when doing oldconfigs etc.
>
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> Message-Id: <20220128122648.1855521-1-christian.melki@t2data.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index c5f4b552bb63..09777fdfe82c 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -426,6 +426,7 @@ load:
> if (def == S_DEF_USER) {
> sym = sym_find(line + 2 + strlen(CONFIG_));
> if (!sym) {
> + conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
> sym_add_change_count(1);
> continue;
> }
> @@ -468,8 +469,10 @@ load:
> * include/config/foo.h must be touched.
> */
> conf_touch_dep(line + strlen(CONFIG_));
> - else
> + else {
> + conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
> sym_add_change_count(1);
> + }
> continue;
> }
>
> diff --git a/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
> new file mode 100644
> index 000000000000..ec2e44c3392e
> --- /dev/null
> +++ b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
> @@ -0,0 +1,43 @@
> +From: Christian Melki <christian.melki@t2data.com>
> +Date: Fri, 28 Jan 2022 13:15:42 +0100
> +Subject: [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols.
> +
> +The Linux kconfig has removed a warning regarding unassigned symbols.
> +Commit f072181e6403b0fe2e2aa800a005497b748fd284,
> +kconfig: drop the ""trying to assign nonexistent symbol" warning.
> +
> +This warning actually helps detecting symbol renames which are lost in
> +translation which in turn is helpful when doing oldconfigs etc.
> +
> +Signed-off-by: Christian Melki <christian.melki@t2data.com>
> +---
> + scripts/kconfig/confdata.c | 5 ++++-
> + 1 file changed, 4 insertions(+), 1 deletion(-)
> +
> +diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> +index c5f4b552b..09777fdfe 100644
> +--- a/scripts/kconfig/confdata.c
> ++++ b/scripts/kconfig/confdata.c
> +@@ -426,6 +426,7 @@ load:
> + if (def == S_DEF_USER) {
> + sym = sym_find(line + 2 + strlen(CONFIG_));
> + if (!sym) {
> ++ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
> + sym_add_change_count(1);
> + continue;
> + }
> +@@ -468,8 +469,10 @@ load:
> + * include/config/foo.h must be touched.
> + */
> + conf_touch_dep(line + strlen(CONFIG_));
> +- else
> ++ else {
> ++ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
> + sym_add_change_count(1);
> ++ }
> + continue;
> + }
> +
> +--
> +2.30.2
> +
> diff --git a/scripts/ptx-modifications/series b/scripts/ptx-modifications/series
> index 73257cc7b767..c142d998f20e 100644
> --- a/scripts/ptx-modifications/series
> +++ b/scripts/ptx-modifications/series
> @@ -9,3 +9,4 @@
> 0005-nconf-remove-special-P_COMMENT-output.patch
> 0006-mconf-fix-comment-on-exit.patch
> 0007-warnings-are-errors-unless-PTXDIST_FORCE-is-set.patch
> +0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-04 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 12:26 [ptxdist] [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols Christian Melki
2022-02-04 18:08 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox