From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 04 Feb 2022 19:09:00 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nG312-005kO0-9o for lore@lore.pengutronix.de; Fri, 04 Feb 2022 19:09:00 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nG311-0002PW-DH; Fri, 04 Feb 2022 19:08:59 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nG30l-0002OC-T3; Fri, 04 Feb 2022 19:08:43 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nG30l-00EWi5-P2; Fri, 04 Feb 2022 19:08:43 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nG30k-00AB0O-6l; Fri, 04 Feb 2022 19:08:42 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 4 Feb 2022 19:08:42 +0100 Message-Id: <20220204180842.2425541-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220128122648.1855521-1-christian.melki@t2data.com> References: <20220128122648.1855521-1-christian.melki@t2data.com> MIME-Version: 1.0 Subject: Re: [ptxdist] [APPLIED] confdata.c: (Re-)add warning about unassigned symbols. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Christian Melki Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 156566e18c7f781361e896f95512d43f3ebdfa27. Michael [sent from post-receive hook] On Fri, 04 Feb 2022 19:08:41 +0100, Christian Melki wrote: > The Linux kconfig has removed a warning regarding unassigned symbols. > Commit f072181e6403b0fe2e2aa800a005497b748fd284, > kconfig: drop the ""trying to assign nonexistent symbol" warning. > > This warning actually helps detecting symbol renames which are lost in > translation which in turn is helpful when doing oldconfigs etc. > > Signed-off-by: Christian Melki > Message-Id: <20220128122648.1855521-1-christian.melki@t2data.com> > Signed-off-by: Michael Olbrich > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index c5f4b552bb63..09777fdfe82c 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -426,6 +426,7 @@ load: > if (def == S_DEF_USER) { > sym = sym_find(line + 2 + strlen(CONFIG_)); > if (!sym) { > + conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_)); > sym_add_change_count(1); > continue; > } > @@ -468,8 +469,10 @@ load: > * include/config/foo.h must be touched. > */ > conf_touch_dep(line + strlen(CONFIG_)); > - else > + else { > + conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_)); > sym_add_change_count(1); > + } > continue; > } > > diff --git a/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch > new file mode 100644 > index 000000000000..ec2e44c3392e > --- /dev/null > +++ b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch > @@ -0,0 +1,43 @@ > +From: Christian Melki > +Date: Fri, 28 Jan 2022 13:15:42 +0100 > +Subject: [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols. > + > +The Linux kconfig has removed a warning regarding unassigned symbols. > +Commit f072181e6403b0fe2e2aa800a005497b748fd284, > +kconfig: drop the ""trying to assign nonexistent symbol" warning. > + > +This warning actually helps detecting symbol renames which are lost in > +translation which in turn is helpful when doing oldconfigs etc. > + > +Signed-off-by: Christian Melki > +--- > + scripts/kconfig/confdata.c | 5 ++++- > + 1 file changed, 4 insertions(+), 1 deletion(-) > + > +diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > +index c5f4b552b..09777fdfe 100644 > +--- a/scripts/kconfig/confdata.c > ++++ b/scripts/kconfig/confdata.c > +@@ -426,6 +426,7 @@ load: > + if (def == S_DEF_USER) { > + sym = sym_find(line + 2 + strlen(CONFIG_)); > + if (!sym) { > ++ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_)); > + sym_add_change_count(1); > + continue; > + } > +@@ -468,8 +469,10 @@ load: > + * include/config/foo.h must be touched. > + */ > + conf_touch_dep(line + strlen(CONFIG_)); > +- else > ++ else { > ++ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_)); > + sym_add_change_count(1); > ++ } > + continue; > + } > + > +-- > +2.30.2 > + > diff --git a/scripts/ptx-modifications/series b/scripts/ptx-modifications/series > index 73257cc7b767..c142d998f20e 100644 > --- a/scripts/ptx-modifications/series > +++ b/scripts/ptx-modifications/series > @@ -9,3 +9,4 @@ > 0005-nconf-remove-special-P_COMMENT-output.patch > 0006-mconf-fix-comment-on-exit.patch > 0007-warnings-are-errors-unless-PTXDIST_FORCE-is-set.patch > +0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de