From: Christian Melki <christian.melki@t2data.com>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols.
Date: Fri, 28 Jan 2022 13:26:48 +0100 [thread overview]
Message-ID: <20220128122648.1855521-1-christian.melki@t2data.com> (raw)
The Linux kconfig has removed a warning regarding unassigned symbols.
Commit f072181e6403b0fe2e2aa800a005497b748fd284,
kconfig: drop the ""trying to assign nonexistent symbol" warning.
This warning actually helps detecting symbol renames which are lost in
translation which in turn is helpful when doing oldconfigs etc.
Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
scripts/kconfig/confdata.c | 5 ++-
...add-warning-about-unassigned-symbols.patch | 43 +++++++++++++++++++
scripts/ptx-modifications/series | 1 +
3 files changed, 48 insertions(+), 1 deletion(-)
create mode 100644 scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index c5f4b552b..09777fdfe 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -426,6 +426,7 @@ load:
if (def == S_DEF_USER) {
sym = sym_find(line + 2 + strlen(CONFIG_));
if (!sym) {
+ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
sym_add_change_count(1);
continue;
}
@@ -468,8 +469,10 @@ load:
* include/config/foo.h must be touched.
*/
conf_touch_dep(line + strlen(CONFIG_));
- else
+ else {
+ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
sym_add_change_count(1);
+ }
continue;
}
diff --git a/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
new file mode 100644
index 000000000..ec2e44c33
--- /dev/null
+++ b/scripts/ptx-modifications/0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
@@ -0,0 +1,43 @@
+From: Christian Melki <christian.melki@t2data.com>
+Date: Fri, 28 Jan 2022 13:15:42 +0100
+Subject: [PATCH v2] confdata.c: (Re-)add warning about unassigned symbols.
+
+The Linux kconfig has removed a warning regarding unassigned symbols.
+Commit f072181e6403b0fe2e2aa800a005497b748fd284,
+kconfig: drop the ""trying to assign nonexistent symbol" warning.
+
+This warning actually helps detecting symbol renames which are lost in
+translation which in turn is helpful when doing oldconfigs etc.
+
+Signed-off-by: Christian Melki <christian.melki@t2data.com>
+---
+ scripts/kconfig/confdata.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
+index c5f4b552b..09777fdfe 100644
+--- a/scripts/kconfig/confdata.c
++++ b/scripts/kconfig/confdata.c
+@@ -426,6 +426,7 @@ load:
+ if (def == S_DEF_USER) {
+ sym = sym_find(line + 2 + strlen(CONFIG_));
+ if (!sym) {
++ conf_warning("trying to assign nonexistent symbol %s", line + 2 + strlen(CONFIG_));
+ sym_add_change_count(1);
+ continue;
+ }
+@@ -468,8 +469,10 @@ load:
+ * include/config/foo.h must be touched.
+ */
+ conf_touch_dep(line + strlen(CONFIG_));
+- else
++ else {
++ conf_warning("trying to assign nonexistent symbol %s", line + strlen(CONFIG_));
+ sym_add_change_count(1);
++ }
+ continue;
+ }
+
+--
+2.30.2
+
diff --git a/scripts/ptx-modifications/series b/scripts/ptx-modifications/series
index 73257cc7b..c142d998f 100644
--- a/scripts/ptx-modifications/series
+++ b/scripts/ptx-modifications/series
@@ -9,3 +9,4 @@
0005-nconf-remove-special-P_COMMENT-output.patch
0006-mconf-fix-comment-on-exit.patch
0007-warnings-are-errors-unless-PTXDIST_FORCE-is-set.patch
+0009-confdata.c-Re-add-warning-about-unassigned-symbols.patch
--
2.30.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next reply other threads:[~2022-01-28 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 12:26 Christian Melki [this message]
2022-02-04 18:08 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128122648.1855521-1-christian.melki@t2data.com \
--to=christian.melki@t2data.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox