From: Philipp Zabel <p.zabel@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libkmod: version bump 27 -> 28
Date: Wed, 12 May 2021 08:25:37 +0200 [thread overview]
Message-ID: <e5873800e54b4a59da0d685ee895f1167fb6a9ea.camel@pengutronix.de> (raw)
In-Reply-To: <20210511154150.GE13402@pengutronix.de>
On Tue, 2021-05-11 at 17:41 +0200, Michael Olbrich wrote:
[...]
> > + select HOST_LIBKMOD if LIBKMOD_ZSTD
> >
> > > + select HOST_LIBKMOD_ZSTD if LIBKMOD_ZSTD
>
> Please align the 'if's.
Ok.
> > Would this be the correct way to enable Zstandard support in depmod
> > during kernel build?
>
> It's not easy to find when building the kernel fails, but I don't have a
> better idea either.
The build doesn't even fail without compression support in depmod.
modprobe will just fail to find any compressed modules at runtime.
> But please do the same thing for zlib support to make
> this consistent.
Will do, thanks.
regards
Philipp
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2021-05-12 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 10:19 Philipp Zabel
2021-05-11 8:08 ` Philipp Zabel
2021-05-11 15:41 ` Michael Olbrich
2021-05-12 6:25 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5873800e54b4a59da0d685ee895f1167fb6a9ea.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox