From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libkmod: version bump 27 -> 28
Date: Tue, 11 May 2021 17:41:50 +0200 [thread overview]
Message-ID: <20210511154150.GE13402@pengutronix.de> (raw)
In-Reply-To: <193759b9ef3300d7a2cabfec78ec618c3c87ddd8.camel@pengutronix.de>
On Tue, May 11, 2021 at 10:08:29AM +0200, Philipp Zabel wrote:
> On Mon, 2021-05-10 at 12:19 +0200, Philipp Zabel wrote:
> > - add Zstandard compression support, allows to enable the
> > kernel CONFIG_MODULE_COMPRESS_ZSTD option
> > - LIBKMOD_ZSTD selects HOST_LIBKMOD_ZSTD so depmod understands
> > Zstandard during kernel build
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > rules/host-libkmod.in | 8 ++++++++
> > rules/host-libkmod.make | 1 +
> > rules/libkmod.in | 8 ++++++++
> > rules/libkmod.make | 5 +++--
> > 4 files changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/rules/host-libkmod.in b/rules/host-libkmod.in
> > index dc03abc2a2ab..a32c0e353b19 100644
> > --- a/rules/host-libkmod.in
> > +++ b/rules/host-libkmod.in
> > @@ -2,4 +2,12 @@
> >
> > config HOST_LIBKMOD
> > tristate
> > + select HOST_ZSTD if HOST_LIBKMOD_ZSTD
> > default y if ALLYES
> > +
> > +if HOST_LIBKMOD
> > +
> > +config HOST_LIBKMOD_ZSTD
> > + bool
> > +
> > +endif
> > diff --git a/rules/host-libkmod.make b/rules/host-libkmod.make
> > index 57c8b2ecf9f9..1438eda33424 100644
> > --- a/rules/host-libkmod.make
> > +++ b/rules/host-libkmod.make
> > @@ -32,6 +32,7 @@ HOST_LIBKMOD_CONF_OPT := \
> > --disable-coverage \
> > --without-xz \
> > --without-zlib \
> > + --$(call ptx/wwo, PTXCONF_HOST_LIBKMOD_ZSTD)-zstd \
> > --without-openssl
> >
> > # ----------------------------------------------------------------------------
> > diff --git a/rules/libkmod.in b/rules/libkmod.in
> > index 1660f7c4b58b..80590a9d0d81 100644
> > --- a/rules/libkmod.in
> > +++ b/rules/libkmod.in
> > @@ -3,6 +3,8 @@
> > menuconfig LIBKMOD
> > tristate
> > select ZLIB if LIBKMOD_ZLIB
> > + select ZSTD if LIBKMOD_ZSTD
>
> Of course this is also missing:
>
> + select HOST_LIBKMOD if LIBKMOD_ZSTD
>
> > + select HOST_LIBKMOD_ZSTD if LIBKMOD_ZSTD
Please align the 'if's.
> Would this be the correct way to enable Zstandard support in depmod
> during kernel build?
It's not easy to find when building the kernel fails, but I don't have a
better idea either. But please do the same thing for zlib support to make
this consistent.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-05-11 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 10:19 Philipp Zabel
2021-05-11 8:08 ` Philipp Zabel
2021-05-11 15:41 ` Michael Olbrich [this message]
2021-05-12 6:25 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511154150.GE13402@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox