From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Wed, 12 May 2021 08:26:17 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1lgiK1-0005iA-Nx
	for lore@lore.pengutronix.de; Wed, 12 May 2021 08:26:17 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1lgiK1-0001Qm-H7; Wed, 12 May 2021 08:26:17 +0200
Received: from lupine.hi.pengutronix.de
 ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine)
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <p.zabel@pengutronix.de>) id 1lgiJN-0001QW-Cv
 for ptxdist@pengutronix.de; Wed, 12 May 2021 08:25:37 +0200
Received: from pza by lupine with local (Exim 4.92)
 (envelope-from <p.zabel@pengutronix.de>) id 1lgiJN-0006DR-3v
 for ptxdist@pengutronix.de; Wed, 12 May 2021 08:25:37 +0200
Message-ID: <e5873800e54b4a59da0d685ee895f1167fb6a9ea.camel@pengutronix.de>
From: Philipp Zabel <p.zabel@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Wed, 12 May 2021 08:25:37 +0200
In-Reply-To: <20210511154150.GE13402@pengutronix.de>
References: <20210510101948.12089-1-p.zabel@pengutronix.de>
 <193759b9ef3300d7a2cabfec78ec618c3c87ddd8.camel@pengutronix.de>
 <20210511154150.GE13402@pengutronix.de>
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Subject: Re: [ptxdist] [PATCH] libkmod: version bump 27 -> 28
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

On Tue, 2021-05-11 at 17:41 +0200, Michael Olbrich wrote:
[...]
> > +	select HOST_LIBKMOD if LIBKMOD_ZSTD
> > 
> > > +	select HOST_LIBKMOD_ZSTD if LIBKMOD_ZSTD
> 
> Please align the 'if's.

Ok.

> > Would this be the correct way to enable Zstandard support in depmod
> > during kernel build?
> 
> It's not easy to find when building the kernel fails, but I don't have a
> better idea either.

The build doesn't even fail without compression support in depmod.
modprobe will just fail to find any compressed modules at runtime.

> But please do the same thing for zlib support to make
> this consistent.

Will do, thanks.

regards
Philipp

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de