Re: [ptxdist] [PATCH 1/2] lvm2: make libaio dependency conditional

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jun 30, 2026 at 06:01:56PM +0200, Sven Püschel wrote:
> When only using the device-mapper related part of lvm2, libaio is not
> required. This requires us to only use the [install_]device-mapper
> make targets to avoid trying to compile the lvm2 tools, which depend on
> libaio.
> 
> Also move the lvm2 configuration file to the LVM_TOOLS option, as it
> won't be built by the device-mapper target and doesn't seem to be
> relevant for dmsetup alone.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> ---
>  rules/lvm2.in   | 2 +-
>  rules/lvm2.make | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/lvm2.in b/rules/lvm2.in
> index f0b8123fc..dc1724ecc 100644
> --- a/rules/lvm2.in
> +++ b/rules/lvm2.in
> @@ -4,7 +4,6 @@ menuconfig LVM2
>  	tristate
>  	select LIBC_DL
>  	select GCCLIBS_GCC_S
> -	select LIBAIO

Keep this here with:

	select LIBAIO	if LVM2_LVM_TOOLS

>  	select READLINE
>  	select NCURSES
>  	select SYSTEMD if LVM2_SYSTEMD
> @@ -19,6 +18,7 @@ if LVM2
>  config LVM2_LVM_TOOLS
>  	bool
>  	default y
> +	select LIBAIO
>  	prompt "install lvm tools"
>  	help
>  	  If disabled, only dmsetup and the dm-mapper library are installed.
> diff --git a/rules/lvm2.make b/rules/lvm2.make
> index 6e781c66f..d45c89356 100644
> --- a/rules/lvm2.make
> +++ b/rules/lvm2.make
> @@ -90,6 +90,11 @@ LVM2_CONF_OPT := \
>  	--with-device-gid=$(PTXCONF_LVM2_DEVICE_GID) \
>  	--with-device-mode=$(PTXCONF_LVM2_DEVICE_MODE)
>  
> +ifndef PTXCONF_LVM2_LVM_TOOLS
> +LVM2_MAKE_OPT := device-mapper
> +LVM2_INSTALL_OPT := install_device-mapper
> +endif
> +
>  # ----------------------------------------------------------------------------
>  # Target-Install
>  # ----------------------------------------------------------------------------
> @@ -153,9 +158,9 @@ ifdef PTXCONF_LVM2_LVM_TOOLS
>  	@$(call install_link, lvm2, lvm, /usr/sbin/vgs)
>  	@$(call install_link, lvm2, lvm, /usr/sbin/vgscan)
>  	@$(call install_link, lvm2, lvm, /usr/sbin/vgsplit)
> -endif
>  
>  	@$(call install_alternative, lvm2, 0, 0, 0644, /etc/lvm/lvm.conf)
> +endif
>  
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper)
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper-event)
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |