From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 Jul 2026 08:03:43 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wfX03-00CW4F-25 for lore@lore.pengutronix.de; Fri, 03 Jul 2026 08:03:43 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wfX03-000132-FP; Fri, 03 Jul 2026 08:03:43 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wfWzo-00012E-Ta; Fri, 03 Jul 2026 08:03:29 +0200 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 9F05C20111C; Fri, 03 Jul 2026 08:03:28 +0200 (CEST) Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wfWzo-005reH-1j; Fri, 03 Jul 2026 08:03:28 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wfWzo-0000000FrWR-1qNs; Fri, 03 Jul 2026 08:03:28 +0200 Date: Fri, 3 Jul 2026 08:03:28 +0200 From: Michael Olbrich To: Sven =?utf-8?Q?P=C3=BCschel?= Message-ID: Mail-Followup-To: Sven =?utf-8?Q?P=C3=BCschel?= , ptxdist@pengutronix.de References: <20260630160303.2174761-1-s.pueschel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260630160303.2174761-1-s.pueschel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/2] lvm2: make libaio dependency conditional X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Jun 30, 2026 at 06:01:56PM +0200, Sven Püschel wrote: > When only using the device-mapper related part of lvm2, libaio is not > required. This requires us to only use the [install_]device-mapper > make targets to avoid trying to compile the lvm2 tools, which depend on > libaio. > > Also move the lvm2 configuration file to the LVM_TOOLS option, as it > won't be built by the device-mapper target and doesn't seem to be > relevant for dmsetup alone. > > Signed-off-by: Sven Püschel > --- > rules/lvm2.in | 2 +- > rules/lvm2.make | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/rules/lvm2.in b/rules/lvm2.in > index f0b8123fc..dc1724ecc 100644 > --- a/rules/lvm2.in > +++ b/rules/lvm2.in > @@ -4,7 +4,6 @@ menuconfig LVM2 > tristate > select LIBC_DL > select GCCLIBS_GCC_S > - select LIBAIO Keep this here with: select LIBAIO if LVM2_LVM_TOOLS > select READLINE > select NCURSES > select SYSTEMD if LVM2_SYSTEMD > @@ -19,6 +18,7 @@ if LVM2 > config LVM2_LVM_TOOLS > bool > default y > + select LIBAIO > prompt "install lvm tools" > help > If disabled, only dmsetup and the dm-mapper library are installed. > diff --git a/rules/lvm2.make b/rules/lvm2.make > index 6e781c66f..d45c89356 100644 > --- a/rules/lvm2.make > +++ b/rules/lvm2.make > @@ -90,6 +90,11 @@ LVM2_CONF_OPT := \ > --with-device-gid=$(PTXCONF_LVM2_DEVICE_GID) \ > --with-device-mode=$(PTXCONF_LVM2_DEVICE_MODE) > > +ifndef PTXCONF_LVM2_LVM_TOOLS > +LVM2_MAKE_OPT := device-mapper > +LVM2_INSTALL_OPT := install_device-mapper > +endif > + > # ---------------------------------------------------------------------------- > # Target-Install > # ---------------------------------------------------------------------------- > @@ -153,9 +158,9 @@ ifdef PTXCONF_LVM2_LVM_TOOLS > @$(call install_link, lvm2, lvm, /usr/sbin/vgs) > @$(call install_link, lvm2, lvm, /usr/sbin/vgscan) > @$(call install_link, lvm2, lvm, /usr/sbin/vgsplit) > -endif > > @$(call install_alternative, lvm2, 0, 0, 0644, /etc/lvm/lvm.conf) > +endif > > @$(call install_lib, lvm2, 0, 0, 0644, libdevmapper) > @$(call install_lib, lvm2, 0, 0, 0644, libdevmapper-event) > -- > 2.47.3 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |