mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: "Sven Püschel" <s.pueschel@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/2] lvm2: add option for libdevmapper-event.so
Date: Fri, 3 Jul 2026 08:04:32 +0200	[thread overview]
Message-ID: <akdQ8NF3bg3CWc6m@pengutronix.de> (raw)
In-Reply-To: <20260630160303.2174761-2-s.pueschel@pengutronix.de>

On Tue, Jun 30, 2026 at 06:01:57PM +0200, Sven Püschel wrote:
> Add an option for libdevmapper-event.so, as it's not required by
> dmsetup. This allows omitting the library, if it's not being used by
> any other application on the system.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> ---
>  rules/lvm2.in   | 6 ++++++
>  rules/lvm2.make | 3 +++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/rules/lvm2.in b/rules/lvm2.in
> index dc1724ecc..71d1c0c94 100644
> --- a/rules/lvm2.in
> +++ b/rules/lvm2.in
> @@ -19,6 +19,7 @@ config LVM2_LVM_TOOLS
>  	bool
>  	default y
>  	select LIBAIO
> +	select LVM2_LIBDEVMAPPER_EVENT
>  	prompt "install lvm tools"
>  	help
>  	  If disabled, only dmsetup and the dm-mapper library are installed.
> @@ -33,6 +34,11 @@ config LVM2_STARTSCRIPT
>  
>  endif
>  
> +config LVM2_LIBDEVMAPPER_EVENT
> +	bool
> +	default n

This line is redundant. Just remove it.

Michael

> +	prompt "install libdevmapper-event.so"
> +
>  config LVM2_DEVICE_UID
>  	int
>  	default 0
> diff --git a/rules/lvm2.make b/rules/lvm2.make
> index d45c89356..57773a1f7 100644
> --- a/rules/lvm2.make
> +++ b/rules/lvm2.make
> @@ -163,7 +163,10 @@ ifdef PTXCONF_LVM2_LVM_TOOLS
>  endif
>  
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper)
> +
> +ifdef PTXCONF_LVM2_LIBDEVMAPPER_EVENT
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper-event)
> +endif
>  
>  ifdef PTXCONF_LVM2_STARTSCRIPT
>  	@$(call install_alternative, lvm2, 0, 0, 0755, /etc/init.d/lvm2)
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2026-07-03  6:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 16:01 [ptxdist] [PATCH 1/2] lvm2: make libaio dependency conditional Sven Püschel
2026-06-30 16:01 ` [ptxdist] [PATCH 2/2] lvm2: add option for libdevmapper-event.so Sven Püschel
2026-07-03  6:04   ` Michael Olbrich [this message]
2026-07-03  6:03 ` [ptxdist] [PATCH 1/2] lvm2: make libaio dependency conditional Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akdQ8NF3bg3CWc6m@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=s.pueschel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox