* [ptxdist] [PATCH] libmodbus: adapt help text to the reality
@ 2023-03-09 9:08 Juergen Borleis
2023-03-09 9:29 ` Michael Olbrich
0 siblings, 1 reply; 8+ messages in thread
From: Juergen Borleis @ 2023-03-09 9:08 UTC (permalink / raw)
To: ptxdist
With change a08638d93d19624cf3c20d033ea8f61b96c43408
"libmodbus: version bump 2.0.4 -> 3.0.8"
libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
"libmodbus3: version bump 3.0.6 -> 3.1.4"
libmodbus3 switched to the recent to 3.1.x version.
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
rules/libmodbus.in | 4 ++--
rules/libmodbus3.in | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/rules/libmodbus.in b/rules/libmodbus.in
index f4f71fc..89ab189 100644
--- a/rules/libmodbus.in
+++ b/rules/libmodbus.in
@@ -4,7 +4,7 @@ config LIBMODBUS
prompt "libmodbus"
help
libmodbus is a library that implements the Modbus/RTU protocol
- (TCP and serial).
+ (TCP and serial) (Version 3.0.x).
- WWW: https://launchpad.net/libmodbus
+ WWW: https://libmodbus.org/
diff --git a/rules/libmodbus3.in b/rules/libmodbus3.in
index 3a950d7..d69a882 100644
--- a/rules/libmodbus3.in
+++ b/rules/libmodbus3.in
@@ -4,7 +4,7 @@ config LIBMODBUS3
prompt "libmodbus3"
help
libmodbus is a library that implements the Modbus protocol
- (TCP and serial) (Version 3.0.x).
+ (TCP and serial) (Version 3.1.x).
- WWW: http://http://libmodbus.org/
+ WWW: https://libmodbus.org/
--
2.30.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-09 9:08 [ptxdist] [PATCH] libmodbus: adapt help text to the reality Juergen Borleis
@ 2023-03-09 9:29 ` Michael Olbrich
2023-03-09 9:38 ` Alexander Dahl
0 siblings, 1 reply; 8+ messages in thread
From: Michael Olbrich @ 2023-03-09 9:29 UTC (permalink / raw)
To: Juergen Borleis; +Cc: Ladislav Michl, ptxdist
On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> With change a08638d93d19624cf3c20d033ea8f61b96c43408
> "libmodbus: version bump 2.0.4 -> 3.0.8"
> libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
>
> And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> "libmodbus3: version bump 3.0.6 -> 3.1.4"
> libmodbus3 switched to the recent to 3.1.x version.
Hmmm, it feels like there were supposed to be for two packages, one for
version 2.x and one for 3.x, at least it started that way.
I don't really know anything about libmodbus. Are the two versions
incompatible?
Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
any insight here?
Michael
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
> rules/libmodbus.in | 4 ++--
> rules/libmodbus3.in | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/rules/libmodbus.in b/rules/libmodbus.in
> index f4f71fc..89ab189 100644
> --- a/rules/libmodbus.in
> +++ b/rules/libmodbus.in
> @@ -4,7 +4,7 @@ config LIBMODBUS
> prompt "libmodbus"
> help
> libmodbus is a library that implements the Modbus/RTU protocol
> - (TCP and serial).
> + (TCP and serial) (Version 3.0.x).
>
> - WWW: https://launchpad.net/libmodbus
> + WWW: https://libmodbus.org/
>
> diff --git a/rules/libmodbus3.in b/rules/libmodbus3.in
> index 3a950d7..d69a882 100644
> --- a/rules/libmodbus3.in
> +++ b/rules/libmodbus3.in
> @@ -4,7 +4,7 @@ config LIBMODBUS3
> prompt "libmodbus3"
> help
> libmodbus is a library that implements the Modbus protocol
> - (TCP and serial) (Version 3.0.x).
> + (TCP and serial) (Version 3.1.x).
>
> - WWW: http://http://libmodbus.org/
> + WWW: https://libmodbus.org/
>
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-09 9:29 ` Michael Olbrich
@ 2023-03-09 9:38 ` Alexander Dahl
2023-03-09 13:24 ` Ladislav Michl
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Dahl @ 2023-03-09 9:38 UTC (permalink / raw)
To: Juergen Borleis, ptxdist, Ladislav Michl
Hei hei,
Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > "libmodbus: version bump 2.0.4 -> 3.0.8"
> > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> >
> > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > libmodbus3 switched to the recent to 3.1.x version.
>
> Hmmm, it feels like there were supposed to be for two packages, one for
> version 2.x and one for 3.x, at least it started that way.
> I don't really know anything about libmodbus. Are the two versions
> incompatible?
Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
notes and the code trying to distinguish this.
Greets
Alex
>
> Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> any insight here?
>
> Michael
>
>
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > ---
> > rules/libmodbus.in | 4 ++--
> > rules/libmodbus3.in | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/rules/libmodbus.in b/rules/libmodbus.in
> > index f4f71fc..89ab189 100644
> > --- a/rules/libmodbus.in
> > +++ b/rules/libmodbus.in
> > @@ -4,7 +4,7 @@ config LIBMODBUS
> > prompt "libmodbus"
> > help
> > libmodbus is a library that implements the Modbus/RTU protocol
> > - (TCP and serial).
> > + (TCP and serial) (Version 3.0.x).
> >
> > - WWW: https://launchpad.net/libmodbus
> > + WWW: https://libmodbus.org/
> >
> > diff --git a/rules/libmodbus3.in b/rules/libmodbus3.in
> > index 3a950d7..d69a882 100644
> > --- a/rules/libmodbus3.in
> > +++ b/rules/libmodbus3.in
> > @@ -4,7 +4,7 @@ config LIBMODBUS3
> > prompt "libmodbus3"
> > help
> > libmodbus is a library that implements the Modbus protocol
> > - (TCP and serial) (Version 3.0.x).
> > + (TCP and serial) (Version 3.1.x).
> >
> > - WWW: http://http://libmodbus.org/
> > + WWW: https://libmodbus.org/
> >
> > --
> > 2.30.2
> >
> >
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-09 9:38 ` Alexander Dahl
@ 2023-03-09 13:24 ` Ladislav Michl
2023-03-09 13:29 ` Juergen Borleis
0 siblings, 1 reply; 8+ messages in thread
From: Ladislav Michl @ 2023-03-09 13:24 UTC (permalink / raw)
To: Juergen Borleis, ptxdist
On Thu, Mar 09, 2023 at 10:38:15AM +0100, Alexander Dahl wrote:
> Hei hei,
>
> Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> > On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > > "libmodbus: version bump 2.0.4 -> 3.0.8"
> > > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> > >
> > > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > > "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > > libmodbus3 switched to the recent to 3.1.x version.
> >
> > Hmmm, it feels like there were supposed to be for two packages, one for
> > version 2.x and one for 3.x, at least it started that way.
> > I don't really know anything about libmodbus. Are the two versions
> > incompatible?
>
> Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
> 3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
> notes and the code trying to distinguish this.
>
> Greets
> Alex
>
> >
> > Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> > any insight here?
As Alex pointed out above, 2.0.x has incompatible API and was last
touched 12 years ago. I pretty much doubt anything sane currently depends
on it and the truth is I overlooked libmodbus3 while doing update.
Now I would vote to simply remove libmodbus3 and continue updating
libmodbus.
ladis
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-09 13:24 ` Ladislav Michl
@ 2023-03-09 13:29 ` Juergen Borleis
2023-03-10 11:57 ` Michael Olbrich
0 siblings, 1 reply; 8+ messages in thread
From: Juergen Borleis @ 2023-03-09 13:29 UTC (permalink / raw)
To: Ladislav Michl; +Cc: ptxdist
Am Donnerstag, dem 09.03.2023 um 14:24 +0100 schrieb Ladislav Michl:
> On Thu, Mar 09, 2023 at 10:38:15AM +0100, Alexander Dahl wrote:
> > Hei hei,
> >
> > Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> > > On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > > > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > > > "libmodbus: version bump 2.0.4 -> 3.0.8"
> > > > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> > > >
> > > > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > > > "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > > > libmodbus3 switched to the recent to 3.1.x version.
> > >
> > > Hmmm, it feels like there were supposed to be for two packages, one for
> > > version 2.x and one for 3.x, at least it started that way.
> > > I don't really know anything about libmodbus. Are the two versions
> > > incompatible?
> >
> > Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
> > 3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
> > notes and the code trying to distinguish this.
> >
> > Greets
> > Alex
> >
> > >
> > > Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> > > any insight here?
>
> As Alex pointed out above, 2.0.x has incompatible API and was last
> touched 12 years ago. I pretty much doubt anything sane currently depends
> on it and the truth is I overlooked libmodbus3 while doing update.
It is even more worse: 2.x.x API != 3.0.x API != 3.1.x API 🙂
jb
--
Pengutronix e.K. | Juergen Borleis |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-128 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-09 13:29 ` Juergen Borleis
@ 2023-03-10 11:57 ` Michael Olbrich
2023-03-10 12:49 ` Juergen Borleis
0 siblings, 1 reply; 8+ messages in thread
From: Michael Olbrich @ 2023-03-10 11:57 UTC (permalink / raw)
To: Juergen Borleis; +Cc: Ladislav Michl, ptxdist
On Thu, Mar 09, 2023 at 02:29:25PM +0100, Juergen Borleis wrote:
> Am Donnerstag, dem 09.03.2023 um 14:24 +0100 schrieb Ladislav Michl:
> > On Thu, Mar 09, 2023 at 10:38:15AM +0100, Alexander Dahl wrote:
> > > Hei hei,
> > >
> > > Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> > > > On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > > > > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > > > > "libmodbus: version bump 2.0.4 -> 3.0.8"
> > > > > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> > > > >
> > > > > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > > > > "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > > > > libmodbus3 switched to the recent to 3.1.x version.
> > > >
> > > > Hmmm, it feels like there were supposed to be for two packages, one for
> > > > version 2.x and one for 3.x, at least it started that way.
> > > > I don't really know anything about libmodbus. Are the two versions
> > > > incompatible?
> > >
> > > Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
> > > 3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
> > > notes and the code trying to distinguish this.
> > >
> > > Greets
> > > Alex
> > >
> > > >
> > > > Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> > > > any insight here?
> >
> > As Alex pointed out above, 2.0.x has incompatible API and was last
> > touched 12 years ago. I pretty much doubt anything sane currently depends
> > on it and the truth is I overlooked libmodbus3 while doing update.
>
> It is even more worse: 2.x.x API != 3.0.x API != 3.1.x API 🙂
I'm tempted to say we just need 3.1.x in PTXdist upstream. Unless updating
an application from 3.0.x to 3.1.x is difficult, because the API changed
a lot?
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-10 11:57 ` Michael Olbrich
@ 2023-03-10 12:49 ` Juergen Borleis
2023-03-11 21:48 ` Ladislav Michl
0 siblings, 1 reply; 8+ messages in thread
From: Juergen Borleis @ 2023-03-10 12:49 UTC (permalink / raw)
To: Michael Olbrich; +Cc: Ladislav Michl, ptxdist
Am Freitag, dem 10.03.2023 um 12:57 +0100 schrieb Michael Olbrich:
> On Thu, Mar 09, 2023 at 02:29:25PM +0100, Juergen Borleis wrote:
> > Am Donnerstag, dem 09.03.2023 um 14:24 +0100 schrieb Ladislav Michl:
> > > On Thu, Mar 09, 2023 at 10:38:15AM +0100, Alexander Dahl wrote:
> > > > Hei hei,
> > > >
> > > > Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> > > > > On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > > > > > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > > > > > "libmodbus: version bump 2.0.4 -> 3.0.8"
> > > > > > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> > > > > >
> > > > > > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > > > > > "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > > > > > libmodbus3 switched to the recent to 3.1.x version.
> > > > >
> > > > > Hmmm, it feels like there were supposed to be for two packages, one for
> > > > > version 2.x and one for 3.x, at least it started that way.
> > > > > I don't really know anything about libmodbus. Are the two versions
> > > > > incompatible?
> > > >
> > > > Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
> > > > 3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
> > > > notes and the code trying to distinguish this.
> > > >
> > > > Greets
> > > > Alex
> > > >
> > > > >
> > > > > Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> > > > > any insight here?
> > >
> > > As Alex pointed out above, 2.0.x has incompatible API and was last
> > > touched 12 years ago. I pretty much doubt anything sane currently depends
> > > on it and the truth is I overlooked libmodbus3 while doing update.
> >
> > It is even more worse: 2.x.x API != 3.0.x API != 3.1.x API 🙂
>
> I'm tempted to say we just need 3.1.x in PTXdist upstream. Unless updating
> an application from 3.0.x to 3.1.x is difficult, because the API changed
> a lot?
I don't know. I read the documentation and it just pointed out this API
incompatibility. Thus, no idea how difficult it would be to port a user from
3.0.x to 3.1.x.
Jürgen
--
Pengutronix e.K. | Juergen Borleis |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-128 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
2023-03-10 12:49 ` Juergen Borleis
@ 2023-03-11 21:48 ` Ladislav Michl
0 siblings, 0 replies; 8+ messages in thread
From: Ladislav Michl @ 2023-03-11 21:48 UTC (permalink / raw)
To: Juergen Borleis; +Cc: Michael Olbrich, ptxdist
On Fri, Mar 10, 2023 at 01:49:28PM +0100, Juergen Borleis wrote:
> Am Freitag, dem 10.03.2023 um 12:57 +0100 schrieb Michael Olbrich:
> > On Thu, Mar 09, 2023 at 02:29:25PM +0100, Juergen Borleis wrote:
> > > It is even more worse: 2.x.x API != 3.0.x API != 3.1.x API 🙂
> >
> > I'm tempted to say we just need 3.1.x in PTXdist upstream. Unless updating
> > an application from 3.0.x to 3.1.x is difficult, because the API changed
> > a lot?
>
> I don't know. I read the documentation and it just pointed out this API
> incompatibility. Thus, no idea how difficult it would be to port a user from
> 3.0.x to 3.1.x.
There are no in-tree libmodbus users, so let's put it simple: any out of
tree package depending on 3.0.x will carry local libmodbus 3.0.x rule
or update to 3.1.x ;-)
ladis
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-11 21:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 9:08 [ptxdist] [PATCH] libmodbus: adapt help text to the reality Juergen Borleis
2023-03-09 9:29 ` Michael Olbrich
2023-03-09 9:38 ` Alexander Dahl
2023-03-09 13:24 ` Ladislav Michl
2023-03-09 13:29 ` Juergen Borleis
2023-03-10 11:57 ` Michael Olbrich
2023-03-10 12:49 ` Juergen Borleis
2023-03-11 21:48 ` Ladislav Michl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox