mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: Ladislav Michl <oss-lists@triops.cz>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libmodbus: adapt help text to the reality
Date: Fri, 10 Mar 2023 12:57:11 +0100	[thread overview]
Message-ID: <ZAsbF5p4l4dl98An@pengutronix.de> (raw)
In-Reply-To: <16802f944bc6d8e4df84cea80d1adaf9c17a04a2.camel@pengutronix.de>

On Thu, Mar 09, 2023 at 02:29:25PM +0100, Juergen Borleis wrote:
> Am Donnerstag, dem 09.03.2023 um 14:24 +0100 schrieb Ladislav Michl:
> > On Thu, Mar 09, 2023 at 10:38:15AM +0100, Alexander Dahl wrote:
> > > Hei hei,
> > > 
> > > Am Thu, Mar 09, 2023 at 10:29:06AM +0100 schrieb Michael Olbrich:
> > > > On Thu, Mar 09, 2023 at 10:08:50AM +0100, Juergen Borleis wrote:
> > > > > With change a08638d93d19624cf3c20d033ea8f61b96c43408
> > > > >   "libmodbus: version bump 2.0.4 -> 3.0.8"
> > > > > libmodbus changed from 2.x.x to 3.0.x version like libmodbus3 did.
> > > > > 
> > > > > And with change a76b31d5b637bc89ca26e7fa81503cbc7632b666
> > > > >   "libmodbus3: version bump 3.0.6 -> 3.1.4"
> > > > > libmodbus3 switched to the recent to 3.1.x version.
> > > > 
> > > > Hmmm, it feels like there were supposed to be for two packages, one for
> > > > version 2.x and one for 3.x, at least it started that way.
> > > > I don't really know anything about libmodbus. Are the two versions
> > > > incompatible?
> > > 
> > > Yes, 3.0.x and 3.1.x have incompatible APIs and probably ABIs.
> > > 3.0.x has .so version 5 and 3.1.x has .so version 6, at least to my
> > > notes and the code trying to distinguish this.
> > > 
> > > Greets
> > > Alex
> > > 
> > > > 
> > > > Ladislav, you touched it last, you did the "2.0.4 -> 3.0.8". Do you have
> > > > any insight here?
> > 
> > As Alex pointed out above, 2.0.x has incompatible API and was last
> > touched 12 years ago. I pretty much doubt anything sane currently depends
> > on it and the truth is I overlooked libmodbus3 while doing update.
> 
> It is even more worse: 2.x.x API != 3.0.x API != 3.1.x API 🙂

I'm tempted to say we just need 3.1.x in PTXdist upstream. Unless updating
an application from 3.0.x to 3.1.x is difficult, because the API changed
a lot?

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-03-10 11:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  9:08 Juergen Borleis
2023-03-09  9:29 ` Michael Olbrich
2023-03-09  9:38   ` Alexander Dahl
2023-03-09 13:24     ` Ladislav Michl
2023-03-09 13:29       ` Juergen Borleis
2023-03-10 11:57         ` Michael Olbrich [this message]
2023-03-10 12:49           ` Juergen Borleis
2023-03-11 21:48             ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAsbF5p4l4dl98An@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=jbe@pengutronix.de \
    --cc=oss-lists@triops.cz \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox