* [ptxdist] [PATCH] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case
@ 2022-03-18 13:19 Bastian Krause
2022-03-24 15:13 ` Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Bastian Krause @ 2022-03-18 13:19 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Without SYSTEMD_UDEV_PERSISTENT_V4L v4l2deviceprovider (and
gst-device-monitor-1.0) will not find any v4l2 devices.
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
rules/gst-plugins-good1.in | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/rules/gst-plugins-good1.in b/rules/gst-plugins-good1.in
index aeac2cbc8..eb8820d11 100644
--- a/rules/gst-plugins-good1.in
+++ b/rules/gst-plugins-good1.in
@@ -27,6 +27,8 @@ menuconfig GST_PLUGINS_GOOD1
select QT5_MODULE_QTDECLARATIVE if GST_PLUGINS_GOOD1_QT5
select LIBSHOUT if GST_PLUGINS_GOOD1_SHOUT2
select LIBSOUP if GST_PLUGINS_GOOD1_SOUP
+ select SYSTEMD if GST_PLUGINS_GOOD1_SYSTEMD
+ select SYSTEMD_UDEV_PERSISTENT_V4L if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD
select SPEEX if GST_PLUGINS_GOOD1_SPEEX
select TWOLAME if GST_PLUGINS_GOOD1_TWOLAME
select LIBGUDEV if GST_PLUGINS_GOOD1_V4L2
@@ -356,6 +358,10 @@ config GST_PLUGINS_GOOD1_SPEEX
help
Speex audio codec plugin
+config GST_PLUGINS_GOOD1_SYSTEMD
+ bool
+ default INITMETHOD_SYSTEMD
+
config GST_PLUGINS_GOOD1_TAGLIB
bool
# needs libtag
--
2.30.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [PATCH] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case
2022-03-18 13:19 [ptxdist] [PATCH] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case Bastian Krause
@ 2022-03-24 15:13 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2022-03-24 15:13 UTC (permalink / raw)
To: Bastian Krause; +Cc: ptxdist
On Fri, Mar 18, 2022 at 02:19:04PM +0100, Bastian Krause wrote:
> Without SYSTEMD_UDEV_PERSISTENT_V4L v4l2deviceprovider (and
> gst-device-monitor-1.0) will not find any v4l2 devices.
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> rules/gst-plugins-good1.in | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/rules/gst-plugins-good1.in b/rules/gst-plugins-good1.in
> index aeac2cbc8..eb8820d11 100644
> --- a/rules/gst-plugins-good1.in
> +++ b/rules/gst-plugins-good1.in
> @@ -27,6 +27,8 @@ menuconfig GST_PLUGINS_GOOD1
> select QT5_MODULE_QTDECLARATIVE if GST_PLUGINS_GOOD1_QT5
> select LIBSHOUT if GST_PLUGINS_GOOD1_SHOUT2
> select LIBSOUP if GST_PLUGINS_GOOD1_SOUP
> + select SYSTEMD if GST_PLUGINS_GOOD1_SYSTEMD
> + select SYSTEMD_UDEV_PERSISTENT_V4L if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD
Both should have the same dependencies. No need to select systemd if
GST_PLUGINS_GOOD1_V4L2 is not enabled. Also: This is only a runtime
dependency, right? So add '&& RUNTIME' as well.
Michael
> select SPEEX if GST_PLUGINS_GOOD1_SPEEX
> select TWOLAME if GST_PLUGINS_GOOD1_TWOLAME
> select LIBGUDEV if GST_PLUGINS_GOOD1_V4L2
> @@ -356,6 +358,10 @@ config GST_PLUGINS_GOOD1_SPEEX
> help
> Speex audio codec plugin
>
> +config GST_PLUGINS_GOOD1_SYSTEMD
> + bool
> + default INITMETHOD_SYSTEMD
> +
> config GST_PLUGINS_GOOD1_TAGLIB
> bool
> # needs libtag
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-24 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 13:19 [ptxdist] [PATCH] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case Bastian Krause
2022-03-24 15:13 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox