From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 24 Mar 2022 16:14:13 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nXPA9-004kvw-VJ for lore@lore.pengutronix.de; Thu, 24 Mar 2022 16:14:13 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nXPAC-0002im-A5; Thu, 24 Mar 2022 16:14:12 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXP9C-0002ic-Sf; Thu, 24 Mar 2022 16:13:10 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nXP99-002ij3-F9; Thu, 24 Mar 2022 16:13:10 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nXP9B-001Nde-IM; Thu, 24 Mar 2022 16:13:09 +0100 Date: Thu, 24 Mar 2022 16:13:09 +0100 From: Michael Olbrich To: Bastian Krause Message-ID: Mail-Followup-To: Bastian Krause , ptxdist@pengutronix.de References: <20220318131904.3018834-1-bst@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220318131904.3018834-1-bst@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Mar 18, 2022 at 02:19:04PM +0100, Bastian Krause wrote: > Without SYSTEMD_UDEV_PERSISTENT_V4L v4l2deviceprovider (and > gst-device-monitor-1.0) will not find any v4l2 devices. > > Signed-off-by: Bastian Krause > --- > rules/gst-plugins-good1.in | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/rules/gst-plugins-good1.in b/rules/gst-plugins-good1.in > index aeac2cbc8..eb8820d11 100644 > --- a/rules/gst-plugins-good1.in > +++ b/rules/gst-plugins-good1.in > @@ -27,6 +27,8 @@ menuconfig GST_PLUGINS_GOOD1 > select QT5_MODULE_QTDECLARATIVE if GST_PLUGINS_GOOD1_QT5 > select LIBSHOUT if GST_PLUGINS_GOOD1_SHOUT2 > select LIBSOUP if GST_PLUGINS_GOOD1_SOUP > + select SYSTEMD if GST_PLUGINS_GOOD1_SYSTEMD > + select SYSTEMD_UDEV_PERSISTENT_V4L if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD Both should have the same dependencies. No need to select systemd if GST_PLUGINS_GOOD1_V4L2 is not enabled. Also: This is only a runtime dependency, right? So add '&& RUNTIME' as well. Michael > select SPEEX if GST_PLUGINS_GOOD1_SPEEX > select TWOLAME if GST_PLUGINS_GOOD1_TWOLAME > select LIBGUDEV if GST_PLUGINS_GOOD1_V4L2 > @@ -356,6 +358,10 @@ config GST_PLUGINS_GOOD1_SPEEX > help > Speex audio codec plugin > > +config GST_PLUGINS_GOOD1_SYSTEMD > + bool > + default INITMETHOD_SYSTEMD > + > config GST_PLUGINS_GOOD1_TAGLIB > bool > # needs libtag > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de